From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f50.google.com (mail-pj1-f50.google.com [209.85.216.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 363A7435A9C for ; Mon, 10 Aug 2026 18:11:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.50 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786385497; cv=none; b=OWKzAXmE99lj1sOSssr5kbRcUoLrNQmQjmjSw5cO+c3BqmiMDTUs0SXmc0rPbbDS18LJE8WaOV7bfLVIbZoNSPGpj2c9v+KlIYgUuj1Zv2LXygYoCTig5Merh0bzkEMC3fK3Zi+U6F9bltstroXzxR13JPYQqzD6UVSmTgj+L9g= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786385497; c=relaxed/simple; bh=yNW/T5FeMOjAddNqHQhDND7Stuqs/EAs9+VIYXSqtKY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=gLEl4D8jiRFQ5ThMsTF2/eZQ3mXqs42eWl7GOP8GT4NNqQ0mMsaIJxLOuMg90C0jcTa9nqtC/Rfz3ipPb8dQ8zhenRy+PXhhH9keRLoLLO2a2k+POOt/1Q8Il2qLoLg2p9QumOb21MI5j75CdcRVFwsCEq0Zu8sZ1f8mHIeygmU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=ZecYkWU1; arc=none smtp.client-ip=209.85.216.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ZecYkWU1" Received: by mail-pj1-f50.google.com with SMTP id 98e67ed59e1d1-38dcbade417so9859a91.1 for ; Mon, 10 Aug 2026 11:11:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1786385496; x=1786990296; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=ZhvQ0nLd8X2lUGK/yPjcMAYgujrbK07Er9DeXa2ehmE=; b=ZecYkWU1MxBukIQvCzrv7c+Fc442qKLxNtVvVNzflJVzMj+8Lh+YGRcu/aTk7FjxJK JynUCTiqDscc6Nf+GfyTcg1jYAhpDHVy/duYp67gQOMvqNoTJlmdFZGdzU6lf+3nzPFS m9wQlAQVZdrTV7oUVaFbjt6j1w2cH7R/sc022TVXDPDXeKO6nTz51ntWLpqunR60vlXA lw0DaKmvwdyRmz0xu1Ivzu+Ge7rVc9wkCbQM889CPrdPkJJ4kEW0Vlly74uwP6HhwbBQ VD3LNPKIQMtBbqDcDf2iuAJYP8LwgLNEd91LKbXeD9yhtZqX4Y2CUT6INl2sRKdXPEs1 QgFQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786385496; x=1786990296; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=ZhvQ0nLd8X2lUGK/yPjcMAYgujrbK07Er9DeXa2ehmE=; b=LUtpvY1XRgBwkIJqJBVjJSWH6za4aa5CcY5hfIWxezplOinQJMbYvlJgnv5Vet0Afg UTxnvLOcXguygvbDCoIBhqStAIKtKD8RQ9YbDr32IqMGRjGXYg3rk06Ty2yZAr/482Jc yFJytXmUSStdNohP4qI9W26+xVrRvAnAXjcPCWP/6cGhxbtAXSIm4yuJiohtmmj+sGbl k2kvU9XsjONoKyCRhCNIqWF1hIYX+BxFHOvQ1dkhbNr66RM1K37Q79+Jrp4zSARXR8wS wG78D4RP9wayTnqKpnfZwJ3fqQAgpv3EQM7oNtrteQCnLXz3qJX6ec2gv0wD268KQvLo 9JAg== X-Forwarded-Encrypted: i=1; AHgh+RqC9liO9oAuBcBc7Br+f4p0xTyjf7ZJXY6Wnq/V5O7BrorZpe/FQJGfr9tTnWVNMkyvHx32v6ZyLDznXQc=@vger.kernel.org X-Gm-Message-State: AOJu0Yy706vyoz3zMi+TuWoJ/IECFERhIPUud5cCUMMXkWj10HSWLwOc U7L3D9AHXJr/mRoeIJiZNw18UR4gGHJylbCC6Y/ug4LLx1/5gwgHGvHS X-Gm-Gg: AR+sD12vmpvCqST4XuR7VvwoC6+w5enTayj3DGMtQvjxxzsLq18nmcHEuAS4cR7VBg0 pxvfK8nyaQFUmOSx5VvEKM77x8jabKuwHkyo7N88yBiwbwQk9Iq5bU9tE/zSEeKyC6Otl4QRhvf GTX1rDun9iSRlnRn532n+RmxvxenrIetTc0s/2MsTioZ6iS3dbXxGOyYULiRn6NG6FakUUZSgWX tUPR4pmWmiqBRXu4C9goWh2QbI71ItzyMcCwRlSJgZbsOm1890BTvnW30Q+p6fwREXfz+dNXDRJ pMqjnKCFG+p7a9lODj9nC4mLDauNPe5kJFsjh9eOAznrgD6/X2F7vq3B5kmZ3+s0BaFNaP9TvxK 1zg111LOwNCjkn+dEFoKGS7kBIjarT31fHBSF2t9AgNVfGq0GVhRBVmcSc/T0iRdWV8e0wdPv+9 INFNZ2D7zlBvMQxBsfsInG4WmZwTUzWElIRDwYhbem9sl3vjXNmtKIKMO3QqFU3s/gtu8Vv40Ar w== X-Received: by 2002:a17:90b:1811:b0:38e:c7b0:84ad with SMTP id 98e67ed59e1d1-3903bb0ab77mr40673994a91.0.1786385495692; Mon, 10 Aug 2026 11:11:35 -0700 (PDT) Received: from cryptic.lan ([2001:569:7fa9:fa00:b1a9:6513:83c6:1d23]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-392d53b873asm472795a91.17.2026.08.10.11.11.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 10 Aug 2026 11:11:35 -0700 (PDT) From: Allen Pais To: Vinod Koul , Frank Li Cc: Allen Pais , dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org, Arnd Bergmann , Kees Cook , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org Subject: [PATCH v3 08/34] dmaengine: imx-dma: flip per-chan tasklet to dmaengine BH Date: Mon, 10 Aug 2026 11:09:09 -0700 Message-ID: <787938bdaef4c3530b4bf0296386a33928b877f0.1786384168.git.allen.lkml@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Replace the per-channel tasklet with the shared dmaengine BH helper. The handler continues to run in softirq context while dmaengine owns the common scheduling and teardown mechanism. Signed-off-by: Allen Pais --- drivers/dma/imx-dma.c | 26 +++++++++++++------------- 1 file changed, 13 insertions(+), 13 deletions(-) diff --git a/drivers/dma/imx-dma.c b/drivers/dma/imx-dma.c index 81c6276436f8..308fe407fe16 100644 --- a/drivers/dma/imx-dma.c +++ b/drivers/dma/imx-dma.c @@ -145,7 +145,6 @@ struct imxdma_channel { struct imxdma_engine *imxdma; unsigned int channel; - struct tasklet_struct dma_tasklet; struct list_head ld_free; struct list_head ld_queue; struct list_head ld_active; @@ -344,8 +343,8 @@ static void imxdma_watchdog(struct timer_list *t) imx_dmav1_writel(imxdma, 0, DMA_CCR(channel)); - /* Tasklet watchdog error handler */ - tasklet_schedule(&imxdmac->dma_tasklet); + /* BH watchdog error handler */ + dmaengine_schedule_bh(&imxdmac->chan); dev_dbg(imxdma->dev, "channel %d: watchdog timeout!\n", imxdmac->channel); } @@ -390,8 +389,8 @@ static irqreturn_t imxdma_err_handler(int irq, void *dev_id) imx_dmav1_writel(imxdma, 1 << i, DMA_DBOSR); errcode |= IMX_DMA_ERR_BUFFER; } - /* Tasklet error handler */ - tasklet_schedule(&imxdma->channel[i].dma_tasklet); + /* BH error handler */ + dmaengine_schedule_bh(&imxdma->channel[i].chan); dev_warn(imxdma->dev, "DMA timeout on channel %d -%s%s%s%s\n", i, @@ -448,8 +447,8 @@ static void dma_irq_handle_channel(struct imxdma_channel *imxdmac) imx_dmav1_writel(imxdma, tmp, DMA_CCR(chno)); if (imxdma_chan_is_doing_cyclic(imxdmac)) - /* Tasklet progression */ - tasklet_schedule(&imxdmac->dma_tasklet); + /* BH progression */ + dmaengine_schedule_bh(&imxdmac->chan); return; } @@ -462,8 +461,8 @@ static void dma_irq_handle_channel(struct imxdma_channel *imxdmac) out: imx_dmav1_writel(imxdma, 0, DMA_CCR(chno)); - /* Tasklet irq */ - tasklet_schedule(&imxdmac->dma_tasklet); + /* Schedule the IRQ BH */ + dmaengine_schedule_bh(&imxdmac->chan); } static irqreturn_t dma_irq_handler(int irq, void *dev_id) @@ -592,9 +591,10 @@ static int imxdma_xfer_desc(struct imxdma_desc *d) return 0; } -static void imxdma_tasklet(struct tasklet_struct *t) +static void imxdma_tasklet(struct dma_chan *chan) { - struct imxdma_channel *imxdmac = from_tasklet(imxdmac, t, dma_tasklet); + struct imxdma_channel *imxdmac = container_of(chan, struct imxdma_channel, + chan); struct imxdma_engine *imxdma = imxdmac->imxdma; struct imxdma_desc *desc, *next_desc; unsigned long flags; @@ -1142,7 +1142,7 @@ static int __init imxdma_probe(struct platform_device *pdev) INIT_LIST_HEAD(&imxdmac->ld_free); INIT_LIST_HEAD(&imxdmac->ld_active); - tasklet_setup(&imxdmac->dma_tasklet, imxdma_tasklet); + dmaengine_init_bh(&imxdmac->chan, imxdma_tasklet); imxdmac->chan.device = &imxdma->dma_device; dma_cookie_init(&imxdmac->chan); imxdmac->channel = i; @@ -1211,7 +1211,7 @@ static void imxdma_free_irq(struct platform_device *pdev, struct imxdma_engine * if (!is_imx1_dma(imxdma)) disable_irq(imxdmac->irq); - tasklet_kill(&imxdmac->dma_tasklet); + dmaengine_kill_bh(&imxdmac->chan); } } -- 2.43.0