From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7FBD1C433FE for ; Thu, 3 Feb 2022 15:36:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1351887AbiBCPg3 (ORCPT ); Thu, 3 Feb 2022 10:36:29 -0500 Received: from smtp-relay-internal-1.canonical.com ([185.125.188.123]:41398 "EHLO smtp-relay-internal-1.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1351862AbiBCPg0 (ORCPT ); Thu, 3 Feb 2022 10:36:26 -0500 Received: from mail-ed1-f70.google.com (mail-ed1-f70.google.com [209.85.208.70]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-internal-1.canonical.com (Postfix) with ESMTPS id DB2FC40031 for ; Thu, 3 Feb 2022 15:36:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1643902585; bh=0PbrYUBCm7YsogxgvzFxegtO4WGK61hGVIm8dEbT1U0=; h=Message-ID:Date:MIME-Version:Subject:To:References:From: In-Reply-To:Content-Type; b=J8G+j1wiAj3v41MACtenpKqehdWU0Eu93442lA43kZdgFwdQthh7AMVSPKcAWhU/h kQl1yOtaMstq2Hd9Dj8MNH2N6YeLqmjSwAcQ7EZ712VzGMDvalZyLDUPLLU48niser GLer9P3Ns/HUPceMGO6rsqiWD7u7EumsS0LTA182/tp6soz3sVRpUZxdl0Ynur4Kmc O+IlG637zuHtDHlszt6eVm4LnBuJ2U0QuD+faPeqKGqR/JQI0zyTc6xKPOBV45qqNw gAqSU9DpKepu5UnZ/yCBJd8oNI/BDlNpPwBnZLqkFFbGX7r5nHEksD4Tu1KL12pzRs j5ZrcmtRgPKeQ== Received: by mail-ed1-f70.google.com with SMTP id c23-20020a056402159700b00406aa42973eso1660231edv.2 for ; Thu, 03 Feb 2022 07:36:25 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:references:from:in-reply-to :content-transfer-encoding; bh=0PbrYUBCm7YsogxgvzFxegtO4WGK61hGVIm8dEbT1U0=; b=jfxa0PCzh5gHIZCp/XPRV6nh4eN3vUOv7ixQ/p4LLW4Xz7RMiaanVjxdwjqxw1Aomi UQOKzNdO34jSfshZ8tzvV5RC83rttVYkI444HJaxGizBSM3WlTC4ALbFmOdyMtnpU0r7 pNtqOt6bQVYXUqiv4kmAn0yqNqsX/O6BXpbblP5x0akHZ10eYRJeWD1WGCqRq/+xcMy0 iOx2s9bcCW4InLt38XArU2E4raWd/fzggbVz65+KjD8rxvIc03GF1wsRNUJcARw/ZDWi Xi1SAgc9OsSIFpuKur5yQquglg8CiiULXDDSyWC1mm3q4oAItGMsh9KBMw0qdTpq+cnj V2yg== X-Gm-Message-State: AOAM533L4diFwxnlRZk6y5/coN6uPc2v6QMSNx8dJqYen2/ZWgDbDp5x UaRAIL7fMiDpK591ZHf2ufiedvrg0yeWF2KKX+Iu+rP7l0rk1IKxs3mkD/GAzj4rqAyqbr7Ieex ZM4o34rEeG+0yhflhN4Afn6Gu4510B5rqsAl5dRuw6w== X-Received: by 2002:a05:6402:7d7:: with SMTP id u23mr14268960edy.451.1643902585514; Thu, 03 Feb 2022 07:36:25 -0800 (PST) X-Google-Smtp-Source: ABdhPJzxCBPYj3hXFA54L4u4Byd3GvnXIPuGZ5/7CTht1imE1hR5HwgP9k3njjsYkCMpIYeyISx5Sw== X-Received: by 2002:a05:6402:7d7:: with SMTP id u23mr14268948edy.451.1643902585375; Thu, 03 Feb 2022 07:36:25 -0800 (PST) Received: from [192.168.0.81] (xdsl-188-155-168-84.adslplus.ch. [188.155.168.84]) by smtp.gmail.com with ESMTPSA id 5sm23446951edx.32.2022.02.03.07.36.24 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 03 Feb 2022 07:36:24 -0800 (PST) Message-ID: <787b0060-266e-0efd-1bbb-43c33abcbb24@canonical.com> Date: Thu, 3 Feb 2022 16:36:24 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: [PATCH 2/3] ARM: dts: exynos: add simple battery to p4note Content-Language: en-US To: =?UTF-8?Q?Martin_J=c3=bccker?= , Rob Herring , Alim Akhtar , Russell King , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org References: <5d15937b6a7c4ae82a8f0d164fa28a4d4ad46325.1643757744.git.martin.juecker@gmail.com> <9436c417fc542eaa74011046369e089a68eea39e.1643757744.git.martin.juecker@gmail.com> From: Krzysztof Kozlowski In-Reply-To: <9436c417fc542eaa74011046369e089a68eea39e.1643757744.git.martin.juecker@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 02/02/2022 17:34, Martin Jücker wrote: > Add a simple battery node to the p4note device tree to set the missing > values for the charger to work properly. > > Signed-off-by: Martin Jücker > --- > arch/arm/boot/dts/exynos4412-p4note.dtsi | 15 ++++++++++++++- > 1 file changed, 14 insertions(+), 1 deletion(-) > > diff --git a/arch/arm/boot/dts/exynos4412-p4note.dtsi b/arch/arm/boot/dts/exynos4412-p4note.dtsi > index 63459db653ea..fcd75cceb877 100644 > --- a/arch/arm/boot/dts/exynos4412-p4note.dtsi > +++ b/arch/arm/boot/dts/exynos4412-p4note.dtsi > @@ -115,6 +115,17 @@ wlan_pwrseq: sdhci3-pwrseq { > clock-names = "ext_clock"; > }; > > + battery_cell: battery-cell { > + compatible = "simple-battery"; > + device-chemistry = "lithium-ion"; > + constant-charge-current-max-microamp = <2200000>; > + precharge-current-microamp = <250000>; > + charge-term-current-microamp = <250000>; > + constant-charge-voltage-max-microvolt = <4200000>; > + > + power-supplies = <&power_supply>; > + }; > + > i2c-gpio-1 { > compatible = "i2c-gpio"; > sda-gpios = <&gpy2 4 (GPIO_ACTIVE_HIGH | GPIO_OPEN_DRAIN)>; > @@ -193,7 +204,7 @@ i2c-gpio-4 { > #address-cells = <1>; > #size-cells = <0>; > > - charger@6 { > + power_supply: charger@6 { Squash this change with the previous patch. No need to add a line and immediately change it in next patch. > compatible = "summit,smb347"; > reg = <0x6>; > summit,enable-usb-charging; > @@ -201,6 +212,8 @@ charger@6 { > summit,fast-voltage-threshold-microvolt = <2600000>; > summit,chip-temperature-threshold-celsius = <130>; > summit,usb-current-limit-microamp = <1800000>; > + > + monitored-battery = <&battery_cell>; > }; > }; > Best regards, Krzysztof