From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: yanhong wang <yanhong.wang@starfivetech.com>,
linux-riscv@lists.infradead.org, netdev@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: "David S . Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Emil Renner Berthing <kernel@esmil.dk>,
Richard Cochran <richardcochran@gmail.com>,
Andrew Lunn <andrew@lunn.ch>,
Heiner Kallweit <hkallweit1@gmail.com>,
Peter Geis <pgwipeout@gmail.com>
Subject: Re: [PATCH v3 4/7] dt-bindings: net: Add support StarFive dwmac
Date: Wed, 18 Jan 2023 09:00:04 +0100 [thread overview]
Message-ID: <787bb142-1ade-bd48-1f6a-0da992add3d3@linaro.org> (raw)
In-Reply-To: <9c59e7b4-ba5f-365c-7d71-1ff2953f6672@starfivetech.com>
On 18/01/2023 02:45, yanhong wang wrote:
>
>
> On 2023/1/6 20:45, Krzysztof Kozlowski wrote:
>> On 06/01/2023 03:59, Yanhong Wang wrote:
>>> Add documentation to describe StarFive dwmac driver(GMAC).
>>>
>>> Signed-off-by: Yanhong Wang <yanhong.wang@starfivetech.com>
>>> ---
>>> .../devicetree/bindings/net/snps,dwmac.yaml | 1 +
>>> .../bindings/net/starfive,jh7110-dwmac.yaml | 113 ++++++++++++++++++
>>> MAINTAINERS | 5 +
>>
>> Order the patches correctly. Why this binding patch is split from previous?
>>
>
> The previous binding patch was considered to be compatible with JH7100, but after discussion,
> it is not compatible with JH7100 for the time being, so the name of binding has been modified
> in this patch.
I am not asking about name, but why this was split from the patch using
the compatible in the first time. This does not make any sense. Please
squash.
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-01-18 8:46 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-06 2:59 [PATCH v3 0/7] Add Ethernet driver for StarFive JH7110 SoC Yanhong Wang
2023-01-06 2:59 ` [PATCH v3 1/7] dt-bindings: net: snps,dwmac: Add dwmac-5.20 version Yanhong Wang
2023-01-06 12:37 ` Krzysztof Kozlowski
2023-01-06 2:59 ` [PATCH v3 2/7] dt-bindings: net: snps,dwmac: Update the maxitems number of resets and reset-names Yanhong Wang
2023-01-06 12:38 ` Krzysztof Kozlowski
2023-01-06 12:44 ` Krzysztof Kozlowski
2023-01-17 6:52 ` yanhong wang
2023-01-17 7:46 ` Krzysztof Kozlowski
2023-01-17 8:14 ` yanhong wang
2023-01-17 8:43 ` Krzysztof Kozlowski
2023-01-06 2:59 ` [PATCH v3 3/7] net: stmmac: platform: Add snps,dwmac-5.20 IP compatible string Yanhong Wang
2023-01-06 2:59 ` [PATCH v3 4/7] dt-bindings: net: Add support StarFive dwmac Yanhong Wang
2023-01-06 12:45 ` Krzysztof Kozlowski
2023-01-18 1:45 ` yanhong wang
2023-01-18 8:00 ` Krzysztof Kozlowski [this message]
2023-01-06 2:59 ` [PATCH v3 5/7] net: stmmac: Add glue layer for StarFive JH7110 SoCs Yanhong Wang
2023-01-08 11:11 ` Arun.Ramadoss
2023-01-09 1:13 ` yanhong wang
2023-01-06 3:00 ` [PATCH v3 6/7] riscv: dts: starfive: jh7110: Add ethernet device node Yanhong Wang
2023-01-06 3:00 ` [PATCH v3 7/7] riscv: dts: starfive: visionfive-v2: Enable gmac device tree node Yanhong Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=787bb142-1ade-bd48-1f6a-0da992add3d3@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=kernel@esmil.dk \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pgwipeout@gmail.com \
--cc=richardcochran@gmail.com \
--cc=robh+dt@kernel.org \
--cc=yanhong.wang@starfivetech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®