From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7B9FE201278 for ; Fri, 12 Jun 2026 07:52:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781250773; cv=none; b=PZlU7o9+BODSS7llVOInnA77Kh2liH4nIMfGl9mMW5JQZ9LoooXArPyiOeYnSpQ9/Y+JKoXvBA3LyN6rb5tmo0aWwAtR1tKdeWrr3FbI4W8r+OeveEm3WQFv3IZGkqarS8ROwgn4/NCLZ9FbvMprklt5+4nvb7oUAud9zvLmSN8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781250773; c=relaxed/simple; bh=faC12sv3c6kFcjuY77PQydFLEz1zEBfxyaEYpaOekkg=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Utl5xg38ieeMmAwr+/4lTydhw83xmodZJE/vS3daFfsVhT2KrhFQ7qKvkZX7axrv3/ZcEqDuKRJvYUkQ0vLZwsl5lB0mncoYQh4bywvmtxRMsNnsCKHquMjb2aRJ4TwbRirHC2Y+19o3L6XH4ePAadYNrod5nYOdxXGwt5w3t2I= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=N1hhYGfN; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=NpA2uVLO; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="N1hhYGfN"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="NpA2uVLO" Received: from pps.filterd (m0279867.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 65C39LlR2475796 for ; Fri, 12 Jun 2026 07:52:51 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= a49osnQfcj9w4HVmREpyuKU5kKi7D4S5O5AvEnVyiYc=; b=N1hhYGfN087nnCv2 g6jnyIm89Onb8pnui3FDoJwzyXV8i1yUTW2A+TIpu/JqbZzJr2Y2N4STUktdt7YB BcubpqAvkKHe1LeZLegVNM3iP8Maiwk4zLRQMQSlvX8S3OXfv5nkY9Govh16drzh BJwN16xnLKG7LkFDp0u+NTI3eiRhLIhYBXNJDCQ2aXJYncx+Vj48bS/XWBx9TPwR uwSSRiGo2JJ0+goixJIPCza7uTtBptCmygBk9NdhPB+qXt2pjgmHC/GZT4wQQ1Ue 0JrX8Fk1LEFHfu0VqT4/WAh8j1jHao9u6cecBE7lEeRLCZ1s6MK7qVvKzGRZR+ro 0x6PJA== Received: from mail-pf1-f199.google.com (mail-pf1-f199.google.com [209.85.210.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4er2r5t4w8-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 12 Jun 2026 07:52:50 +0000 (GMT) Received: by mail-pf1-f199.google.com with SMTP id d2e1a72fcca58-8423970cb30so560684b3a.2 for ; Fri, 12 Jun 2026 00:52:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1781250770; x=1781855570; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=a49osnQfcj9w4HVmREpyuKU5kKi7D4S5O5AvEnVyiYc=; b=NpA2uVLOmkAO/3nrBkyRly2jCsx9nObLiZkFjMAUUZjBHY7InlI63lzUDGJA9he/l2 W4QCnfXpjUDqsnrRV9UerlyeqsVTMp3Vo4RAYkIG7kmruyq9dczItYVCwQsy1WWUzIMZ uWjEmJGK0dlcoAw+lfNEotXLU8gZr8DnNWIJC9L1uNAMctw+a+xXd7h7lTJtnuFvq/SN QMKKZMq0GLJC/7MzjwOmGnlt0ZNonB4Ubo08n9jEH05hHhW/SLH1eodHXmxcweKIrStU AO4W7rAVZdZbSy7JcKMYgbMB3G4mNj87AsYzbJS2Iy4lbLVGUaXB1Mb0yWueNikGBHro ZvvQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781250770; x=1781855570; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=a49osnQfcj9w4HVmREpyuKU5kKi7D4S5O5AvEnVyiYc=; b=qIn/ssWGA3vEElP14ppQZbDl5xuvAKZauEqPpVk82zGO26+yCcsLzjKmrTugOQzNor xegbZoJjWlaxQznyP6gFI3HSgXXaTHjTmFO1LSGOa5vTFG0afW7VVorKSdv6ldxsQevc V3ShIdz3YRZuaX4zmcww83f4Q6ll6UagQXGyRHYAEmD6kC7ElwnAy8FjJ+6JiYmm/LH3 9OJ1LrxY3kkeLzK3An/d9GcD2i+LauLkeeTYeUKV9T1yGxp9l56jbsb5gJPu5TXDAQJj e5KspFf3Oqzy0T5JGluRwjEoX0q3IPYIWRw5Zf3jq1lyfQoLelfrsYsnplFD57XW45Wh PUbg== X-Forwarded-Encrypted: i=1; AFNElJ+j+p8tFZtfOOYeBgrWGD4Zfb3B+ZIObUftfOgi4IJdQmA2fSPezY3R8DEOCxr/clMTBUpPo8++4sjEM8g=@vger.kernel.org X-Gm-Message-State: AOJu0YzMKUuyQbZl4VYQPKCCc8eOttE3mJ6JLfLryS108OTpytkARbRz tvfoQoltP2b1vEaViPrcp8iQhBPMQKqnNEVAVfTFaNY+ACzEV2AMA31gdkRehzjZVzLMyML1ycS j+t+GlRl8ibvp7o1mW/hDSbZkX0wI30TB6524WoVSuuUaOb34l1kn4RdvyvC9cS5eGu4= X-Gm-Gg: Acq92OH23w+tmRJaH4i5BlR/XY1cahC9zAArPHNV12W2f4+f6Wk5Jb4JmKUNLGp3g4R 7AZWW/a51/cA2/jGOr0z247yysq2mKSHC1C3z26QoTSzFGd67TjAv6Pn1QEP1/mpZe8pcBtKjQd muijVUdxoXg285vj2Lc4MHi4ASnRcnR4S33Z9LkskjF8m7iV8IXjNkdj/Zy/RWeOERWqlv2l2Os XYtsBMZ6cqlMOIr1MYgS3rQ8Q8PY1R+j5SnRYg+6wRlKDaCPqAjfTafSRGX0hFEeNrJCoFaiNSr TTOHYTJYUoGYUUmlpTuO77X30U6Drb4eISj4I/FIfBn2Ujt29yxuV/L2Mc48FdBRjyBLevtubvR fyVVKrEO1fUHHo3erxyMUYXg2K8UlHWDWsJOtFDKYurezB/Wjg3AxuV2gX3xxwgA= X-Received: by 2002:a05:6a00:35cc:b0:842:5634:3c1d with SMTP id d2e1a72fcca58-8434cdac1dbmr2028644b3a.19.1781250770192; Fri, 12 Jun 2026 00:52:50 -0700 (PDT) X-Received: by 2002:a05:6a00:35cc:b0:842:5634:3c1d with SMTP id d2e1a72fcca58-8434cdac1dbmr2028614b3a.19.1781250769717; Fri, 12 Jun 2026 00:52:49 -0700 (PDT) Received: from [192.168.1.8] ([122.164.81.0]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-8434ac9df57sm1393519b3a.7.2026.06.12.00.52.45 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 12 Jun 2026 00:52:49 -0700 (PDT) Message-ID: <787c6ee5-e7e0-4884-9efc-b7b4692f1877@oss.qualcomm.com> Date: Fri, 12 Jun 2026 13:22:44 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/2] phy: qcom: qmp-pcie: Add IPQ9650 PCIe PHY support To: Dmitry Baryshkov Cc: Vinod Koul , Neil Armstrong , Rob Herring , Krzysztof Kozlowski , Conor Dooley , linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260602-ipq9650_pcie_phy-v1-0-d8c32a36dbd9@oss.qualcomm.com> <20260602-ipq9650_pcie_phy-v1-2-d8c32a36dbd9@oss.qualcomm.com> <56zkq7bwrt5smmmum6jckzrekkkqrych2gntx3obnrmamwumtv@espahwe6pc3v> <7def2ccd-0319-4f85-8275-73fd254d887d@oss.qualcomm.com> <602e893c-d346-486d-86b3-50d0f01990bf@oss.qualcomm.com> Content-Language: en-US From: Kathiravan Thirumoorthy In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Proofpoint-ORIG-GUID: yzD63ckqwx0RJJ6RoFcWFkDrWOaKxFDk X-Proofpoint-GUID: yzD63ckqwx0RJJ6RoFcWFkDrWOaKxFDk X-Proofpoint-Spam-Info: AW1haW4tMjYwNjEyMDA2OSBTYWx0ZWRfX+k2WN/seUKzX evRWpLQmKWQYGv7+RfsMKX0bt7E/E3+1SKz4KHYYz8jPW97pbrk9BB3OasE0ic4sqc4waI6kq9k X3Ed45HjWQBZQDp8bzAmqZ2n482HF8U= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjEyMDA2OSBTYWx0ZWRfX9wrLR+u1Fa0z hry3RM5YfWvu9lDve3m9qnVzvFbkb84Z2QFgLA7Flpko1qEiW7pICmwUaCZ0dCsjvvKU1YjcDoZ EgOROMqQfQiTMfeGG45wPw7qt/pDFzoAcLoxEvuh+JH/uNefbayqLt6XiFXb+PPlRFI3nNx2oe5 pqexAWnDD//VJhJmxbM9xUYxOYD1easD3qVLlmn4o3jZJ+0jn4ihs+EDoctIhKQ1WT9sCzpXOpI RHa0n9L5I9X54tTzNkCgijSpA9R30Jewm5HXb/fzNGLsH6ftCgmocEl3gUZewG0m1oG8TSsSoAH 6QGGf1Va4Pap6hKbVCLXKCOnKAqcjYkPCQ8FVvbKR/jd4D6ne0dsGrH7wX7aTh8uO1seVFcApNQ 1HUP+x3e3qidgdruvuxe9ntsJzYsdNp62JHBitb8J2XY8u1uPl2qhPnyzU0EU8rQ6LG1AphyJFy TQxWguCb33e/qYg9Xdg== X-Authority-Analysis: v=2.4 cv=M6p97Sws c=1 sm=1 tr=0 ts=6a2bbad2 cx=c_pps a=WW5sKcV1LcKqjgzy2JUPuA==:117 a=DVNErGSwdtF8OHn2hLoakQ==:17 a=IkcTkHD0fZMA:10 a=FelO9ux0wxsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=eoimf2acIAo5FJnRuUoq:22 a=EUspDBNiAAAA:8 a=xnaJPCCZ8mv5B4GoDGgA:9 a=QEXdDO2ut3YA:10 a=OpyuDcXvxspvyRM73sMx:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-12_01,2026-06-11_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 lowpriorityscore=0 adultscore=0 suspectscore=0 bulkscore=0 phishscore=0 clxscore=1015 malwarescore=0 impostorscore=0 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606040000 definitions=main-2606120069 On 6/12/2026 12:54 PM, Dmitry Baryshkov wrote: > On Fri, Jun 12, 2026 at 12:13:04PM +0530, Kathiravan Thirumoorthy wrote: >> On 6/12/2026 11:44 AM, Dmitry Baryshkov wrote: >>> On Fri, Jun 12, 2026 at 08:22:02AM +0530, Kathiravan Thirumoorthy wrote: >>>> On 6/12/2026 1:52 AM, Dmitry Baryshkov wrote: >>>>> On Tue, Jun 09, 2026 at 03:46:56PM +0530, Kathiravan Thirumoorthy wrote: >>>>>> On 6/8/2026 12:26 PM, Dmitry Baryshkov wrote: >>>>>>> On Tue, Jun 02, 2026 at 02:40:18PM +0530, Kathiravan Thirumoorthy wrote: >>>>>>>> The IPQ9650 platform has three Gen3 2-lane PCIe controllers and two Gen3 >>>>>>>> 1-lane PCIe controllers. The PHY instances also require the on-chip refgen >>>>>>>> supply. >>>>>>>> >>>>>>>> Add the IPQ9650 Gen3 x1 and x2 QMP PCIe PHY configurations, including the >>>>>>>> refgen regulator supply. >>>>>>>> >>>>>>>> Signed-off-by: Kathiravan Thirumoorthy >>>>>>>> --- >>>>>>>> drivers/phy/qualcomm/phy-qcom-qmp-pcie.c | 220 +++++++++++++++++++++++++++++++ >>>>>>>> 1 file changed, 220 insertions(+) >>>>>>>> >>>>>>>> @@ -3378,6 +3524,10 @@ static const char * const qmp_phy_vreg_l[] = { >>>>>>>> "vdda-phy", "vdda-pll", >>>>>>>> }; >>>>>>>> +static const char * const ipq9650_qmp_phy_vreg_l[] = { >>>>>>>> + "refgen", >>>>>>>> +}; >>>>>>> Now vdda-phy / vdda-pll supplies? >>>>>> Cross checked with HW team again. Along with refgen, there is a on-chip LDO >>>>>> which supplies fixed voltage to the PHYs. It is enabled upon system power on >>>>>> and no SW intervention is required. >>>>> What is it being powered by? MX? CX? >>>> It is driven by CX. >>> I assume that there is no CX collapse on IPQ9650? Is CX not scaling on >>> this chip. Please provide some details on the commit message. >> That's right. No CX collapse on IPQ9650. Let me rewrite the commit message >> as below. Hope its okay. >> >> -- >> >> Add support for the IPQ9650 platform, which includes three Gen3 x2 PCIe >> controllers and two Gen3 x1 PCIe controllers. The PHY instances require the >> on-chip refgen supply. >> >> Add the IPQ9650 Gen3 x1 and x2 QMP PCIe PHY configurations along with the >> refgen regulator supply. Note that an on-chip LDO, driven by the SoC CX, >> supplies the PHY voltages without requiring software control. Note that CX >> power collapse is not supported on IPQ9650. > ...neither CX power collapse nor rail scaling... > > LGTM. Thanks much. Have sent V2. Please have a look. > >