From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, UNPARSEABLE_RELAY,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7514EC432C3 for ; Tue, 3 Dec 2019 01:05:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4765920715 for ; Tue, 3 Dec 2019 01:05:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726190AbfLCBFJ (ORCPT ); Mon, 2 Dec 2019 20:05:09 -0500 Received: from out30-54.freemail.mail.aliyun.com ([115.124.30.54]:43094 "EHLO out30-54.freemail.mail.aliyun.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725853AbfLCBFJ (ORCPT ); Mon, 2 Dec 2019 20:05:09 -0500 X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R771e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=e01e07486;MF=joseph.qi@linux.alibaba.com;NM=1;PH=DS;RN=7;SR=0;TI=SMTPD_---0TjlyP7a_1575335105; Received: from JosephdeMacBook-Pro.local(mailfrom:joseph.qi@linux.alibaba.com fp:SMTPD_---0TjlyP7a_1575335105) by smtp.aliyun-inc.com(127.0.0.1); Tue, 03 Dec 2019 09:05:05 +0800 Subject: Re: [PATCH] ocfs2/dlm: remove redundant assignment to ret To: Colin King , Mark Fasheh , Joel Becker , ocfs2-devel@oss.oracle.com, Andrew Morton Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org References: <20191202164833.62865-1-colin.king@canonical.com> From: Joseph Qi Message-ID: <787d96be-b750-9fa2-19c6-30c1af86cc3c@linux.alibaba.com> Date: Tue, 3 Dec 2019 09:05:05 +0800 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.11; rv:60.0) Gecko/20100101 Thunderbird/60.9.1 MIME-Version: 1.0 In-Reply-To: <20191202164833.62865-1-colin.king@canonical.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 19/12/3 00:48, Colin King wrote: > From: Colin Ian King > > The variable ret is being initialized with a value that is never > read and it is being updated later with a new value. The initialization > is redundant and can be removed. > > Addresses-Coverity: ("Unused value") > Signed-off-by: Colin Ian King Reviewed-by: Joseph Qi > --- > fs/ocfs2/dlm/dlmrecovery.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/fs/ocfs2/dlm/dlmrecovery.c b/fs/ocfs2/dlm/dlmrecovery.c > index 064ce5bbc3f6..2734867473a6 100644 > --- a/fs/ocfs2/dlm/dlmrecovery.c > +++ b/fs/ocfs2/dlm/dlmrecovery.c > @@ -1668,7 +1668,7 @@ static int dlm_lockres_master_requery(struct dlm_ctxt *dlm, > int dlm_do_master_requery(struct dlm_ctxt *dlm, struct dlm_lock_resource *res, > u8 nodenum, u8 *real_master) > { > - int ret = -EINVAL; > + int ret; > struct dlm_master_requery req; > int status = DLM_LOCK_RES_OWNER_UNKNOWN; > >