mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Gustavo A. R. Silva" <gustavo@embeddedor.com>
To: Takashi Iwai <tiwai@suse.de>
Cc: Jaroslav Kysela <perex@perex.cz>,
	alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ALSA: intel8x0: Fix fall-through annotations
Date: Wed, 3 Oct 2018 20:08:31 +0200	[thread overview]
Message-ID: <787e9aeb-34e0-3075-d816-7963cca61020@embeddedor.com> (raw)
In-Reply-To: <s5hbm8boven.wl-tiwai@suse.de>



On 10/3/18 6:19 PM, Takashi Iwai wrote:
> On Wed, 03 Oct 2018 18:08:07 +0200,
> Takashi Iwai wrote:
>>
>> On Wed, 03 Oct 2018 12:38:36 +0200,
>>  Gustavo A. R. Silva  wrote:
>>>
>>> Replace "fallthru" with a proper "fall through" annotation.
>>>
>>> This fix is part of the ongoing efforts to enabling
>>> -Wimplicit-fallthrough
>>>
>>> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
>>
>> Thanks, applied.
> 
> BTW, does "fallthru" really cause a warning?  I thought it's also
> accepted as well as "fall-through".  At least, my gcc-8 doesn't give a
> warning with "fallthru".
> 

You are correct. It does not trigger a warning.

There are about 50 similar instances in the whole codebase. And, as they
are just a few, what I'm trying to do is to replace them with the most
commonly used form: "fall through"

Thanks
--
Gustavo

  reply	other threads:[~2018-10-03 18:13 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-03 10:38 Gustavo A. R. Silva
2018-10-03 16:08 ` Takashi Iwai
2018-10-03 16:19   ` Takashi Iwai
2018-10-03 18:08     ` Gustavo A. R. Silva [this message]
2018-10-03 18:34       ` Takashi Iwai
2018-10-03 18:40         ` Gustavo A. R. Silva

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=787e9aeb-34e0-3075-d816-7963cca61020@embeddedor.com \
    --to=gustavo@embeddedor.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=perex@perex.cz \
    --cc=tiwai@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®