From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from lelvem-ot02.ext.ti.com (lelvem-ot02.ext.ti.com [198.47.23.235]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2305226A089; Tue, 18 Feb 2025 17:51:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.47.23.235 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739901118; cv=none; b=NcM6ahwipaPGkrgVI2LX5NthUxHlilcdQwo/q2XZDD9hAhNmrwFyQGLrpGLg8fMkr9Lu+47zc5H42qXLOcZsvRLUxAjzbU0ZB08/O5x40SOd3rmO3xtcUSEJzZYgjLhfZ/Dzn+jXS73HiO/D/HKpRkwD2/FLftupWfB1ZPLDos8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739901118; c=relaxed/simple; bh=kem0UMxxiJfZRDKqlYL4LpFrCW1ZiWjp0diJ1183J70=; h=Message-ID:Date:MIME-Version:Subject:To:CC:References:From: In-Reply-To:Content-Type; b=iJa/G42Yeo8UGlaT8x/yVv4BafBcw2H4JmFS5gTEd+j+mkgs1jIqHSt6CZEyGEtppobf53EZnRkPDoHAHy684MP6UuNqESpSli4LP2g1OvKZ6ppcp1QiA0qudxV5mdLi4Qx+SLG42/hXG+Jol0+eP9mfKuO0BdmfpQOfJ6Ewlaw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com; spf=pass smtp.mailfrom=ti.com; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b=cx1GEg9M; arc=none smtp.client-ip=198.47.23.235 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ti.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b="cx1GEg9M" Received: from fllv0034.itg.ti.com ([10.64.40.246]) by lelvem-ot02.ext.ti.com (8.15.2/8.15.2) with ESMTPS id 51IHpmv0051957 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 18 Feb 2025 11:51:49 -0600 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1739901109; bh=F3jGz9dTOI3zjTp+FWv3GOetS4aavIzrIh1eri2pQa4=; h=Date:Subject:To:CC:References:From:In-Reply-To; b=cx1GEg9MnkBeyrIVntzsS73hLqty3ydz9iZdHuzoq16cpWcIuxF8aPcM4UFgYSsFJ dGjDgynGhNwMyHfsQwB4IdLQ6FlkiRx3Mz8FLeZXPNtA+5tnbAS9j0Wsao5X+1IaqK 23RV3ohSPkY6EJ4yx5PrG9dFcSrI3LlYi3R44C9E= Received: from DFLE107.ent.ti.com (dfle107.ent.ti.com [10.64.6.28]) by fllv0034.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 51IHpmsY105306 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Tue, 18 Feb 2025 11:51:48 -0600 Received: from DFLE111.ent.ti.com (10.64.6.32) by DFLE107.ent.ti.com (10.64.6.28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23; Tue, 18 Feb 2025 11:51:48 -0600 Received: from lelvsmtp6.itg.ti.com (10.180.75.249) by DFLE111.ent.ti.com (10.64.6.32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23 via Frontend Transport; Tue, 18 Feb 2025 11:51:48 -0600 Received: from [128.247.81.105] (judy-hp.dhcp.ti.com [128.247.81.105]) by lelvsmtp6.itg.ti.com (8.15.2/8.15.2) with ESMTP id 51IHpmBe092458; Tue, 18 Feb 2025 11:51:48 -0600 Message-ID: <787f9d24-25bc-4171-bd8a-88fe9cef694d@ti.com> Date: Tue, 18 Feb 2025 11:51:48 -0600 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 06/10] arm64: dts: ti: k3-am62p5-sk: Enable IPC with remote processors To: Andrew Davis , Nishanth Menon , Vignesh Raghavendra CC: Rob Herring , Krzysztof Kozlowski , Conor Dooley , , , , Hari Nagalla References: <20250210221530.1234009-1-jm@ti.com> <20250210221530.1234009-7-jm@ti.com> <04e77daf-e775-44fa-82bf-8b6ebf73bcef@ti.com> Content-Language: en-US From: Judith Mendez In-Reply-To: <04e77daf-e775-44fa-82bf-8b6ebf73bcef@ti.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-C2ProcessedOrg: 333ef613-75bf-4e12-a4b1-8e3623f5dcea Hi Andrew, On 2/18/25 10:38 AM, Andrew Davis wrote: > On 2/10/25 4:15 PM, Judith Mendez wrote: >> From: Devarsh Thakkar >> >> For each remote proc, reserve memory for IPC and bind the mailbox >> assignments. Two memory regions are reserved for each remote processor. >> The first region of 1MB of memory is used for Vring shared buffers >> and the second region is used as external memory to the remote processor >> for the resource table and for tracebuffer allocations. >> >> Signed-off-by: Devarsh Thakkar >> Signed-off-by: Hari Nagalla >> Signed-off-by: Judith Mendez >> --- >> Changes since v4: >> - Drop SRAM node for am62px MCU R5fSS0 core0 >> --- >>   arch/arm64/boot/dts/ti/k3-am62p5-sk.dts | 50 ++++++++++++++++++++++--- >>   1 file changed, 44 insertions(+), 6 deletions(-) >> >> diff --git a/arch/arm64/boot/dts/ti/k3-am62p5-sk.dts >> b/arch/arm64/boot/dts/ti/k3-am62p5-sk.dts >> index ad71d2f27f538..9609727d042d3 100644 >> --- a/arch/arm64/boot/dts/ti/k3-am62p5-sk.dts >> +++ b/arch/arm64/boot/dts/ti/k3-am62p5-sk.dts >> @@ -48,6 +48,30 @@ reserved-memory { >>           #size-cells = <2>; >>           ranges; >> +        mcu_r5fss0_core0_dma_memory_region: >> mcu-r5fss-dma-memory-region@9b800000 { >> +            compatible = "shared-dma-pool"; >> +            reg = <0x00 0x9b800000 0x00 0x100000>; >> +            no-map; >> +        }; >> + >> +        mcu_r5fss0_core0_memory_region: >> mcu-r5fss-memory-region@9b900000 { >> +            compatible = "shared-dma-pool"; >> +            reg = <0x00 0x9b900000 0x00 0xf00000>; >> +            no-map; >> +        }; >> + >> +        wkup_r5fss0_core0_dma_memory_region: r5f-dma-memory@9c800000 { >> +            compatible = "shared-dma-pool"; >> +            reg = <0x00 0x9c800000 0x00 0x100000>; >> +            no-map; >> +        }; >> + >> +        wkup_r5fss0_core0_memory_region: r5f-memory@9c900000 { >> +            compatible = "shared-dma-pool"; >> +            reg = <0x00 0x9c900000 0x00 0x1e00000>; > > 0x1e00000? > > Yes I know you didn't add this and are just coping it from below, but it > is still an issue. I see the same problem for the next patch, the R5F > memory > size is 0xc00000?? > > Every remote core gets 15MB (0xf00000), this has been true for all K3, and > all cores, DSP, R5F, M4, etc.. You even do it correct for the MCU R5F > above, > but the WKUP R5F on AM62P and AM62 are just randomly given 30M and 12MB? Not sure why FW requires 30MB here, I have reached out to FW team to investigate this, will respond back here soon. ~ Judith > > Andrew > >> +            no-map; >> +        }; >> + >>           secure_tfa_ddr: tfa@9e780000 { >>               reg = <0x00 0x9e780000 0x00 0x80000>; >>               no-map; >> @@ -57,12 +81,6 @@ secure_ddr: optee@9e800000 { >>               reg = <0x00 0x9e800000 0x00 0x01800000>; /* for OP-TEE */ >>               no-map; >>           }; >> - >> -        wkup_r5fss0_core0_memory_region: r5f-dma-memory@9c900000 { >> -            compatible = "shared-dma-pool"; >> -            reg = <0x00 0x9c900000 0x00 0x01e00000>; >> -            no-map; >> -        }; >>       }; >>       vmain_pd: regulator-0 { >> @@ -638,6 +656,26 @@ mbox_mcu_r5_0: mbox-mcu-r5-0 { >>       }; >>   }; >> +&wkup_r5fss0 { >> +    status = "okay"; >> +}; >> + >> +&wkup_r5fss0_core0 { >> +    mboxes = <&mailbox0_cluster0 &mbox_r5_0>; >> +    memory-region = <&wkup_r5fss0_core0_dma_memory_region>, >> +            <&wkup_r5fss0_core0_memory_region>; >> +}; >> + >> +&mcu_r5fss0 { >> +    status = "okay"; >> +}; >> + >> +&mcu_r5fss0_core0 { >> +    mboxes = <&mailbox0_cluster1 &mbox_mcu_r5_0>; >> +    memory-region = <&mcu_r5fss0_core0_dma_memory_region>, >> +            <&mcu_r5fss0_core0_memory_region>; >> +}; >> + >>   &main_uart0 { >>       pinctrl-names = "default"; >>       pinctrl-0 = <&main_uart0_pins_default>;