From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D1E203859FC for ; Mon, 20 Apr 2026 08:42:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776674534; cv=none; b=dCR2JkUYemJVLYR5k2G7qyng1MmgXahD4brBbVZ2JSInyZjIECW1ANJ79BFchbid5I1qhgh18eBIF0TvHtQV6PFZYHGX0gk1pNXRaA7aggySVOZy2cldcLpXA671Fg2PQ1WafQp+zOIryKg6NkPpB0B99PobK2o9MPF347zdFFg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776674534; c=relaxed/simple; bh=5fRZJ8YA8KbJQU7yUpodTShTa4RfulvrCn7zbvhtIoc=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=lPFo2RKXQeS41WoXJxRHTNR5V5lcvj2v8ch3odVcQxgwx5n4eSB8szk4CQc+u6ZSOH+PRRcEk8TanxyW3FaS4xrYFeUcBAQw39fiCnc1Uf4CiSBjeghswB1ANJVhaftEK91GsgJpY0TNLC5z6kLBEfwvn2EWVOgQDL9av+xo81U= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=ZAZghM8y; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=aGn0g5/T; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="ZAZghM8y"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="aGn0g5/T" Received: from pps.filterd (m0279866.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 63K7pxiO898295 for ; Mon, 20 Apr 2026 08:42:12 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= x8iMjMN4YKAgD5WlMa8L6g5mmJh1v/Zzj0qvsdzGArE=; b=ZAZghM8y16lfL9Zv Nj1MZgZ26Wbrs32PhR0n7daWHOuKCY6AZQhsoJH7kaC/qFLfybXl6uJ1aKiFKKA3 zqyhNKBb4g+llkwSaK4cOKgP/aviGLDVS1aKBtTQgZGrPa63rLWV4idrOnAlrDwq R+BjlRv/w3JLrkBGXEV+BqaIxfKd6vFogdu0oPDqWnalwzkFDwbsyynyLYvG6F4o Y+fxddAirTHgrYIG7GovU6HuZWoym0M9fZ1s9dyLM8hAy7/O5FEROvOJhw5q9sAw zFWBgL1u0e7BmqmkgDLf2f4ToY5q+ImqwxtOgNVlBARz9TqGBFHcdodXUpQV8SYx zzAHhw== Received: from mail-pj1-f70.google.com (mail-pj1-f70.google.com [209.85.216.70]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4dm388n0ae-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 20 Apr 2026 08:42:11 +0000 (GMT) Received: by mail-pj1-f70.google.com with SMTP id 98e67ed59e1d1-35842aa350fso5768678a91.0 for ; Mon, 20 Apr 2026 01:42:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1776674531; x=1777279331; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=x8iMjMN4YKAgD5WlMa8L6g5mmJh1v/Zzj0qvsdzGArE=; b=aGn0g5/Tvh1enK1M66saNo3k0Oi3I9YkiHb9XVpe5RmQEGraXwBPRfKKqxM2GFZKKy SF9o2j7vxWpKKdIni3a0JNQ5r58jSiuMIHZNowwNB3oMGXJfoNYMLhabhAeh3vPo6p3j 6J6epL4JfeXhCeKuB6ZHzVRn3JBbDlCkF6xrdxyyv6+hEUOPk8k5YhjKfFjyoYmuU4mh 18d9VgVMtHkMTVglsARRdqwVLCOU0nZKA+coIgdGUWQP5yPjafdx8qYHUZLNBFFglZW9 7QOFVb4tWsUXV+hUDpGWpu5xEwaYECZQjO9nKlqEo3rFK2MFIjnJ9Dh42lMPiejONTFH Ze2A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776674531; x=1777279331; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=x8iMjMN4YKAgD5WlMa8L6g5mmJh1v/Zzj0qvsdzGArE=; b=BZz+CAHkPAZWkjHoTVv+7v8PwJW0HvQ3OWBrUDv8wXqdwK35gmgaiK395P8Ip7tUN9 nuPFRqAn/YyuAO6NQ6FXls4cuQCi6yckHFDiBp6ySd4MI4dwVSAppEQJ8JzAhKVVAQI1 lFK8FiQYWbFi4Xc7DlfP3SCRouyWOCOzeDZ388JxpEWoxbX3OTyKpK+6hGSMiuGLRCzC E2f6b+QjBge187zKjXdUsM4L2n0X07ECHyJ2Qd1qFqlVtCZsy+DObTDN7hFBbnDEaJwZ jOZ3h1tUgCzd3CmxLynmK3M0aCZurbRpX0ZnWfdY0nAot7QhBOQ0eFefkINAScLwW1f4 Y9Ew== X-Forwarded-Encrypted: i=1; AFNElJ+4PvTRhfGlmQbOO6GDHPBvZRKiwx8P/tACqopJlbsOVPihXUosjXtadytaVR4zmOEn/jMBxp8HSVIWkYc=@vger.kernel.org X-Gm-Message-State: AOJu0YyT3a7f5MkcPJVXdVBEoBAGtebuk7xFsT0dsppueF8COZQN538z oq/UHIux78DNFOoC+OMSthavRz8JY3DLwMqwAjKvquZPPR9AwaxESFJOaP06ESMjSvTel9nVwad mZdyxturtGakED7q8FOEn9HA8m30y2Kh+Cz1ZV4QcveGu1jd1+qbXhi9lyF7ygaEgTsbiAXrT/o s= X-Gm-Gg: AeBDieuHokXC2jKtetaNFSEOlcpgROWPFcSUFRfh6H9B5xqzqpU29ioC/fLzK/7R01p goerP6O//uME9J6BGXkMTOwHuEoAk4CrilV3NjelooiVj4lvqVdkDCotM5s4L3hFYAfYJ0ubTmw ELeN7aqDRsOSYBF9EFN/zOH0m2XgmYws8+KurQYlts6x4QXT8YWZE5xgnjKfSTZL/h9G7BT9qzJ nD796WHLoPAtcPWYpieDKaQlHEifr762ixlpJULZ9rYCxHQ3jebNmr983cFLQYrhxKNHRH21Zta V1b6jh0H/rVxoR/1FSNvJ86lwvv88aQC+TZyKYX0fePzMeELoOAcXF/JZb8cVEFeX2JBcP7MahQ P666ZfDkG2cIz3hcQWIUUeSFYO7rQ4gwm012anJN6BMblL0KZcGYmKXYK28Gh X-Received: by 2002:a17:90b:3cc3:b0:35f:b6d3:da7a with SMTP id 98e67ed59e1d1-36140469f66mr13175741a91.15.1776674530445; Mon, 20 Apr 2026 01:42:10 -0700 (PDT) X-Received: by 2002:a17:90b:3cc3:b0:35f:b6d3:da7a with SMTP id 98e67ed59e1d1-36140469f66mr13175705a91.15.1776674529753; Mon, 20 Apr 2026 01:42:09 -0700 (PDT) Received: from [10.219.49.106] ([202.46.23.19]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2b5fab30f29sm94300945ad.68.2026.04.20.01.42.07 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 20 Apr 2026 01:42:09 -0700 (PDT) Message-ID: <7881bf0a-27f4-4a54-af14-9b2a5b7bb295@oss.qualcomm.com> Date: Mon, 20 Apr 2026 14:12:05 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 2/3] pinctrl: qcom: lpass-lpi: Fix GPIO register access helper return types To: Konrad Dybcio , Bjorn Andersson , Linus Walleij Cc: linux-arm-msm@vger.kernel.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, srinivas.kandagatla@oss.qualcomm.com References: <20260413122233.375945-1-ajay.nandam@oss.qualcomm.com> <20260413122233.375945-3-ajay.nandam@oss.qualcomm.com> Content-Language: en-US From: Ajay Kumar Nandam In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Authority-Analysis: v=2.4 cv=GthyPE1C c=1 sm=1 tr=0 ts=69e5e6e3 cx=c_pps a=0uOsjrqzRL749jD1oC5vDA==:117 a=j4ogTh8yFefVWWEFDRgCtg==:17 a=IkcTkHD0fZMA:10 a=A5OVakUREuEA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=YMgV9FUhrdKAYTUUvYB2:22 a=Qs0S--QKVP3T3cQB22MA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=zZCYzV9kfG8A:10 a=mQ_c8vxmzFEMiUWkPHU9:22 X-Proofpoint-GUID: oqE1iVlvNWLowzc9uszH0bGyW-WqjQVF X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNDIwMDA4MyBTYWx0ZWRfX4fWvpuKjeybB Qt8aYZzYSAS39vnVjxBth0ZC2cZjPQaf9xZsjNasZUOI+v9W++drbS1qS5gXZA1GYvCoQIf4OlW 9eUOcmHrgmefYNXB7kktzGd65hOTRznp+KP5JF+9WnhxZQTmOZYdreE8kgbVHEw6fmJa8UacJVw zRpIo0ZT9EbMF16jAyqyOo9oI3gp0RO4mQ2I14skzSVT+f8YkDtV101VRUMOHeTW0R5PIY3XujK ymRvXA1FlGur9C+t9Ud/LLJmoW/GwIRNvHMevYR3CelQbKTdS1whi4+rgbvwe+1Fe+LIWkJ5r4h T3SbuFnH8wUthfS8PWq6aNeBjcWbMb90QqFJTI1QNJrYnlO2lYlvtR8uDKYW7GMYHSaS3rclPcN CS/ey8TBmanHCjwsHEoHqLysDpmW5qiIrXUxff24u6cKWiezVPNvsVQpL3UJjiZ+QBxQOpRNGg2 xTAgXnnsoC4eTPVC2Wg== X-Proofpoint-ORIG-GUID: oqE1iVlvNWLowzc9uszH0bGyW-WqjQVF X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-04-20_01,2026-04-17_04,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 adultscore=0 phishscore=0 lowpriorityscore=0 clxscore=1015 priorityscore=1501 malwarescore=0 spamscore=0 bulkscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2604070000 definitions=main-2604200083 On 4/14/2026 2:09 PM, Konrad Dybcio wrote: > On 4/13/26 2:22 PM, Ajay Kumar Nandam wrote: >> The LPI GPIO register access helpers previously returned the value from >> ioread32(), even though their return type was int. This mixes data >> return with status and is inconsistent with common kernel helper >> conventions. >> >> Rework lpi_gpio_read() and lpi_gpio_write() to return an int status and >> use output parameters to pass register values. Update all callers to >> match the new helper interface. > > lpi_gpio_read/write() can never fail, let's just make _read() return > a u32 and _write() a void ACK, I’ll post v2 with this adjustment. > > Konrad