From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751751AbdKYOrM (ORCPT ); Sat, 25 Nov 2017 09:47:12 -0500 Received: from mail-wm0-f68.google.com ([74.125.82.68]:42403 "EHLO mail-wm0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751681AbdKYOrL (ORCPT ); Sat, 25 Nov 2017 09:47:11 -0500 X-Google-Smtp-Source: AGs4zMY8WSgIzuf41DaKW25k4FtRQ3JLD2Bfn5jeTY6kkv22NMAOVZPiCPVYGiZRyHMQ4rp3IfvLcA== Subject: Re: [PATCH] nvmem: core: Deduplicate bus_find_device() by name matching To: Lukas Wunner Cc: linux-kernel@vger.kernel.org References: <1ec777daa342333ed80ee8c5f79c58489f20a591.1511609232.git.lukas@wunner.de> From: Srinivas Kandagatla Message-ID: <788a42d3-243e-e22e-2958-444726ef2ad3@linaro.org> Date: Sat, 25 Nov 2017 14:47:07 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <1ec777daa342333ed80ee8c5f79c58489f20a591.1511609232.git.lukas@wunner.de> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Thanks for the patch, On 25/11/17 11:31, Lukas Wunner wrote: > No need to reinvent the wheel, we have bus_find_device_by_name(). > > Signed-off-by: Lukas Wunner > --- > drivers/nvmem/core.c | 7 +------ > 1 file changed, 1 insertion(+), 6 deletions(-) > It looks good for me, I will queue it up! > diff --git a/drivers/nvmem/core.c b/drivers/nvmem/core.c > index 5a5cefd12153..93084ab61e0f 100644 > --- a/drivers/nvmem/core.c > +++ b/drivers/nvmem/core.c > @@ -600,16 +600,11 @@ static void __nvmem_device_put(struct nvmem_device *nvmem) > mutex_unlock(&nvmem_mutex); > } > > -static int nvmem_match(struct device *dev, void *data) > -{ > - return !strcmp(dev_name(dev), data); > -} > - > static struct nvmem_device *nvmem_find(const char *name) > { > struct device *d; > > - d = bus_find_device(&nvmem_bus_type, NULL, (void *)name, nvmem_match); > + d = bus_find_device_by_name(&nvmem_bus_type, NULL, name); > > if (!d) > return NULL; >