From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C688C31D366 for ; Tue, 14 Jul 2026 05:21:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784006515; cv=none; b=dmo5W4fTwuZsmF7kADpPL0oJQVL+slWtYDiAscNN4HLvp88G/1Cgk9XWfRnHr1SXmZr7wUKjkMXfh/TwlSx08edhTqWG4kmlOuoSe8owITjYie6q1b290tusUZEyCF90pz621KAwa9t8Z9uyNr8jZERAB1cIZRk4WBiIPdTraEY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784006515; c=relaxed/simple; bh=TuAodXskmsk6PpOUP7bcreyJUVtepgakQ0Ia6qBO6yc=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=dy5hEyZSPisu+0905UpgWv00KaXlCt3AXunqm3UU3++AJb5vq5v3pD64BewKlsuT+z9p++4GWyNns3negq4p2utKtW+timP8bVfwPvienZdnYIsUVe2Y6QttoUOIk+Uot5T0J77o3fmCAb4Ge9eBF2ODU/aO3h5npt2lwdHiPd4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=Ga7ciTTX; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=FQVFj787; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="Ga7ciTTX"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="FQVFj787" Received: from pps.filterd (m0279866.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 66E37wll3276746 for ; Tue, 14 Jul 2026 05:21:51 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= A9GY5SmmKpXBp0S4UpoTVLYAhXq0hiNnfIA35k/Yeeo=; b=Ga7ciTTXlZHchP5y CXm0Hb5IiuHPAAzHw/LV3WURvZcT8WuNWYzDJ7olnGQ4qtHhZ19Wc5Bg+J4CcEto uMAnHTYeRCPgiAKVmSi3YWrHOm860/8BOSfSUKvQQ9G3Q7cW9XQQT1AaRu1rTSKA uua4CfftwzQmZsW3kuw5kGsNZ/H03sqvD8xT7dIJ+K9axjzEMq84ZQb+Nyykl6GM RzNIzkHkp4QotepVCvPzSznMH0bzwYR4t0ROcXbuTbRzlNyD/oa8PvjMWz9OVKRB GMn1uZyu6jC0c5/vb8GPKUxe8T1ZDSh6J38Fu7kpQRq94YLpol26Ctq81ONeYn5o UKXftw== Received: from mail-pg1-f199.google.com (mail-pg1-f199.google.com [209.85.215.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4fd7gvhabf-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 14 Jul 2026 05:21:51 +0000 (GMT) Received: by mail-pg1-f199.google.com with SMTP id 41be03b00d2f7-c890bac374eso10148263a12.1 for ; Mon, 13 Jul 2026 22:21:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1784006511; x=1784611311; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=A9GY5SmmKpXBp0S4UpoTVLYAhXq0hiNnfIA35k/Yeeo=; b=FQVFj787dafAwEeiJ7rVH5Vi/BBHnlKHlshOHIqs2IdztPoIFAxZBZZbx6Gq92UBf2 dhSWHuK+GPwZQkcBgPs/aIw6VVQQ4ELM7IK2RY4JzwUiwfTbexEvRc+ynl+xcovxCcrl 1EUGM1Up0YRoFK7qWp+fHzC8W8PbNVewVbOAYFAOTFsTDJX6zBiKApJOXQlknel72nGM bEr3cTiaq8HsPx+yrdDK6Jt7JdDW4Oz3hqhOxlMd0ioitny9Bimba7NRVGwPY5EjTamJ Oz1XAOlRp6z+9r/+mFpcgwR/iekOefQFGJYSGvp18r1xfy06l6GsqZKMFoOFiYhg0Fsp cBxQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784006511; x=1784611311; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=A9GY5SmmKpXBp0S4UpoTVLYAhXq0hiNnfIA35k/Yeeo=; b=RElVIi+xbEbqymu+Hst+3W/L4XyqHVxejIBE4RWrBeMTDREo8viat6vi721XYmJNw+ 55O+9UzLY3al087LDYjnQy4vEG5wpPMH4UTFGQWeigNLagclQxlYFZ6w4WAS0aXlOcq6 MZr2XMWIBktfNz7WKzjLg0U+v4q4fm5M7Dc4cOybobKACaKrS2YiMeFynbE/CNGX5LB9 qt29+jWuZiaoczXxP/4PH0G+V+AKDfP+olOL0+H3PYJY54SnoF98y1lYucbEIvzX+R7Z 5njmFxgUIwzVeYuPSKdPcXEECgkXc0E9FxQ0tdug0vqx77UgXdaF2dYjadAWMSRjEveS W9YQ== X-Forwarded-Encrypted: i=1; AHgh+RptrvUbKYp9A53felLygYZsmIY/65+SZZgDMar1MAJpo5hsn8j9s6IGG2lSf6jjxQE78f1ApfMA5nHRTSg=@vger.kernel.org X-Gm-Message-State: AOJu0YxQT322oY/7fIld4nWrnLGmm+82IZLYvAnbTQ6/YHsqZz4e4lrY 3QfkZa1tJo34Ph4R58R5dkF0XNqUT1qi01pN1QCdzDT+JFQOr6J7iYOT1vnSNvZXGR2jO9uWjdo Hx2kXOMt9oeaSISmN2pUeBw+Aq3L3WE7kepSzDsp3LI8T3nmyHxjS1nfWUXCngxa+3/U= X-Gm-Gg: AfdE7cl3Upu1JqLXKCkRuo1sIu0oQtO0zJ5QSSm5SjluGkiDdBuD4OhMiBcn1N+g11k jQo+E7mxP3cmIyzbcHkTMA+MaAmwxaZUihnibdyXUJM0Ma3DPUWmeVsy0zQVFsX++vlpzp33mSv TjyD9pUb2srutfbt6qYQB5/PEEuH/Oam3/7ivkeGCvdclK6H4+m2ZpjKGjxZEg5QZt65ZYbZJVx wluLXLPOPnEgsPHcoHUC/G5u0CrILZwwl/n2S/OG8meNaigOracM25R1k0ic+LSaMrU6EV8NqSW b7/u4SUm2M9PEooEJzpPXPARUcSUS1TytxJS9qZTNBXGWzfpqo+dHDBnOd7iCN4AMdJSn3s2tjo a/jcn1H3gumz0ywgdl1EplJiMKyhOtQtPpMoitS0oWw== X-Received: by 2002:a05:6a21:4cca:b0:3c0:9c19:65b9 with SMTP id adf61e73a8af0-3c110a66059mr12624713637.65.1784006510616; Mon, 13 Jul 2026 22:21:50 -0700 (PDT) X-Received: by 2002:a05:6a21:4cca:b0:3c0:9c19:65b9 with SMTP id adf61e73a8af0-3c110a66059mr12624675637.65.1784006510017; Mon, 13 Jul 2026 22:21:50 -0700 (PDT) Received: from [10.92.197.28] ([202.46.23.19]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-3120c8e41fcsm42074011eec.15.2026.07.13.22.21.45 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 13 Jul 2026 22:21:49 -0700 (PDT) Message-ID: <788b1ebb-db13-4f6f-9e92-46802d7027f6@oss.qualcomm.com> Date: Tue, 14 Jul 2026 10:51:42 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 2/2] spi: qcom-geni: add GENI SE registers trace event on error paths To: Mark Brown Cc: Bjorn Andersson , Konrad Dybcio , Steven Rostedt , Masami Hiramatsu , Mathieu Desnoyers , linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-trace-kernel@vger.kernel.org, linux-spi@vger.kernel.org, Mukesh Kumar Savaliya , Konrad Dybcio References: <20260711-add-tracepoints-for-se-reg-dump-v2-0-ca1e9ba62359@oss.qualcomm.com> <20260711-add-tracepoints-for-se-reg-dump-v2-2-ca1e9ba62359@oss.qualcomm.com> <4bcaa245-2127-45aa-bf05-48e275c0129c@oss.qualcomm.com> <72cb70b0-d89d-405b-b2b9-807e028d6fd3@sirena.org.uk> Content-Language: en-US From: Praveen Talari In-Reply-To: <72cb70b0-d89d-405b-b2b9-807e028d6fd3@sirena.org.uk> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzE0MDA1MSBTYWx0ZWRfX7vfjTGkrgh8Z ajYNuOkujO57REzQF1qTyob8/TA7NVpYCkOUYFWtQIIEn428tdxT19Mdqq++RrOvml+gF8/pB8P C5xqDR1Djk2uaNHRo6j7kMWYo1rFgQ7QWNUN2x6afujrq3RvgZ8tdw+Um6hfKIjZd1Tp3vroNLv gkqYyF38Jns3oJCHGyfBRNh+MpY//DymJpT0bL1Tp+rA1QR+jnWjAsybPTVpxPHIQ9SVHZ7NhfV kaeLbx1skY4YJPZnYkdTjo0gLZYTrGsjHcrGdBhcRg0XQE8MtFy3y98EbuMLS6+PbIPMdYjAXKi FM7SnL5Uxu1fsdWm+60SEb2Yld836g2NglhAmpjJg0cNOnBYe9maL5qNahSGXtyFlx5RTfxcpYq +g5uwUv9u78kOqcClP+/3JHPtiXoHA767pXUW40dI2xN/cotvPuU7qtBJxR3XLO331UP+OllAQt ZBTifJ265X9quvcyP+Q== X-Proofpoint-Spam-Info: AW1haW4tMjYwNzE0MDA1MSBTYWx0ZWRfXzc5QwuOAYm7t 7xOyQFNzMudjctkHAqfOueDmb/kTF1aWFnaXxAoDfJfuKsaikia5ewlQm30pWSaXyPJ2pglj5UV A0SBgl7ZiAL/Q5QVG+AuKp5A+zVTvfY= X-Proofpoint-GUID: JvlUbGnBXU1X0SEg96Avgcpmz6rl9pXh X-Proofpoint-ORIG-GUID: JvlUbGnBXU1X0SEg96Avgcpmz6rl9pXh X-Authority-Analysis: v=2.4 cv=NYjWEWD4 c=1 sm=1 tr=0 ts=6a55c76f cx=c_pps a=Oh5Dbbf/trHjhBongsHeRQ==:117 a=j4ogTh8yFefVWWEFDRgCtg==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=YMgV9FUhrdKAYTUUvYB2:22 a=JsoTjjDMo91fjAJr_joA:9 a=QEXdDO2ut3YA:10 a=_Vgx9l1VpLgwpw_dHYaR:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-14_01,2026-07-10_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 adultscore=0 spamscore=0 suspectscore=0 clxscore=1015 malwarescore=0 impostorscore=0 phishscore=0 lowpriorityscore=0 priorityscore=1501 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607140051 Hi On 13-07-2026 16:16, Mark Brown wrote: > On Sat, Jul 11, 2026 at 08:21:02AM +0530, Praveen Talari wrote: >> On 11-07-2026 02:56, Mark Brown wrote: >>> On Sat, Jul 11, 2026 at 12:18:42AM +0530, Praveen Talari wrote: >>>> +#include >>> Should this be in rivers/soc/qcom/qcom-geni-se.c (and the first patch?) >>> - that way if another driver starts using them we won't multiply define >>> the tracepoints. >> Yes, you are correct but >> If this header in drivers/soc/qcom/qcom-geni-se.c, how it will be access >> trace API in other drivers like i2c, spi and uart? > The header needs to be in the users but the CREATE_ define that you cut > needs to be in only one place to actually create the tracepoints. Sure, got it. > >>>> @@ -986,10 +997,13 @@ static irqreturn_t geni_spi_isr(int irq, void *data) >>>> writel(0, se->base + SE_GENI_TX_WATERMARK_REG); >>>> dev_err(mas->dev, "Premature done. tx_rem = %d bpw%d\n", >>>> mas->tx_rem_bytes, mas->cur_bits_per_word); >>>> + trace_geni_se_regs(se); >>> SE_GENI_TX_WATERMARK_REG is one of the registers in the tracepoint, >>> perhaps trace before we write to clear it? >> it will be captured in m_irq register so it is not required to capture. > Are you sure that won't lead to user confusion? No since m_irq can capture most of other bits as well. Thanks, Praveen talari