From: Eric Dumazet <eric.dumazet@gmail.com>
To: David Miller <davem@davemloft.net>, laoar.shao@gmail.com
Cc: eric.dumazet@gmail.com, alexei.starovoitov@gmail.com,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next] net: init sk_cookie for inet socket
Date: Mon, 23 Apr 2018 09:09:34 -0700 [thread overview]
Message-ID: <788ce3f1-6534-5c2e-1870-5ebd8ea4ae7f@gmail.com> (raw)
In-Reply-To: <20180423.115821.640630949143585629.davem@davemloft.net>
On 04/23/2018 08:58 AM, David Miller wrote:
> From: Yafang Shao <laoar.shao@gmail.com>
> Date: Sun, 22 Apr 2018 21:50:04 +0800
>
>> With sk_cookie we can identify a socket, that is very helpful for
>> traceing and statistic, i.e. tcp tracepiont and ebpf.
>> So we'd better init it by default for inet socket.
>> When using it, we just need call atomic64_read(&sk->sk_cookie).
>>
>> Signed-off-by: Yafang Shao <laoar.shao@gmail.com>
>
> Applied, thank you.
>
This is adding yet another atomic_inc on a global cache line.
Most applications do not need the cookie being ever set.
The existing mechanism was fine. Set it on demand.
next prev parent reply other threads:[~2018-04-23 16:09 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-22 13:50 Yafang Shao
2018-04-23 15:58 ` David Miller
2018-04-23 16:09 ` Eric Dumazet [this message]
2018-04-24 4:39 ` Yafang Shao
2018-04-24 11:41 ` Eric Dumazet
2018-04-24 11:47 ` Yafang Shao
2018-04-24 12:37 ` Eric Dumazet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=788ce3f1-6534-5c2e-1870-5ebd8ea4ae7f@gmail.com \
--to=eric.dumazet@gmail.com \
--cc=alexei.starovoitov@gmail.com \
--cc=davem@davemloft.net \
--cc=laoar.shao@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome