From: Vijayanand Jitta <vijayanand.jitta@oss.qualcomm.com>
To: Rob Herring <robh@kernel.org>
Cc: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>,
robin.murphy@arm.com, will@kernel.org, joro@8bytes.org,
konrad.dybcio@oss.qualcomm.com, bjorn.andersson@oss.qualcomm.com,
bod@kernel.org, conor+dt@kernel.org, krzk+dt@kernel.org,
charan.kalla@oss.qualcomm.com, prakash.gupta@oss.qualcomm.com,
vikash.garodia@oss.qualcomm.com, iommu@lists.linux.dev,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v2 2/3] of: factor arguments passed to of_map_id() into a struct
Date: Wed, 10 Dec 2025 15:59:07 +0530 [thread overview]
Message-ID: <788d981e-7186-479c-8961-8b16482aa5bf@oss.qualcomm.com> (raw)
In-Reply-To: <20251209200214.GA1015230-robh@kernel.org>
On 12/10/2025 1:32 AM, Rob Herring wrote:
> On Mon, Dec 08, 2025 at 07:10:32PM +0530, Vijayanand Jitta wrote:
>>
>>
>> On 12/5/2025 10:17 PM, Dmitry Baryshkov wrote:
>>> On 04/12/2025 11:55, Vijayanand Jitta wrote:
>>>> From: Charan Teja Kalla <charan.kalla@oss.qualcomm.com>
>>>>
>>>> Introduce a new struct type where the optional arguments passed to
>>>> of_map_id() are in struct. Subsequent patches add additional arguments
>>>> to the struct that the caller expects to be filled of_map_id().
>>>
>>> Why do we need a separate struct? Can't we use of_phandle_args instead?
>>>
>>
>> The idea is to use it for multi-map support mentioned in the cover letter,
>> where we need to pass additional context (callback, dev etc..). Having a
>> seperate structure here makes of_map_id() interface easier to extend.
>
> Then perhaps?:
>
> struct of_map_id_args {
> struct of_phandle_args args;
> ...
> }
>
Thanks, this will work. Will update it in next revision.
>>
>>>>
>>>> Signed-off-by: Charan Teja Kalla <charan.kalla@oss.qualcomm.com>
>>>> Signed-off-by: Vijayanand Jitta <vijayanand.jitta@oss.qualcomm.com>
>>>> ---
>>>> drivers/iommu/of_iommu.c | 6 +++++-
>>>> drivers/of/base.c | 31 ++++++++++++++-------------
>>>> drivers/pci/controller/dwc/pci-imx6.c | 6 +++++-
>>>> drivers/pci/controller/pcie-apple.c | 5 ++++-
>>>> drivers/xen/grant-dma-ops.c | 5 ++++-
>>>> include/linux/of.h | 23 ++++++++++++++------
>>>> 6 files changed, 50 insertions(+), 26 deletions(-)
>>>>
>>
next prev parent reply other threads:[~2025-12-10 10:29 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-04 9:55 [PATCH v2 0/3] of: parsing of multi #{iommu,msi}-cells in maps Vijayanand Jitta
2025-12-04 9:55 ` [PATCH v2 1/3] of: Add convenience wrappers for of_map_id() Vijayanand Jitta
2025-12-09 19:59 ` Rob Herring (Arm)
2025-12-04 9:55 ` [PATCH v2 2/3] of: factor arguments passed to of_map_id() into a struct Vijayanand Jitta
2025-12-05 16:47 ` Dmitry Baryshkov
2025-12-08 13:40 ` Vijayanand Jitta
2025-12-09 20:02 ` Rob Herring
2025-12-10 10:29 ` Vijayanand Jitta [this message]
2025-12-04 9:55 ` [PATCH v2 3/3] of: Respect #{iommu,msi}-cells in maps Vijayanand Jitta
2025-12-05 3:28 ` kernel test robot
2025-12-05 4:01 ` kernel test robot
2025-12-05 4:33 ` kernel test robot
2025-12-09 20:17 ` Rob Herring
2025-12-10 10:27 ` Vijayanand Jitta
2025-12-10 21:04 ` Rob Herring
2025-12-11 5:31 ` Vijayanand Jitta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=788d981e-7186-479c-8961-8b16482aa5bf@oss.qualcomm.com \
--to=vijayanand.jitta@oss.qualcomm.com \
--cc=bjorn.andersson@oss.qualcomm.com \
--cc=bod@kernel.org \
--cc=charan.kalla@oss.qualcomm.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@oss.qualcomm.com \
--cc=iommu@lists.linux.dev \
--cc=joro@8bytes.org \
--cc=konrad.dybcio@oss.qualcomm.com \
--cc=krzk+dt@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=prakash.gupta@oss.qualcomm.com \
--cc=robh@kernel.org \
--cc=robin.murphy@arm.com \
--cc=vikash.garodia@oss.qualcomm.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®