From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752615AbbCRFKb (ORCPT ); Wed, 18 Mar 2015 01:10:31 -0400 Received: from mailout1.samsung.com ([203.254.224.24]:53912 "EHLO mailout1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750763AbbCRFK1 (ORCPT ); Wed, 18 Mar 2015 01:10:27 -0400 X-AuditID: cbfee691-f79b86d000004a5a-d2-550908c2d29a Date: Wed, 18 Mar 2015 05:10:26 +0000 (GMT) From: MyungJoo Ham Subject: Re: [PATCH v6 0/8] Add support for Tegra Activity Monitor To: Tomeu Vizoso , "linux-tegra@vger.kernel.org" Cc: Mikko Perttunen , Alexandre Courbot , "devicetree@vger.kernel.org" , Ian Campbell , Kumar Gala , =?utf-8?Q?=EB=B0=95=EA=B2=BD=EB=AF=BC?= , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "linux-pm@vger.kernel.org" , Mark Rutland , Mike Turquette , Pawel Moll , Peter De Schrijver , Prashant Gaikwad , Rob Herring , Russell King , Stephen Boyd , Stephen Warren , Thierry Reding Reply-to: myungjoo.ham@samsung.com MIME-version: 1.0 X-MTR: 20150318050312642@myungjoo.ham Msgkey: 20150318050312642@myungjoo.ham X-EPLocale: ko_KR.utf-8 X-Priority: 3 X-EPWebmail-Msg-Type: personal X-EPWebmail-Reply-Demand: 0 X-EPApproval-Locale: X-EPHeader: ML X-MLAttribute: X-RootMTR: 20150318050312642@myungjoo.ham X-ParentMTR: X-ArchiveUser: X-CPGSPASS: N X-ConfirmMail: N,general Content-type: text/plain; charset=utf-8 MIME-version: 1.0 Message-id: <78905871.274971426655422042.JavaMail.weblogic@epmlwas07d> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrMIsWRmVeSWpSXmKPExsWyRsSkSPcQB2eowZ1/YhaXd81hc2D0+LxJ LoAxissmJTUnsyy1SN8ugSuj5eg+toIFshVXzv1maWDcI9PFyMkhJKAusWjJSTYQW0LAROLY 7KMsELaYxIV764HiXEA1Sxkl/m9ZC1d0dOdDqMQcRomeS4fAOlgEVCXmfHwElODgYBPQk5j5 ORkkLCzgJHFp3Rd2EFtEIE/izenHrCC9zAIb2SWWre5ihLhCSWLNvldgc3gFBCVOznzCAjJH Amjm2s4qiLCaxM797VA3iEtcmHuJHcLmlZjR/hTqaDmJaV/XMEPY0hLnZ21ghHlm8ffHUHF+ iWO3dzBB2AISU88chKrRklg+cRtUnE9izcK3LDD1u04tZ4bZdX/LXKgaCYmtLU9YQWxmAUWJ Kd0P2UFOZhbQlFi/Sx/VJyC2m8T3eR1gr0sITOSQ2DRrOesERqVZSOpmIRk1C2EUspIFjCyr GEVTC5ILipPSi0z1ihNzi0vz0vWS83M3MQLTwul/zybuYLx/wPoQowAHoxIPr8RVjlAh1sSy 4srcQ4ymwEiayCwlmpwPTD55JfGGxmZGFqYmpsZG5pZmSuK8OtI/g4UE0hNLUrNTUwtSi+KL SnNSiw8xMnFwSjUwim7r2i8UOEc9c5fMk3Onff7lWvmEXdSZ8cX5AVf/bo1gj0KL+Rynue80 Nv6KSrx4rKtbUMBJySf5geZS4TcqB6Y4iv0ucfCNSTvpa9Z0NEY08H69peT0kgLVR0JH9V+3 2Ht6n71aEapn+ftaVvqNXRdNFz6cMmVVsXpBwUVDv41F6uxPF59WYinOSDTUYi4qTgQAHlc/ DAYDAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrCKsWRmVeSWpSXmKPExsVy+t/tft1DHJyhBoub+C0u75rD5sDo8XmT XABjVJpNRmpiSmqRQmpecn5KZl66rZJ3cLxzvKmZgaGuoaWFuZJCXmJuqq2Si0+ArltmDtBQ JYWyxJxSoFBAYnGxkr6dTVF+aUmqQkZ+cYmtUrShuZGekYGeqZGeoXGslaGBgZEpUE1CWkbL 0X1sBQtkK66c+83SwLhHpouRk0NIQF1i0ZKTbCC2hICJxNGdD6FsMYkL99YD2VxANXMYJXou HWIBSbAIqErM+fgIKMHBwSagJzHzczJIWFjASeLSui/sILaIQJ7Em9OPWUF6mQU2skssW93F CLFMSWLNvldgc3gFBCVOznzCAjJHAmjm2s4qiLCaxM797VA3iEtcmHuJHcLmlZjR/pQFwpaT mPZ1DTOELS1xftYGRpibF39/DBXnlzh2ewcThC0gMfXMQagaLYnlE7dBxfkk1ix8ywJTv+vU cmaYXfe3zIWqkZDY2vKEFcRmFlCUmNL9kB3kZGYBTYn1u/RRfQJiu0l8n9fBOoFRdhaS1Cwk 3bMQupGVLGBkWcUomlqQXFCclF5holecmFtcmpeul5yfu4kRnIKeLdnB2HDB+hCjAAejEg+v xFWOUCHWxLLiytxDjBIczEoivFotQCHelMTKqtSi/Pii0pzU4kOMpsAom8gsJZqcD0yPeSXx hsbGJmYmppYmFgam5krivP/P5YYICaQnlqRmp6YWpBbB9DFxcEo1MOZ/9VFbv7DhepR020sB k6ULS6Jz/r1v2HGs/dOp+JaNh9dLpM+5+shPzafuiP/NBqEnvEl2bT13dLSjAzk7dxZOyDDL 5azkmXnNUC7wuNDbfXI5cw+s0T+pPNN0gnLUyW2XEntOhP/slPw5/Yteg7j3jrYvujpJwWaN 2rsLkpnVXV5e7TrTqsRSnJFoqMVcVJwIAP5u2RNXAwAA DLP-Filter: Pass X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by nfs id t2I5Ad7R006856 > Hello, > > something happened during the last cycle and an old version of the devfreq > driver was merged. > > This thread contains patches that bring it up to date to the last submitted > version and also incorporates the feedback that that version received, plus > some other small fixes and improvements that came up during rebase and > testing. > > These patches implement support for setting the rate of the EMC clock based on > stats collected from the ACTMON, a piece of hw in the Tegra124 that counts > memory accesses (among others). > > It depends on the following in-flight patches: > > * EMC driver: http://thread.gmane.org/gmane.linux.kernel/1907035 > * CPUFreq driver: http://thread.gmane.org/gmane.linux.kernel/1897078 > > I have pushed a branch here for testing: > > http://cgit.collabora.com/git/user/tomeu/linux.git/log/?h=actmon-v6 > > Regards, > > Tomeu > > Tomeu Vizoso (8): > of: Add binding for NVIDIA Tegra ACTMON node > PM / devfreq: tegra: Update to v5 of the submitted patches > clk: tegra: Have EMC clock implement determine_rate() > PM / devfreq: tegra: Use clock rate constraints > PM / devfreq: tegra: remove operating-points > PM / devfreq: tegra: Set drvdata before enabling the irq > PM / devfreq: tegra: Enable interrupts after resuming the devfreq > monitor > ARM: tegra: Add Tegra124 ACTMON support Acked-by: MyungJoo Ham for all PM / devfreq patches (2, 4, 5, 6, 7) And merged in for-rc tree with a little modification. In the patch 2/8, I would like to add "const" in Line 748. Would it be fine with you? (You may look at: https://git.kernel.org/cgit/linux/kernel/git/mzx/devfreq.git/log/?h=for-rc ) The diff after applying all 2/8 to 7/8 will be: diff --git a/drivers/devfreq/tegra-devfreq.c b/drivers/devfreq/tegra-devfreq.c index 0d1edd5..8e633a6 100644 --- a/drivers/devfreq/tegra-devfreq.c +++ b/drivers/devfreq/tegra-devfreq.c @@ -740,7 +740,7 @@ static int tegra_devfreq_remove(struct platform_device *pdev) return 0; } -static struct of_device_id tegra_devfreq_of_match[] = { +static const struct of_device_id tegra_devfreq_of_match[] = { { .compatible = "nvidia,tegra124-actmon" }, { }, }; > > .../devicetree/bindings/arm/tegra/actmon.txt | 28 ++ > arch/arm/boot/dts/tegra124.dtsi | 11 + > drivers/clk/tegra/clk-emc.c | 19 +- > drivers/devfreq/tegra-devfreq.c | 480 +++++++++++---------- > 4 files changed, 316 insertions(+), 222 deletions(-) > create mode 100644 Documentation/devicetree/bindings/arm/tegra/actmon.txt > > -- > 2.1.0 > {.n++%ݶw{.n+{G{ayʇڙ,jfhz_(階ݢj"mG?&~iOzv^m ?I