From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5EBE6258EE0 for ; Tue, 3 Feb 2026 18:52:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.12 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770144752; cv=none; b=CYOBOMWRj/Q85U/mzFOBI2Bdn0YRpbiV+rF7h08d/yyzOj9JqJc863kiykHzPWZiCWX8DMks3bLLQsYTIWs4I80u2ed5+myU6CNvqZ6MPajbUbTeB5gnA6X7LtDphe4/onIjZ/M5fx0BZpVwT88QIeaOyUDBHZqB8EJHk+CtxX0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770144752; c=relaxed/simple; bh=5uYYAfHKDyrTra52g4yGbZJXq32e9h50Y4woxgL0Ndk=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=pF/F58iomPzeb9s6+zRXQDJfeZ+rWrk0gwsvmrqlgdskDeGr9KPLh0py5E9krDqHxyRptG2H/c2fQDJzsKS73NmkXvg1ZBvYVEMqtewk3/rLUyiM27qDXhpprTfBv23UJM2BngO2XoIF0EVY1Am7SkYm1xbS5Tt+ylMRXt6UHGo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=pass smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=n0Vq0uUw; arc=none smtp.client-ip=198.175.65.12 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="n0Vq0uUw" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1770144752; x=1801680752; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=5uYYAfHKDyrTra52g4yGbZJXq32e9h50Y4woxgL0Ndk=; b=n0Vq0uUwQYPXC7eTtywzNE0FQimvPAUBaNpmRoFielsv5e1PrQRlPTIv DoxIhr7B7GhV1R/zbGuDe0KMo8msuu61oupf6zjd81R+FIXSqXqnrbmXD 6bBoGqEE5q7EFeXRCdoRpp4uJ7BG1s12Jm29DeB6kjr3amzpWMBXOylSw S1iUmZm0EAm47XokGM2SgKOCxFNADxf4zXSZL2RHiprToraWOjkW/sH5R V52dFfPGGlw5Hd2qupXEiyFQYPr1aeVnNqS+lIFrHJxwVleOQr/YcLbaT wLRIzSuQZQhn4A0e2lhf+jd5h3/dy3y51zfG6Ye69eafTiyM39gZu/6W6 A==; X-CSE-ConnectionGUID: 0b+0vB7hQy22GyXLAMowXw== X-CSE-MsgGUID: eAAHs0RtTlqLL1zkdEfHdg== X-IronPort-AV: E=McAfee;i="6800,10657,11691"; a="82753827" X-IronPort-AV: E=Sophos;i="6.21,271,1763452800"; d="scan'208";a="82753827" Received: from orviesa003.jf.intel.com ([10.64.159.143]) by orvoesa104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Feb 2026 10:52:31 -0800 X-CSE-ConnectionGUID: X4OrSCVLSHCC4MGpR2+o0A== X-CSE-MsgGUID: e4mrIVGnRy+zdW46ywMK+g== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.21,271,1763452800"; d="scan'208";a="214084160" Received: from mfalkows-mobl.ger.corp.intel.com (HELO [10.246.20.146]) ([10.246.20.146]) by ORVIESA003-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Feb 2026 10:52:28 -0800 Message-ID: <7891a7c6-bcf2-4099-b91e-5f8c99ea31a5@linux.intel.com> Date: Tue, 3 Feb 2026 19:52:19 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH V1] accel/amdxdna: Fix incorrect error code returned for failed chain command To: Lizhi Hou , ogabbay@kernel.org, quic_jhugo@quicinc.com, dri-devel@lists.freedesktop.org Cc: linux-kernel@vger.kernel.org, max.zhen@amd.com, sonal.santan@amd.com, mario.limonciello@amd.com References: <20260203184037.2751889-1-lizhi.hou@amd.com> Content-Language: en-US From: "Falkowski, Maciej" In-Reply-To: <20260203184037.2751889-1-lizhi.hou@amd.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Reviewed-by: Maciej Falkowski On 2/3/2026 7:40 PM, Lizhi Hou wrote: > The driver currently returns an incorrect error code when a chain command > fails. In this case, ERT_CMD_STATE_ERROR is expected to be reported for > failed chain commands. > > Fixes: aac243092b70 ("accel/amdxdna: Add command execution") > Signed-off-by: Lizhi Hou > --- > drivers/accel/amdxdna/aie2_ctx.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/accel/amdxdna/aie2_ctx.c b/drivers/accel/amdxdna/aie2_ctx.c > index ad5b5cd0bc81..fe8f9783a73c 100644 > --- a/drivers/accel/amdxdna/aie2_ctx.c > +++ b/drivers/accel/amdxdna/aie2_ctx.c > @@ -274,7 +274,7 @@ aie2_sched_cmdlist_resp_handler(void *handle, void __iomem *data, size_t size) > ret = -EINVAL; > goto out; > } > - amdxdna_cmd_set_state(cmd_abo, fail_cmd_status); > + amdxdna_cmd_set_state(cmd_abo, ERT_CMD_STATE_ERROR); > > if (amdxdna_cmd_get_op(cmd_abo) == ERT_CMD_CHAIN) { > struct amdxdna_cmd_chain *cc = amdxdna_cmd_get_payload(cmd_abo, NULL);