From: Ram Kumar Dwivedi <quic_rdwivedi@quicinc.com>
To: Krzysztof Kozlowski <krzk@kernel.org>, <mani@kernel.org>,
<alim.akhtar@samsung.com>, <avri.altman@wdc.com>,
<bvanassche@acm.org>, <robh@kernel.org>, <krzk+dt@kernel.org>,
<conor+dt@kernel.org>, <andersson@kernel.org>,
<konradybcio@kernel.org>, <agross@kernel.org>
Cc: <linux-arm-msm@vger.kernel.org>, <linux-scsi@vger.kernel.org>,
<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH V1 1/3] dt-bindings: ufs: qcom: Add reg and reg-names
Date: Wed, 30 Jul 2025 15:57:54 +0530 [thread overview]
Message-ID: <78998e50-a20c-41de-a2b8-a467475210cf@quicinc.com> (raw)
In-Reply-To: <466a42c4-54f5-45b2-b7f0-2d51695eac8e@kernel.org>
On 30-Jul-25 2:41 PM, Krzysztof Kozlowski wrote:
> On 30/07/2025 10:22, Ram Kumar Dwivedi wrote:
>> Update the Qualcomm UFS device tree bindings to support Multi-Circular
>> Queue (MCQ) operation. This includes increasing the maximum number of
>> register entries from 2 to 3 and extending the accepted values for
>> reg-names to include "mcq_sqd" and "mcq_vs".
>>
>> These changes are required to enable MCQ support via Device Tree for
>> platforms such as SM8650 and SM8750.
>>
>> Signed-off-by: Ram Kumar Dwivedi <quic_rdwivedi@quicinc.com>
>> ---
>> .../devicetree/bindings/ufs/qcom,ufs.yaml | 21 ++++++++++++-------
>> 1 file changed, 13 insertions(+), 8 deletions(-)
>>
>> diff --git a/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml b/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml
>> index 6c6043d9809e..de263118b552 100644
>> --- a/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml
>> +++ b/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml
>> @@ -86,12 +86,17 @@ properties:
>>
>> reg:
>> minItems: 1
>> - maxItems: 2
>> + maxItems: 3
>>
>> reg-names:
>> - items:
>> - - const: std
>> - - const: ice
>> + oneOf:
>> + - items:
>> + - const: std
>> + - const: ice
>> + - items:
>> + - const: ufs_mem
>> + - const: mcq_sqd
>> + - const: mcq_vs
>
> This is incompatible change and commit msg is inaccurate here. It says
> "extending" but you are not extending at all.
>
> Recent qcom patches love to break ABI and impact users. No.
>
> Best regards,
> Krzysztof
Hi Krzysztof,
Thanks for your feedback.
Regarding your concern about this being an incompatible change — could you please clarify what specific aspect you believe breaks compatibility?
From my side, I’ve carefully tested the patch and verified that it does not break any existing DTs. I ran the following command to validate against the schema:
make -j32 dt_binding_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/ufs/qcom,ufs.yaml
make -j32 dtbs_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/ufs/qcom,ufs.yaml
There were no errors reported for any target DTB.
As for the commit message, I acknowledge your point and will revise it in the next patchset to more accurately reflect the nature of the change.
Best regards,
Ram.
next prev parent reply other threads:[~2025-07-30 10:28 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-30 8:22 [PATCH V1 0/3] Enable UFS MCQ support for SM8650 and SM8750 Ram Kumar Dwivedi
2025-07-30 8:22 ` [PATCH V1 1/3] dt-bindings: ufs: qcom: Add reg and reg-names Ram Kumar Dwivedi
2025-07-30 9:11 ` Krzysztof Kozlowski
2025-07-30 10:27 ` Ram Kumar Dwivedi [this message]
2025-07-30 11:33 ` Krzysztof Kozlowski
2025-07-30 12:44 ` Krzysztof Kozlowski
2025-07-30 8:22 ` [PATCH V1 2/3] arm64: dts: qcom: sm8650: Enable MCQ support for UFS controller Ram Kumar Dwivedi
2025-07-30 9:12 ` Krzysztof Kozlowski
2025-07-30 10:30 ` Ram Kumar Dwivedi
2025-07-31 6:45 ` Krzysztof Kozlowski
2025-07-31 8:34 ` Ram Kumar Dwivedi
2025-07-31 8:38 ` Krzysztof Kozlowski
2025-08-01 12:24 ` Manivannan Sadhasivam
2025-08-01 14:20 ` Krzysztof Kozlowski
2025-08-01 15:33 ` Manivannan Sadhasivam
2025-08-01 16:09 ` Krzysztof Kozlowski
2025-08-11 9:27 ` Manivannan Sadhasivam
2025-08-11 14:34 ` Ram Kumar Dwivedi
2025-08-12 11:51 ` Konrad Dybcio
2025-07-30 8:22 ` [PATCH V1 3/3] arm64: dts: qcom: sm8750: " Ram Kumar Dwivedi
2025-07-31 8:50 ` [PATCH V1 0/3] Enable UFS MCQ support for SM8650 and SM8750 neil.armstrong
2025-08-01 12:43 ` Manivannan Sadhasivam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=78998e50-a20c-41de-a2b8-a467475210cf@quicinc.com \
--to=quic_rdwivedi@quicinc.com \
--cc=agross@kernel.org \
--cc=alim.akhtar@samsung.com \
--cc=andersson@kernel.org \
--cc=avri.altman@wdc.com \
--cc=bvanassche@acm.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=krzk@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=mani@kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®