From: "Martin Hundebøll" <martin@geanix.com>
To: Alan Cox <gnomes@lxorguk.ukuu.org.uk>
Cc: "Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Jiri Slaby" <jslaby@suse.com>,
linux-kernel@vger.kernel.org, "Sean Nyekjær" <sean@geanix.com>,
"Esben Haabendal" <esben@geanix.com>
Subject: Re: [PATCH 4/4] tty: n_gsm: add ioctl to map serial device to mux'ed tty
Date: Wed, 10 Jul 2019 11:51:15 +0200 [thread overview]
Message-ID: <789b9d92-8110-d9e6-796e-e372d440fe51@geanix.com> (raw)
In-Reply-To: <20190709162221.623f99ce@alans-desktop>
On 09/07/2019 17.22, Alan Cox wrote:
>> + int base;
>>
>> /* open the serial port connected to the modem */
>> fd = open(SERIAL_PORT, O_RDWR | O_NOCTTY | O_NDELAY);
>> @@ -58,6 +61,11 @@ Major parts of the initialization program :
>> c.mtu = 127;
>> /* set the new configuration */
>> ioctl(fd, GSMIOC_SETCONF, &c);
>> + /* get and print base gsmtty device node */
>> + ioctl(fd, GSMIOC_GETBASE, &base);
> Can we at least use a specific sized type ? uint32_t or whatever is fine.
Sure.
I am also considering whether returning the base (i.e. the unexposed
control line) just confuses users. It might be better to use
GSMIOC_GETFIRST instead, which would then return 1 for the first mux,
and 65 for the second, and so forth.
// Martin
next prev parent reply other threads:[~2019-07-10 9:51 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-08 19:02 [PATCH 1/4] tty: n_gsm: remove obsolete mknod doc example Martin Hundebøll
2019-07-08 19:02 ` [PATCH 2/4] tty: n_gsm: update doc example to use header for N_GSM0710 define Martin Hundebøll
2019-07-08 19:02 ` [PATCH 3/4] tty: n_gsm: add helper to convert mux-num to/from tty-base Martin Hundebøll
2019-07-08 19:02 ` [PATCH 4/4] tty: n_gsm: add ioctl to map serial device to mux'ed tty Martin Hundebøll
2019-07-09 5:35 ` Jiri Slaby
2019-07-09 15:22 ` Alan Cox
2019-07-10 9:51 ` Martin Hundebøll [this message]
2019-07-09 5:29 ` [PATCH 1/4] tty: n_gsm: remove obsolete mknod doc example Jiri Slaby
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=789b9d92-8110-d9e6-796e-e372d440fe51@geanix.com \
--to=martin@geanix.com \
--cc=esben@geanix.com \
--cc=gnomes@lxorguk.ukuu.org.uk \
--cc=gregkh@linuxfoundation.org \
--cc=jslaby@suse.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sean@geanix.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®