From: "Cédric Le Goater" <clg@kaod.org>
To: Joel Stanley <joel@jms.id.au>, minyard@acm.org
Cc: openipmi-developer@lists.sourceforge.net, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ipmi: Fix ioremap error handling in bt-bmc
Date: Wed, 21 Sep 2016 12:17:51 +0200 [thread overview]
Message-ID: <789d8d52-7ce0-deee-617b-2502a7a3eb93@kaod.org> (raw)
In-Reply-To: <20160921100553.16314-1-joel@jms.id.au>
On 09/21/2016 12:05 PM, Joel Stanley wrote:
> devm_ioremap_resource returns ERR_PTR so we can't check for NULL.
Thanks for spotting this.
Acked-by: Cédric Le Goater <clg@kaod.org>
C.
> Signed-off-by: Joel Stanley <joel@jms.id.au>
> ---
> drivers/char/ipmi/bt-bmc.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/char/ipmi/bt-bmc.c b/drivers/char/ipmi/bt-bmc.c
> index 2e880bf0be26..de64bf1f2f4d 100644
> --- a/drivers/char/ipmi/bt-bmc.c
> +++ b/drivers/char/ipmi/bt-bmc.c
> @@ -438,8 +438,8 @@ static int bt_bmc_probe(struct platform_device *pdev)
> }
>
> bt_bmc->base = devm_ioremap_resource(&pdev->dev, res);
> - if (!bt_bmc->base)
> - return -ENOMEM;
> + if (IS_ERR(bt_bmc->base))
> + return PTR_ERR(bt_bmc->base);
>
> mutex_init(&bt_bmc->mutex);
> init_waitqueue_head(&bt_bmc->queue);
>
next prev parent reply other threads:[~2016-09-21 15:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-21 10:05 Joel Stanley
2016-09-21 10:17 ` Cédric Le Goater [this message]
2016-09-21 16:34 ` Corey Minyard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=789d8d52-7ce0-deee-617b-2502a7a3eb93@kaod.org \
--to=clg@kaod.org \
--cc=joel@jms.id.au \
--cc=linux-kernel@vger.kernel.org \
--cc=minyard@acm.org \
--cc=openipmi-developer@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®