From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 19017CCA47B for ; Thu, 2 Jun 2022 16:10:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236834AbiFBQK4 convert rfc822-to-8bit (ORCPT ); Thu, 2 Jun 2022 12:10:56 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51390 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233936AbiFBQKw (ORCPT ); Thu, 2 Jun 2022 12:10:52 -0400 Received: from mail.holtmann.org (coyote.holtmann.net [212.227.132.17]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id B2E7D21AC5F; Thu, 2 Jun 2022 09:10:50 -0700 (PDT) Received: from smtpclient.apple (p4ff9fc30.dip0.t-ipconnect.de [79.249.252.48]) by mail.holtmann.org (Postfix) with ESMTPSA id BCA13CED19; Thu, 2 Jun 2022 18:10:49 +0200 (CEST) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.100.31\)) Subject: Re: [PATCH v2 1/3] Bluetooth: Add new quirk for broken local ext features max_page From: Marcel Holtmann In-Reply-To: <20220524212155.16944-2-bage@debian.org> Date: Thu, 2 Jun 2022 18:10:49 +0200 Cc: Rob Herring , Maxime Ripard , Chen-Yu Tsai , Johan Hedberg , "David S. Miller" , Jakub Kicinski , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-bluetooth@vger.kernel.org, netdev@vger.kernel.org, Vasily Khoruzhick Content-Transfer-Encoding: 8BIT Message-Id: <78EC62F6-40D5-4E18-B2FA-DA2EB9D67986@holtmann.org> References: <20220524212155.16944-1-bage@debian.org> <20220524212155.16944-2-bage@debian.org> To: Bastian Germann X-Mailer: Apple Mail (2.3696.100.31) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Bastian, > Some adapters (e.g. RTL8723CS) advertise that they have more than > 2 pages for local ext features, but they don't support any features > declared in these pages. RTL8723CS reports max_page = 2 and declares > support for sync train and secure connection, but it responds with > either garbage or with error in status on corresponding commands. please include btmon output for the garbage and/or error. > > Signed-off-by: Vasily Khoruzhick > [rebase on current tree] > Signed-off-by: Bastian Germann > --- > include/net/bluetooth/hci.h | 7 +++++++ > net/bluetooth/hci_event.c | 4 +++- > 2 files changed, 10 insertions(+), 1 deletion(-) > > diff --git a/include/net/bluetooth/hci.h b/include/net/bluetooth/hci.h > index 69ef31cea582..af26e8051905 100644 > --- a/include/net/bluetooth/hci.h > +++ b/include/net/bluetooth/hci.h > @@ -265,6 +265,13 @@ enum { > * runtime suspend, because event filtering takes place there. > */ > HCI_QUIRK_BROKEN_FILTER_CLEAR_ALL, > + > + /* When this quirk is set, max_page for local extended features > + * is set to 1, even if controller reports higher number. Some > + * controllers (e.g. RTL8723CS) report more pages, but they > + * don't actually support features declared there. > + */ > + HCI_QUIRK_BROKEN_LOCAL_EXT_FTR_MAX_PAGE, > }; Can we just call it _BROKEN_LOCAL_EXT_FEATURES_PAGE_2. Now with that said, is Secure Connections really broken? We need that bit to indicate support for this. Regards Marcel