From: Rijo Thomas <Rijo-john.Thomas@amd.com>
To: Jerome Forissier <jerome.forissier@linaro.org>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Devaraj Rangasamy <Devaraj.Rangasamy@amd.com>,
op-tee@lists.trustedfirmware.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 1/1] tee: amdtee: Use %pUl printk() format specifier to print GUIDs
Date: Mon, 23 Sep 2024 16:37:30 +0530 [thread overview]
Message-ID: <78a3361f-2223-498e-1ee9-644998e55d6e@amd.com> (raw)
In-Reply-To: <94e37138-ae66-4336-93ac-79683f2058aa@linaro.org>
On 9/17/2024 12:52 PM, Jerome Forissier wrote:
>
>
> On 9/16/24 11:38, Andy Shevchenko wrote:
>> On Mon, Sep 16, 2024 at 01:38:27PM +0530, Rijo Thomas wrote:
>>> On 9/13/2024 2:59 PM, Andy Shevchenko wrote:
>>>> On Thu, Sep 12, 2024 at 07:50:08AM +0200, Jens Wiklander wrote:
>>>>> On Wed, Sep 11, 2024 at 10:41 PM Andy Shevchenko
>>>>> <andriy.shevchenko@linux.intel.com> wrote:
>>>>>>
>>>>>> Replace the custom approach with the %pUl printk() format specifier.
>>>>>> No functional change intended.
>>>>
>>>>> Thanks, the patch looks like a nice simplificatrion.
>>>>
>>>> Thank you for the review.
>>>>
>>>>> Rijo, Devaraj, does this work for you?
>>>>
>>>> Yes, please test, because seems others use uuid_t (UUID BE) for TEE,
>>>> but in this driver IIUC it's guid_t (UUID LE).
>>>
>>> No, this does not work for us. I tested this patch, it does not work as expected.
>>>
>>> %pUl gives output in uuid format (%08x-%04x-%04x-%02x%02x-%02x%02x%02x%02x%02x%02x).
>>> But, what we need, is a name with the format %08x-%04x-%04x-%02x%02x%02x%02x%02x%02x%02x%02x.
>>>
>>> Endian-ness is not an issue here. uuid generates name with 4 hypens (-).
>>> While, in our TA naming we are using 3 hyphens (-).
>>
>> Ah, good catch! Can somebody add a comment there to explain that this uses
>> non-standard human-readable representation of GUID/UUID?
>
> Could this be due to some copying/pasting from the OP-TEE code base which had
> a similar mistake prior to v2.3.0 [1][2][3]?
>
> [1] https://github.com/OP-TEE/optee_os/blob/2.3.0/CHANGELOG.md?plain=1#L40-L45
> [2] https://github.com/OP-TEE/optee_client/commit/a5b1ffcd26e3
> [3] https://github.com/OP-TEE/optee_client/commit/365657667f89
>
>>
>> P.S. Thank you for testing!
>>
>
> Regards,
>
Thanks Jerome for the information. We will update and post a patch for this.
Regards,
Rijo
prev parent reply other threads:[~2024-09-23 11:07 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-11 20:41 Andy Shevchenko
2024-09-12 5:50 ` Jens Wiklander
2024-09-13 9:29 ` Andy Shevchenko
2024-09-16 8:08 ` Rijo Thomas
2024-09-16 9:38 ` Andy Shevchenko
2024-09-16 9:39 ` Andy Shevchenko
2024-09-16 9:51 ` Andy Shevchenko
2024-09-17 7:22 ` Jerome Forissier
2024-09-18 9:54 ` Andy Shevchenko
2024-09-23 11:07 ` Rijo Thomas [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=78a3361f-2223-498e-1ee9-644998e55d6e@amd.com \
--to=rijo-john.thomas@amd.com \
--cc=Devaraj.Rangasamy@amd.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=jerome.forissier@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=op-tee@lists.trustedfirmware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®