From: Jan Kiszka <jan.kiszka@siemens.com>
To: Vignesh Raghavendra <vigneshr@ti.com>, Nishanth Menon <nm@ti.com>,
Tero Kristo <kristo@kernel.org>, Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>
Cc: linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
Bao Cheng Su <baocheng.su@siemens.com>
Subject: Re: [PATCH v3 3/7] arm64: dts: ti: iot2050: Factor out arduino connector bits
Date: Wed, 14 Feb 2024 12:21:53 +0100 [thread overview]
Message-ID: <78aac8b5-4ae0-4a0d-9b74-35bf88e3cbf2@siemens.com> (raw)
In-Reply-To: <4f122f5d-e430-4299-b6c5-bbe778aad736@ti.com>
On 14.02.24 11:13, Vignesh Raghavendra wrote:
>
>
> On 09/02/24 12:53, Jan Kiszka wrote:
>> From: Jan Kiszka <jan.kiszka@siemens.com>
>>
>> A new variant is to be added which will not have a arduino connector
>> like the existing ones. Factor out all bits that are specific to this
>> connector.
>>
>> The split is not perfect because wkup_gpio0 is defined based on what is
>> common to all variants having the connector, thus containing also
>> connector-unrelated information. But this is still cleaner than
>> replicating this node into all 4 variants.
>>
>> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
>> ---
>> .../ti/k3-am65-iot2050-arduino-connector.dtsi | 768 ++++++++++++++++++
>> .../boot/dts/ti/k3-am65-iot2050-common.dtsi | 753 -----------------
>> .../ti/k3-am6528-iot2050-basic-common.dtsi | 1 +
>> .../dts/ti/k3-am6548-iot2050-advanced-m2.dts | 1 +
>> .../dts/ti/k3-am6548-iot2050-advanced-pg2.dts | 1 +
>> .../dts/ti/k3-am6548-iot2050-advanced.dts | 1 +
>> 6 files changed, 772 insertions(+), 753 deletions(-)
>> create mode 100644
>> arch/arm64/boot/dts/ti/k3-am65-iot2050-arduino-connector.dtsi
>>
>> diff --git
>> a/arch/arm64/boot/dts/ti/k3-am65-iot2050-arduino-connector.dtsi
>> b/arch/arm64/boot/dts/ti/k3-am65-iot2050-arduino-connector.dtsi
>> new file mode 100644
>> index 000000000000..cd86f412b837
>> --- /dev/null
>> +++ b/arch/arm64/boot/dts/ti/k3-am65-iot2050-arduino-connector.dtsi
>> @@ -0,0 +1,768 @@
>> +// SPDX-License-Identifier: GPL-2.0
>
> This and elsewhere in the series should be
>
> // SPDX-License-Identifier: GPL-2.0-only
>
> as fixed up by Nishanth in [0]. I can fix that locally, let me know.
>
Yes, please.
> [0] https://lore.kernel.org/r/20240122145539.194512-16-nm@ti.com
>
Thanks,
Jan
--
Siemens AG, Technology
Linux Expert Center
next prev parent reply other threads:[~2024-02-14 11:21 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-09 7:23 [PATCH v3 0/7] arm64: dts: iot2050: Add support for new SM variant Jan Kiszka
2024-02-09 7:23 ` [PATCH v3 1/7] dt-bindings: arm: ti: Add binding for Siemens IOT2050 " Jan Kiszka
2024-02-09 7:23 ` [PATCH v3 2/7] arm64: dts: ti: iot2050: Disable R5 lockstep for all PG2 boards Jan Kiszka
2024-02-09 7:23 ` [PATCH v3 3/7] arm64: dts: ti: iot2050: Factor out arduino connector bits Jan Kiszka
2024-02-14 10:13 ` Vignesh Raghavendra
2024-02-14 11:21 ` Jan Kiszka [this message]
2024-02-09 7:23 ` [PATCH v3 4/7] arm64: dts: ti: iot2050: Factor out enabling of USB3 support Jan Kiszka
2024-02-09 7:23 ` [PATCH v3 5/7] arm64: dts: ti: iot2050: Factor out DP related bits Jan Kiszka
2024-02-09 7:23 ` [PATCH v3 6/7] arm64: dts: ti: iot2050: Annotate LED nodes Jan Kiszka
2024-02-09 7:23 ` [PATCH v3 7/7] arm64: dts: ti: iot2050: Support IOT2050-SM variant Jan Kiszka
2024-02-16 6:30 ` [PATCH v3 0/7] arm64: dts: iot2050: Add support for new SM variant Vignesh Raghavendra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=78aac8b5-4ae0-4a0d-9b74-35bf88e3cbf2@siemens.com \
--to=jan.kiszka@siemens.com \
--cc=baocheng.su@siemens.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=kristo@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nm@ti.com \
--cc=robh+dt@kernel.org \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®