From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1034929AbcIZBEp (ORCPT ); Sun, 25 Sep 2016 21:04:45 -0400 Received: from szxga03-in.huawei.com ([119.145.14.66]:13886 "EHLO szxga03-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1034538AbcIZBEh (ORCPT ); Sun, 25 Sep 2016 21:04:37 -0400 Subject: Re: [PATCH] f2fs: remove dirty inode pages in error path To: Jaegeuk Kim References: <20160923211105.20848-1-jaegeuk@kernel.org> <20160924174713.GA25123@jaegeuk> CC: , , From: Chao Yu Message-ID: <78aaef5d-970c-8b2f-820c-bf00f75d344b@huawei.com> Date: Mon, 26 Sep 2016 09:04:22 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.0 MIME-Version: 1.0 In-Reply-To: <20160924174713.GA25123@jaegeuk> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.134.22.195] X-CFilter-Loop: Reflected X-Mirapoint-Virus-RAPID-Raw: score=unknown(0), refid=str=0001.0A020206.57E8741C.00F7,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0, ip=0.0.0.0, so=2013-05-26 15:14:31, dmn=2013-03-21 17:37:32 X-Mirapoint-Loop-Id: f46dd2069960e9d5b192ffcb596100ff Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2016/9/25 1:47, Jaegeuk Kim wrote: > On Sat, Sep 24, 2016 at 09:02:02AM +0800, Chao Yu wrote: >> On 2016/9/24 5:11, Jaegeuk Kim wrote: >>> When getting EIO while handling orphan inodes, we can get some dirty node >>> pages. Then, f2fs_write_node_pages() called by iput(node_inode) will try >>> to flush node pages. But in this case, we should prevent to do that, since >>> we will try again from the start. >> >> We are protected since we set SBI_POR_DOING flag in sb, so we are safe now? > > Safe, but we get an infinite loop to flush node pages. Got it. Thanks, > >> >> Thanks, > > . >