From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753818AbdJIFnw (ORCPT ); Mon, 9 Oct 2017 01:43:52 -0400 Received: from mail-co1nam03on0055.outbound.protection.outlook.com ([104.47.40.55]:18784 "EHLO NAM03-CO1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751825AbdJIFnu (ORCPT ); Mon, 9 Oct 2017 01:43:50 -0400 Authentication-Results: spf=pass (sender IP is 149.199.60.100) smtp.mailfrom=xilinx.com; kernel.org; dkim=none (message not signed) header.d=none;kernel.org; dmarc=bestguesspass action=none header.from=xilinx.com; Subject: Re: [PATCH 1/2] arm: dts: Add support for National Instruments Project Sulfur SDRs To: Moritz Fischer , Michal Simek CC: Philip Balister , , , , , , , , , Arnd Bergmann References: <20170911232223.91894-1-mdf@kernel.org> <314acb1f-1f0f-7893-70a8-9379c01112ac@xilinx.com> <20170925161136.GA12943@tyrael.ni.corp.natinst.com> <6b87e902-3201-6710-4921-d465dea19dcd@xilinx.com> <20170926175018.GA14962@tyrael.ni.corp.natinst.com> <3b41cfc0-08b7-853d-3439-7f9848d04d3c@balister.org> <58fe4e6c-8765-bd9a-0698-8f8326f95e40@xilinx.com> <20171006161808.GA14871@tyrael.ni.corp.natinst.com> From: Michal Simek Message-ID: <78aba405-5c2b-7c8c-bc41-6e93b3ff8563@xilinx.com> Date: Mon, 9 Oct 2017 07:42:55 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: <20171006161808.GA14871@tyrael.ni.corp.natinst.com> Content-Type: text/plain; charset="windows-1252" Content-Language: en-US Content-Transfer-Encoding: 7bit X-RCIS-Action: ALLOW X-TM-AS-Product-Ver: IMSS-7.1.0.1224-8.1.0.1062-23378.005 X-TM-AS-User-Approved-Sender: Yes;Yes X-EOPAttributedMessage: 0 X-MS-Office365-Filtering-HT: Tenant X-Forefront-Antispam-Report: CIP:149.199.60.100;IPV:NLI;CTRY:US;EFV:NLI;SFV:NSPM;SFS:(10009020)(6009001)(376002)(346002)(2980300002)(438002)(189002)(24454002)(199003)(377454003)(83506001)(189998001)(6246003)(33646002)(65956001)(65806001)(356003)(23746002)(93886005)(8676002)(81166006)(31686004)(305945005)(81156014)(54356999)(76176999)(50986999)(2906002)(6666003)(316002)(47776003)(8936002)(110136005)(53546010)(36386004)(7416002)(64126003)(230700001)(86362001)(36756003)(478600001)(5660300001)(63266004)(54906003)(31696002)(65826007)(50466002)(9786002)(77096006)(2950100002)(106466001)(229853002)(4326008)(106002)(58126008)(107986001)(5001870100001);DIR:OUT;SFP:1101;SCL:1;SRVR:MWHPR02MB3278;H:xsj-pvapsmtpgw02;FPR:;SPF:Pass;PTR:unknown-60-100.xilinx.com,xapps1.xilinx.com;MX:1;A:1;LANG:en; X-Microsoft-Exchange-Diagnostics: 1;BL2NAM02FT044;1:Z9TPiRgJSey1s1tat8CbhsqogZoMtyArM/6zbtHiR37W9+D76VHLDJ1nHz/2CXN+mdfDEkvQTMKSiwxkZEQwS7zUfPfjd8p1wJRWk4n24vtiYBr0nAu6A/uCQgqYdzxQ X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: cbda6a62-e98b-44e9-6f85-08d50ed89ba5 X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(2017030254152)(8251501002)(2017052603199)(201703131423075)(201703031133081)(201702281549075);SRVR:MWHPR02MB3278; X-Microsoft-Exchange-Diagnostics: 1;MWHPR02MB3278;3:EikRnpYZSyuWnOXhL4gWS27gcBLsYBTlakgeweQ6Kk5PGZ9PCcZMuvb0rWstVNDayF3Bn++FvKBmuincc3omT1y4hK/17QbghTOzMZ7Rwxxru87u3CL56qL3YJP/0kk7ZoxAeMrHeBQT0Z0g+PFBaQO18UBHqZ5DC4OtaaocS1sEKjQLFvG9CQNL5O/65TmswZDf3iAq/d/+raM9VfEOweA5tQcwgDt59fWMycN7tegMc2DRSZgrku/jNDnKy8FNP2ppDvmKR+tphJrJDl8ZAfs0AaH6vt/AlEpyB4J9K6FGFVVJm7nXlNmwqzu/JpFEIN2YnVSLCUy+x3up1G+rE5lwoAqyW8Pp6C/PsJ7YU6s=;25:8hsKjUhnEaJc+AuC1wO4GdjJOwv8CHyhkbrFmobaZxmIF3fcgphl7oflwjWHQD8zwaRGFGXklFoBlxC7Hq2c21RbJTx0ymesiRtHwK4zV2UtryMKK7HVGC3vDtlMl2pok3MOaiWQMb3kAway46tOtZ/ksKFPRkENldL8ThFs7ncNYHTP2uuAcYzU073qEVzyMbsqnaJ5ufgdn1tD6cr/35AZiO45+CwcI1bKFkRbes8b6Z7GW1/MhhP/b/dSshIQO8VEkrJFvhavRA3iLrtdfhDhrjO5AmtPW61AiI9sMaIdvYDVvJMnp4rRqlw+yCPI6YJyrxrepIRsvQipLu+wVw== X-MS-TrafficTypeDiagnostic: MWHPR02MB3278: X-Microsoft-Exchange-Diagnostics: 1;MWHPR02MB3278;31:8YacXTXycfqzjihFiYqsxrrrtQiIoBgqO1epmSNWUY0otFzTzNyHdTn6rascE0FiNUBoYxFxZklsnCu4x5NZGqZt/q+hvWzcrfDWC4h8gIz7hOHFU+0zCMlSZby5va4pfqFn+Sueuu2UNvM/W+P9EL9c33LwtEzEsHFNfhRWzlj1E/rl6PEq64d9i90CwXBxC4F/jymbk65ZMnAsEev9Jlsn/7mKTXwu4UesyMZAPGY=;20:jFk+jU0IZE2Ohkpfjurmjku0jDrwrwkF7tkTq6U8jXXYmNYd5JnZF39ewbg7UqFYc18ITdCWUBWMtnPRZKtITHgw4haeB2meTT5b90sT4gWY8OZTRPzqy5VtrVNRo0o2CNbLQ5bxFuNNEoH7aYZGDJpiVKp19YK9zLd/d7nzGlJhn66zeAPQ8QIuwfEQcMmZK6+1pZUUaAqF0jjdoiPqjd8IUmObJaTdj8GyA2Vbvc8Un9BcHYWx29IlVG+WQGieGMKY4OxiXmlLrXl/BQtnzTTv57q6PYWOM1h8BTjILP4GgMrlInCXNseSUoZK+j1pjHnehIN9Ft93wsWjCp1+VxRi/MfV0dK79oqRR5L4hfecgwvxre3H82iSDOgaDlcloIvF+ytC8c7FJM6m0nv1BtLeVaxvqJoOr9CFzxIjCWc9ID+T6uyCteS8JZcPWTuz0vpI5g8OoOCfIHyTEEGuKAPFn8b7hsJuFA2pkBUb9D3qhrKt1BVQGt1W4scuod7m X-Exchange-Antispam-Report-Test: UriScan:(21532816269658); X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(8121501046)(5005006)(100000703101)(100105400095)(3002001)(10201501046)(93006095)(93004095)(6055026)(6041248)(20161123558100)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123555025)(20161123564025)(20161123562025)(20161123560025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);SRVR:MWHPR02MB3278;BCL:0;PCL:0;RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);SRVR:MWHPR02MB3278; X-Microsoft-Exchange-Diagnostics: 1;MWHPR02MB3278;4:AZMgtsvJs2xS4lsMussdHbVVo/QadG413gswQ+JMr6cvRZ5RzImit8gLuQR9uO/Mtmnk8L0KjracU/uT7THTL21RdvM2hIOt0XqFpANRjp2nTtBkIKrVfXH/W321SVzQ1Hh43SoB718Oy5IYyZpAVsMYV38YFePuaULWFlmtDv9B047Cv2jBPjqHzUSFFMJWQywN/lYHzuvzHVu03K3VbeN+QiWptGfzwbVTgYwRRzxv1izq5UsZS/yyaIrmCrL2BgxeTtTBoQyd8qJPBWRMr7zpt8BwE1eEG1sdj49/ADc= X-Forefront-PRVS: 045584D28C X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1;MWHPR02MB3278;23:K7lJ7oH3ULCVPAJ9btt3nVFcrYdCxQyHS0JEz?= =?Windows-1252?Q?KG5MEKPzFKmcb/x0Dc0+aaSCGaaYL1pAUrATgawkg51RWWbNlaaSl5fG?= =?Windows-1252?Q?UJmAxzyBN3j5LGi97VV8G7x8yePsaCBrBL0m2GB/ICIpvTzDyzgqvLXA?= =?Windows-1252?Q?ii4TSiIn74VpeWzZp/w88xAmDCJT5y2rs8E+KlnWoFFSUdeQzavGRNHO?= =?Windows-1252?Q?S8JaiAI6S67K+TK1Au4KzP15x5EArG4lSUdwa3DUXYYORAqdTFGjZc+E?= =?Windows-1252?Q?oH4pfzriN0KlemaL4R2uGd9O6l6RV4csveXxSAAaDe+waKqSsT/fjLZI?= =?Windows-1252?Q?t/e4otcMTBLC45qa8bO0z0LPKKB0EeybOn3o+exyoMPOwanJi9YNgJs3?= =?Windows-1252?Q?srNY9lAenIJWIjFPxh1IgvO4LB34UbqncWhslT6CsskNWz1NF2VJQg7W?= =?Windows-1252?Q?OQYVVh+kIDcAPr+zfas080Mpj6DQ99YENgw8Q0xEsXoZx1ypGrsNvPS3?= =?Windows-1252?Q?JBVBJHijGnYzpuMNkxeQpJCgLDurTrDRK8HGjqaSStfLg6unMgKOlGtx?= =?Windows-1252?Q?ZdU32lppAECkN21Pd3tb9fOl4LRMgIPmUXdnJzUdG6mHi74Sx3lWhE0j?= =?Windows-1252?Q?MNijLCuAwfTLyaz3yfM/sP5uLIqGKymo21T1zIrX4bVqscb0kyPsELS/?= =?Windows-1252?Q?n0pbNW8FvDCGqAlDoV9Xqx3pvHwjhiVWHbx0DctFT1Q/vt5dmvqKxcre?= =?Windows-1252?Q?DyCyBFSd+62fCjDF5Oa9+VlXDojGuYAaNhK/7IKa14blFV9hyVjyaBAP?= =?Windows-1252?Q?4/UwHVLUYRHQoIRLSqn5RKT3THCm5sKCAdvsB+8iq5VRjibam8r8t9g0?= =?Windows-1252?Q?wCSsQmQhc5iPhp6NqQYXHC22AYM7qH3/tsoSg+yzjIeoxKA3Dx5bW/Aa?= =?Windows-1252?Q?p+OUXFI/Kpoj29YBRknKe+tQt4DsFgfu2q+r7VRSAEGMqFJPHXJ27abD?= =?Windows-1252?Q?DaNOmPnGS4EmHR5JGTNvq0TUaps9nPKNNSPwFUJhhFIiTM2J5YT7krfb?= =?Windows-1252?Q?rO8rZvkC0w94eKlg+AsAxOKfgYXfve+bBjPvG6LjdZkqzIh+5lW3KEyI?= =?Windows-1252?Q?Qx4wOCL/P0GrwhB2IXHdkw6aWXJgH3XwskaP2/lvcgG/22GlaV87jJ9k?= =?Windows-1252?Q?srSJ2OttBjCEnCkeCNY9f4kITr1CclFy5BSt1ePh7DrFJ0iz+CtiBFFf?= =?Windows-1252?Q?BWN7sjMsgRjl5Dcc8hdDb8BJBwDqDT7t+ap1vYiJHhaidYQ1jj3GX5Vv?= =?Windows-1252?Q?M5QuzD/1tI5Rf4ugT6Isox17cR79qQZM8/Vg/7fRUzNgYZ3xQZsUApAW?= =?Windows-1252?Q?AW4CS9EkBg42FmvcEUqF9qPi+XDc6kve3bMBWgPhqhqHdrplHaipzs?= =?Windows-1252?Q?=3D?= X-Microsoft-Exchange-Diagnostics: 1;MWHPR02MB3278;6:UgfVMLQGm811arj9eNspZj+QkHqRol3kB8ff2QNEEKWnWH7EGWc4nqMS3f0/CsNOctgcMM3iUR3TIkMW+DxGx9GzCIJcg8273InHp2lIzBVBd8thkQVFkSVlBBM7VzVGD1v0UwUSxIpl9QvVrOXH/fsqnbhiAE2H+uiTI5oCse/lkTYERt7KOsg3nFZMsLoK5EfpmANVBUOoauneSFSX3Hf/AA4ItuG7O88/0/P8C1SsN+r8tryK3r9r41kJDaxWpD8BXxxJXQdBQMfPCjtygsb4wp2wahXD8c/Xrt5dTstSndSa9XdpNLXsWgJYT3IHhJ3M9rrtllZB/RwLWDsHVQ==;5:uTHksUDHRw9Oj1v2tgLxtAARO9OjDqDWDmEz0Ht8qom9cAHiL01hHw/uw/jglqrCxP1cUUAzXU1E4HXGQKdvtsyeDrylpVk2kO+/Yipqq7Qaq/6CUfmXLKOO1Gr5kk6tmJNGD7dGpg5SxAyasM6E3mu1v84mMLrNZhC0dUrhdd8=;24:kiyTEmXgQElieubH8YETKE2Jb88va6HGD4oYQLhlGjSnn+CqZJaQPsYUqXiwJYMzCWtDMdSDLJVaYPONrwoCbapXOv6fgshP0DBkNCgQCkI=;7:hlzwC1ELR//X1Ig73IkWcPqqSozgePPO3OB1qFneLAQn+6CmOpQM6l+m42shSrVkaM9dGC9lx6hOyqyqghGRnlM1UFHbVOa8i126vKjo+K07USuoCuNyFzBpUJ5kP4H5pliOqU8UMZ9Wd++2hxhXBhbOnNPN6yh0Pm2L9GclR5aCpzEM5Mhn5cu+yRIfKtsBt3Jemze29itjfL4MDBLl3d4JjemblIOSLgat8i+bV3Y= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: xilinx.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Oct 2017 05:43:02.7481 (UTC) X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c;Ip=[149.199.60.100];Helo=[xsj-pvapsmtpgw02] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR02MB3278 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 6.10.2017 18:18, Moritz Fischer wrote: > On Fri, Oct 06, 2017 at 01:49:44PM +0200, Michal Simek wrote: >> On 26.9.2017 20:15, Philip Balister wrote: >>> On 09/26/2017 02:06 PM, Michal Simek wrote: >>>> On 26.9.2017 19:58, Philip Balister wrote: >>>>> On 09/26/2017 01:50 PM, Moritz Fischer wrote: >>>>>> Michal, >>>>>> >>>>>> On Tue, Sep 26, 2017 at 02:54:48PM +0200, Michal Simek wrote: >>>>>>> Hi, >>>>>>> >>>>>>> On 25.9.2017 18:11, Moritz Fischer wrote: >>>>>>>> Hi Michal, >>>>>>>> >>>>>>>> On Mon, Sep 25, 2017 at 10:19:44AM +0200, Michal Simek wrote: >>>>>>>>> Hi Moritz >>>>>>>>> >>>>>>>>> sorry for delay. >>>>>>>> >>>>>>>> No problem. >>>>>>>> >>>>>>>>> >>>>>>>>> On 12.9.2017 01:22, Moritz Fischer wrote: >>>>>>>>>> Add support for the National Instruments Project Sulfur SDR >>>>>>>>>> motherboards Rev 2,3 and 4. >>>>>>>>>> >>>>>>>>>> Signed-off-by: Moritz Fischer >>>>>>>>>> --- >>>>>>>>>> arch/arm/boot/dts/Makefile | 3 + >>>>>>>>>> arch/arm/boot/dts/zynq-ni-sulfur-rev2.dts | 84 +++++++++++++++++++ >>>>>>>>>> arch/arm/boot/dts/zynq-ni-sulfur-rev3.dts | 118 ++++++++++++++++++++++++++ >>>>>>>>>> arch/arm/boot/dts/zynq-ni-sulfur-rev4.dts | 26 ++++++ >>>>>>>>>> arch/arm/boot/dts/zynq-ni-sulfur.dtsi | 133 ++++++++++++++++++++++++++++++ >>>>>>>>>> 5 files changed, 364 insertions(+) >>>>>>>>>> create mode 100644 arch/arm/boot/dts/zynq-ni-sulfur-rev2.dts >>>>>>>>>> create mode 100644 arch/arm/boot/dts/zynq-ni-sulfur-rev3.dts >>>>>>>>>> create mode 100644 arch/arm/boot/dts/zynq-ni-sulfur-rev4.dts >>>>>>>>>> create mode 100644 arch/arm/boot/dts/zynq-ni-sulfur.dtsi >>>>>>>>> >>>>>>>>> Is this publicly available board? >>>>>>>> >>>>>>>> Will be in Q1 2018 was announced at GRCon'17 ([1]). >>>>>>>> Some of the Rev3s are currently deployed in Norway as part of a radar >>>>>>>> system. >>>>>>>> >>>>>>>>> I am not quite sure we should apply these dts files. There are a lot of >>>>>>>>> boards with zynq and there must be any strong argument for applying this >>>>>>>>> to the tree. For arm32 with even flat tree structure. >>>>>>>> >>>>>>>> What's the issue with merging them, except for having 3 more files? >>>>>>> >>>>>>> For me this is not a problem because on Linux side it is not increasing >>>>>>> build time. >>>>>>> I want to see the value for community. All xilinx platforms are >>>>>>> evaluation generic purpose boards which are showing how to connect stuff >>>>>>> together. >>>>>>> On the other hand this is real product. >>>>>> >>>>>> Uh. >>>>>> >>>>>>> I would let arm-soc maintainer to decide if this is fine or not. I >>>>>>> definitely don't want to end up in situation that we will have dts for >>>>>>> real products which are not bringing any value for others. >>>>>> >>>>>> Sure, it's the maintainers call. >>>>>> >>>>>> I do intend to have my customers run mainline on it eventually, currently >>>>>> I'm a handful of patches away from making that happen. So yes, running >>>>>> mainline is a usecase that matters to me. >>>>>> >>>>>> It is one thing to keep bitching about vendor kernels as a community >>>>>> continuously, but then if someone goes through the effort and actually >>>>>> tries to run mainline, you give them crap like that above. >>>>>> >>>>>> Our products usually come with full schematics [1], firmware, fpga code and all >>>>>> available, I don't know what makes them less useful to the community as a >>>>>> platform to experiment and develop on than Xilinx eval boards. >>>>>> >>>>>> There's several people that I know of both hobbyists and companies that >>>>>> build systems around these platforms, so I don't know ... >>>>> >>>>> I expect this product to be delivered with full source and a mainline >>>>> kernel, so lets make it easy for Moritz to do the right thing here. This >>>>> makes long term support of this product much easier. >>>>> >>>>> Acked-by: Philip Balister >>>> >>>> I think this is the right way to go. Get ACK from Arnd or Olof or Kevin >>>> and I will merge this. >>>> I am simply just afraid that if a lot of zynq customers will ask for it >>>> we can will end up with a lot of zynq/zynqmp based dts files in the >>>> kernel and arm-soc guys will stop this that it is simply too much and >>>> won't accept +1 case. >>> >>> I share the same concerns. Unfortunately, there doesn't seem like any >>> other structured way to manage dts files. >>> >>> As an OpenEmbedded guy, I know I can carry them with BSP's, but not >>> everyone uses OpenEmbedded. I'd love to see a long term scalable >>> solution for tracking dts files, but that is outside the scope of >>> Moritz's request. >> >> Are you guys coming to ELCE? There will be Devicetree Workshop which >> will be good place to talk about this. > > Yeah, it's on Thursday, right? Yep Thursday but no exact time yet. M