From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752224AbdK1MrU (ORCPT ); Tue, 28 Nov 2017 07:47:20 -0500 Received: from mail-sh2.amlogic.com ([58.32.228.45]:13831 "EHLO mail-sh2.amlogic.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751675AbdK1MrS (ORCPT ); Tue, 28 Nov 2017 07:47:18 -0500 Subject: Re: [PATCH v2 0/2] add clk controller driver for Meson-AXG SoC To: Jerome Brunet , Neil Armstrong , Kevin Hilman References: <20171127094844.16742-1-yixun.lan@amlogic.com> <1511790489.30519.11.camel@baylibre.com> CC: , Rob Herring , Mark Rutland , Michael Turquette , Stephen Boyd , Carlo Caione , Qiufang Dai , , , , , From: Yixun Lan Message-ID: <78b268eb-6aff-a9c4-e358-f91069e12da5@amlogic.com> Date: Tue, 28 Nov 2017 20:47:09 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1 MIME-Version: 1.0 In-Reply-To: <1511790489.30519.11.camel@baylibre.com> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [58.34.187.116] X-ClientProxiedBy: mail-sh2.amlogic.com (10.18.11.6) To mail-sh2.amlogic.com (10.18.11.6) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi jerome: On 11/27/17 21:48, Jerome Brunet wrote: > On Mon, 2017-11-27 at 17:48 +0800, Yixun Lan wrote: >> Add driver for the clk controller which found in Meson AXG SoC >> >> Note, we deliberately create a seperate source file for the Meson AXG >> series, instead of sharing code with previous GXBB/GXL - the file axg.c >> It would help us maintaining the code more easily. > > But this will be the last meson SoC added this way. We need factor the code the > between meson8, gx and axg series since there is a lot of duplication there. > >> >> Changes since v1 [1]: >> - rework register definion, use '(offset << 2)' to better match > > As previously discussed, please drop these calculations and just write what the > offset actually are. Putting one comment at the top, explaining the translation, > would be nice though. > can drop the calculations, but there is already a comment at top here.. >> the description from data sheet >> - drop "#include dt-bindings/clock/gxbb-aoclkc.h" from dts >> - rebase code to v4.15-rc1 >> >> [1] >> http://lists.infradead.org/pipermail/linux-amlogic/2017-November/005239.html >> http://lists.infradead.org/pipermail/linux-amlogic/2017-November/005240.html >> http://lists.infradead.org/pipermail/linux-amlogic/2017-November/005241.html >> >> >> Qiufang Dai (2): > > First patch of the series should be adding the compatible documentation, which > is missing here (unless it has gone through another channel and I missed it) > I missed the dt-binding, will fix in next version >> clk: meson-axg: add clock controller drivers >> arm64: dts: meson-axg: add clock DT info for Meson AXG SoC >> >> arch/arm64/Kconfig.platforms | 1 + >> arch/arm64/boot/dts/amlogic/meson-axg.dtsi | 15 + >> drivers/clk/meson/Kconfig | 8 + >> drivers/clk/meson/Makefile | 1 + >> drivers/clk/meson/axg.c | 948 >> +++++++++++++++++++++++++++++ >> drivers/clk/meson/axg.h | 126 ++++ >> include/dt-bindings/clock/axg-clkc.h | 72 +++ >> 7 files changed, 1171 insertions(+) >> create mode 100644 drivers/clk/meson/axg.c >> create mode 100644 drivers/clk/meson/axg.h >> create mode 100644 include/dt-bindings/clock/axg-clkc.h >> > > . >