From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753232AbdEPPwU (ORCPT ); Tue, 16 May 2017 11:52:20 -0400 Received: from mout.web.de ([212.227.17.12]:65057 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751547AbdEPPwF (ORCPT ); Tue, 16 May 2017 11:52:05 -0400 Subject: [PATCH 1/3] s390: virtio: Delete error messages for failed memory allocations in two functions From: SF Markus Elfring To: kvm@vger.kernel.org, linux-s390@vger.kernel.org, virtualization@lists.linux-foundation.org, Cornelia Huck , Halil Pasic , Heiko Carstens , Martin Schwidefsky Cc: LKML , kernel-janitors@vger.kernel.org, Wolfram Sang References: Message-ID: <78b6667b-69c4-39c5-7e1b-1b69ae983695@users.sourceforge.net> Date: Tue, 16 May 2017 17:51:57 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:9LQoUYAArrqkRzaTbMULxVAWyJbrNme0iK/gNlL0MOfDDH5F2eG vKmKdXlSGZxtSCbyRRchRR3tTQnk1WFrvnr+c7JHA8IP6MzC3wL22xzMGPa+75J712ylO1g 4qQ4AGaxh1ump8cWOPSi29L6C/J9W/IQqyDqAIqg1o+Pr8Wk/0XnS6rB8mTFpN5nGPINU1l SfUe0dWe24D4h8xjYClQw== X-UI-Out-Filterresults: notjunk:1;V01:K0:t/4PSTkkRqI=:aJQOpuDMvGAkcSRtQpHNsS VZrqeJKfpdY5BN1YClttJw9iy+ueIGVNQAiuF2hzdXM+EIhp2p9KE+9Xmh5VOelB9zXWHkX9i NUbETVYExyDUXMvtix9bx1SEktWrUS5iHRRLsYswfTJG9aLaPZU3SCHP1HxfoYfX25RWRMHVe 07ZQCoPCvq+5EmTeJO4vN9vkxt2D0gtigiUQ1b879L4wwrb375V4W6WGOBYdnYEa1rzS410V0 1KWMmpUoFZvahLyvPYbsAmzV1k0JXOKfn6+dJLeC0x37pALxGNASQLO0Hg+7k20D8267lL6kh MLfcFzZu0oZ+RGw9n87KxWxpv86NnzkoSBHhUF15SDlGjI6JHmR3rD+PPzGY/5D58HNAknM++ 7cqGPZYYqGEvhVtF0/uJnr1Ie4d5fzdRWOlQRifnQc8XQwuqy8dHuxnvioPVufytIkKKvtz6V zyOnSZ1UseFNd89SX5hT+p+wdKDbA3i69UBbK1oQNReRYKLUqTrTSd/qNX1J+EdEGW3KA/5Mk j1bMhF3EkkCVEH1XUYY9hNmVAZD+vgFkX09p3sVYg6Vmd0yjiz850TJt+YwV462UXVcUI62tw psQcLPCRL4h1DpREAXmNa1YY6RVKrqm1OkAdiPaTwl9zLocAWgw5Tr237fBjHMCshWqPfsM/c 0+SaLlC6oCNH0A4d3eyPF5u+zqGSShLDwUYNUHkjnwo44tc6A8zqib1vDdwJ1N7jWN5ZE+eRs z43BNZJI7GPPZPZUZeuNxpcjNiGORWCwDHJPzW5vGVztj+dJJXxwXZAIOpLMOgZjnHmkr6jvg ywomPZJ Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Tue, 16 May 2017 16:50:17 +0200 Omit three extra messages for memory allocation failures in these functions. This issue was detected by using the Coccinelle software. Link: http://events.linuxfoundation.org/sites/events/files/slides/LCJ16-Refactor_Strings-WSang_0.pdf Signed-off-by: Markus Elfring --- drivers/s390/virtio/virtio_ccw.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/s390/virtio/virtio_ccw.c b/drivers/s390/virtio/virtio_ccw.c index 2a76ea78a0bf..447fe718c0ab 100644 --- a/drivers/s390/virtio/virtio_ccw.c +++ b/drivers/s390/virtio/virtio_ccw.c @@ -499,12 +499,10 @@ static struct virtqueue *virtio_ccw_setup_vq(struct virtio_device *vdev, if (!info) { - dev_warn(&vcdev->cdev->dev, "no info\n"); err = -ENOMEM; goto out_err; } info->info_block = kzalloc(sizeof(*info->info_block), GFP_DMA | GFP_KERNEL); if (!info->info_block) { - dev_warn(&vcdev->cdev->dev, "no info block\n"); err = -ENOMEM; goto out_err; } @@ -1225,7 +1223,6 @@ static int virtio_ccw_online(struct ccw_device *cdev) vcdev = kzalloc(sizeof(*vcdev), GFP_KERNEL); if (!vcdev) { - dev_warn(&cdev->dev, "Could not get memory for virtio\n"); ret = -ENOMEM; goto out_free; } -- 2.13.0