From: Nikolay Aleksandrov <razor@blackwall.org>
To: Sevinj Aghayeva <sevinj.aghayeva@gmail.com>, netdev@vger.kernel.org
Cc: "David S. Miller" <davem@davemloft.net>,
aroulin@nvidia.com, sbrivio@redhat.com, roopa@nvidia.com,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
linux-kernel@vger.kernel.org, bridge@lists.linux-foundation.org
Subject: Re: [PATCH RFC net-next 0/5] net: vlan: fix bridge binding behavior and add selftests
Date: Tue, 20 Sep 2022 12:16:26 +0300 [thread overview]
Message-ID: <78bd0e54-4ee3-bd3c-2154-9eb8b9a70497@blackwall.org> (raw)
In-Reply-To: <cover.1663445339.git.sevinj.aghayeva@gmail.com>
On 17/09/2022 23:17, Sevinj Aghayeva wrote:
> When bridge binding is enabled for a vlan interface, it is expected
> that the link state of the vlan interface will track the subset of the
> ports that are also members of the corresponding vlan, rather than
> that of all ports.
>
> Currently, this feature works as expected when a vlan interface is
> created with bridge binding enabled:
>
> ip link add link br name vlan10 type vlan id 10 protocol 802.1q \
> bridge_binding on
>
> However, the feature does not work when a vlan interface is created
> with bridge binding disabled, and then enabled later:
>
> ip link add link br name vlan10 type vlan id 10 protocol 802.1q \
> bridge_binding off
> ip link set vlan10 type vlan bridge_binding on
>
> After these two commands, the link state of the vlan interface
> continues to track that of all ports, which is inconsistent and
> confusing to users. This series fixes this bug and introduces two
> tests for the valid behavior.
>
> Sevinj Aghayeva (5):
> net: core: export call_netdevice_notifiers_info
> net: core: introduce a new notifier for link-type-specific changes
> net: 8021q: notify bridge module of bridge-binding flag change
> net: bridge: handle link-type-specific changes in the bridge module
> selftests: net: tests for bridge binding behavior
>
> include/linux/if_vlan.h | 4 +
> include/linux/netdevice.h | 3 +
> include/linux/notifier_info.h | 21 +++
> net/8021q/vlan.h | 2 +-
> net/8021q/vlan_dev.c | 20 ++-
> net/bridge/br.c | 5 +
> net/bridge/br_private.h | 7 +
> net/bridge/br_vlan.c | 18 +++
> net/core/dev.c | 7 +-
> tools/testing/selftests/net/Makefile | 1 +
> .../selftests/net/bridge_vlan_binding_test.sh | 143 ++++++++++++++++++
> 11 files changed, 223 insertions(+), 8 deletions(-)
> create mode 100644 include/linux/notifier_info.h
> create mode 100755 tools/testing/selftests/net/bridge_vlan_binding_test.sh
>
The set looks good to me, the bridge and vlan direct dependency is gone and
the new notification type is used for passing link type specific info.
If the others are ok with it I think you can send it as non-RFC, but I'd give it
a few more days at least. :)
Thanks,
Nik
next prev parent reply other threads:[~2022-09-20 9:16 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-17 20:17 Sevinj Aghayeva
2022-09-17 20:17 ` [PATCH RFC net-next 1/5] net: core: export call_netdevice_notifiers_info Sevinj Aghayeva
2022-09-17 20:17 ` [PATCH RFC net-next 2/5] net: core: introduce a new notifier for link-type-specific changes Sevinj Aghayeva
2022-09-17 20:17 ` [PATCH RFC net-next 3/5] net: 8021q: notify bridge module of bridge-binding flag change Sevinj Aghayeva
2022-09-17 20:18 ` [PATCH RFC net-next 4/5] net: bridge: handle link-type-specific changes in the bridge module Sevinj Aghayeva
2022-09-30 13:11 ` [net] f6390526ee: WARNING:at_net/core/dev.c:#unregister_netdevice_many kernel test robot
2022-09-17 20:18 ` [PATCH RFC net-next 5/5] selftests: net: tests for bridge binding behavior Sevinj Aghayeva
2022-09-20 9:16 ` Nikolay Aleksandrov [this message]
2022-09-20 23:29 ` [PATCH RFC net-next 0/5] net: vlan: fix bridge binding behavior and add selftests Jakub Kicinski
2022-09-21 4:45 ` Nikolay Aleksandrov
2022-09-21 12:42 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=78bd0e54-4ee3-bd3c-2154-9eb8b9a70497@blackwall.org \
--to=razor@blackwall.org \
--cc=aroulin@nvidia.com \
--cc=bridge@lists.linux-foundation.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=roopa@nvidia.com \
--cc=sbrivio@redhat.com \
--cc=sevinj.aghayeva@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®