From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from fout-a5-smtp.messagingengine.com (fout-a5-smtp.messagingengine.com [103.168.172.148]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 09B99262BD for ; Fri, 2 Jan 2026 09:35:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=103.168.172.148 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767346516; cv=none; b=EIjIWlQZnnDo3v5JqWud+6sVJvY2qEhFsKAP7tSnpBFAjcQpUBXt48HfRU36iTXpFx+geqVY6wifWIyIgVJ8VFnDdHSt9PqsB4W3Eic9jcczPuxEYfnXbKq7r8q+ngLXarCmmrXsT8J6xIMiZLeLjDt8F1xf46MWLrNgRqyAD08= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767346516; c=relaxed/simple; bh=s6ObBSr+hdFc0/eFmHZE106e0IIVOE62Qw8ZLI9lXFM=; h=MIME-Version:Date:From:To:Cc:Message-Id:In-Reply-To:References: Subject:Content-Type; b=gOXh672DAbNQx400WyfqH0WSAWW2Ir6nZf7KqEk0DqNO9xGCElZj1ploPncC9paFOKCpQonPr8wMLGkhyD9JqUyLSU/NOq/a+CIOMIgKq1D0R0YaTQj99g/2ICobznpidjorYCLcoSjKPPSDCbsUNNa3HVkZWv8ywAwIWpKBzMs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arndb.de; spf=pass smtp.mailfrom=arndb.de; dkim=pass (2048-bit key) header.d=arndb.de header.i=@arndb.de header.b=PqCcxRbF; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b=BvY4CSj6; arc=none smtp.client-ip=103.168.172.148 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arndb.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arndb.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=arndb.de header.i=@arndb.de header.b="PqCcxRbF"; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="BvY4CSj6" Received: from phl-compute-04.internal (phl-compute-04.internal [10.202.2.44]) by mailfout.phl.internal (Postfix) with ESMTP id 39F47EC00BC; Fri, 2 Jan 2026 04:35:14 -0500 (EST) Received: from phl-imap-02 ([10.202.2.81]) by phl-compute-04.internal (MEProxy); Fri, 02 Jan 2026 04:35:14 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arndb.de; h=cc :cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm1; t=1767346514; x=1767432914; bh=1OUWXPe11/x8BD2MqUD+Z+GZ8DLN3/QOQxR6PexDgCI=; b= PqCcxRbFy1GQibYM3hsjMxW3Cp8zuJ30v4Zg+i+Ul89eB6AL/kl7BbepVOOULIlA BfxrtmW6ySi9s8d/zsRsg+XyxVz/uXAx+EeveXHXL4o5dr2UtGCU2CEyM3DuWaFi u6Yg+CN9Rzgqz2AahJlLAF2Dn9BUnvlYat4aKdtoUdLcNTojE/VzMSfCHWLl83zN fCzxBs129pjRg8YI7p0CWZD5sAo7/91ogF5J9rol7ClQa1CBMDrHMs8gtWbHmbaY 0Hqna2nB99YJNWbxD4N0J60D8CShh+AK1rdqOB5krT1KvexCIZSS+UlUmkz8gqMS 7Kx0tZvrPrDup6QsTaBl5A== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t=1767346514; x= 1767432914; bh=1OUWXPe11/x8BD2MqUD+Z+GZ8DLN3/QOQxR6PexDgCI=; b=B vY4CSj6bCfjlaBYPKPxjSG6zHL/H/i3yyQJSCuxaWmno0KBriPDiFupQ46TsO3FN i2sAU8BJmOjyBQp6wE+fo6QtaEqaMbKGqUK/HdgQqL/LsW9pyvOfNPe/p3+fiubU SD27HLiMWtiwh9nx6sl3/yKGZnyQxlMNpl2UksTG9bAqjUOwgnOCPFDl+snmYSb7 z4mlBtpk5dvXlrl1oQEdduFxcc8341y2w5GA5SHmTYcJp3FOlMtgaWy7o0eK8QQ1 yVyPaX0wmpC/06ZSuac9EsPVJSWk7aaS4/i78aZR1Wm1QSBUhY5ihPBgrowLBFWJ BRmJ6ZzgW0hsH15YHheZg== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeefgedrtddtgdekkeefvdcutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpuffrtefokffrpgfnqfghnecuuegr ihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenucfjug hrpefoggffhffvvefkjghfufgtgfesthejredtredttdenucfhrhhomhepfdetrhhnugcu uegvrhhgmhgrnhhnfdcuoegrrhhnugesrghrnhgusgdruggvqeenucggtffrrghtthgvrh hnpefhtdfhvddtfeehudekteeggffghfejgeegteefgffgvedugeduveelvdekhfdvieen ucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpegrrhhnug esrghrnhgusgdruggvpdhnsggprhgtphhtthhopeehpdhmohguvgepshhmthhpohhuthdp rhgtphhtthhopehkrhiikheskhgvrhhnvghlrdhorhhgpdhrtghpthhtoheplhhinhhugi dqrghrmhdqkhgvrhhnvghlsehlihhsthhsrdhinhhfrhgruggvrggurdhorhhgpdhrtghp thhtohepvhiisehmlhgvihgrrdgtohhmpdhrtghpthhtohepphhiohhtrhdrfihojhhtrg hsiigtiiihkhesthhimhgvshihshdrtghomhdprhgtphhtthhopehlihhnuhigqdhkvghr nhgvlhesvhhgvghrrdhkvghrnhgvlhdrohhrgh X-ME-Proxy: Feedback-ID: i56a14606:Fastmail Received: by mailuser.phl.internal (Postfix, from userid 501) id E32EE700065; Fri, 2 Jan 2026 04:35:13 -0500 (EST) X-Mailer: MessagingEngine.com Webmail Interface Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-ThreadId: AHOPZfDIHKu7 Date: Fri, 02 Jan 2026 10:34:33 +0100 From: "Arnd Bergmann" To: "Vladimir Zapolskiy" Cc: "Piotr Wojtaszczyk" , "Krzysztof Kozlowski" , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Message-Id: <78c18978-5c25-4931-8532-b7f7895d5a34@app.fastmail.com> In-Reply-To: <20260101235647.2411062-3-vz@mleia.com> References: <20260101235647.2411062-1-vz@mleia.com> <20260101235647.2411062-3-vz@mleia.com> Subject: Re: [PATCH 2/2] soc: nxp: Add a simple NXP LPC32xx socinfo driver Content-Type: text/plain Content-Transfer-Encoding: 7bit On Fri, Jan 2, 2026, at 00:56, Vladimir Zapolskiy wrote: > Add NXP LPC32xx specific driver to get unique SoC ID from System Control > Block registers and export it to userspace. > > Signed-off-by: Vladimir Zapolskiy This looks fine to me overall > +static int lpc32xx_soc_probe(struct platform_device *pdev) > +{ > + struct soc_device_attribute *soc_dev_attr; > + struct device *dev = &pdev->dev; > + struct soc_device *soc_dev; > + struct regmap *scb; > + u32 serial_id[4]; > + int ret; > + > + soc_dev_attr = devm_kzalloc(dev, sizeof(*soc_dev_attr), GFP_KERNEL); > + if (!soc_dev_attr) > + return -ENOMEM; > + > + soc_dev_attr->family = "NXP LPC32xx"; > + > + ret = of_property_read_string(of_root, "model", &soc_dev_attr->machine); > + if (ret) > + return ret; > + > + scb = syscon_regmap_lookup_by_compatible("nxp,lpc3220-scb"); It seems a bit odd to register a fake platform_device and then get the registers from another device. I think with the current iteration of syscon since 26769582bf35 ("mfd: syscon: Remove the platform driver support"), you should be able to just register the driver as a module_platform_driver for the "nxp,lpc3220-scb" compatible value. Have you tried that? If for some reason that doesn't work, I would drop the custom platform_device here and just merge the probe function into the module init. Arnd