From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3FEDBC433F5 for ; Thu, 20 Jan 2022 05:22:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1358582AbiATFWW (ORCPT ); Thu, 20 Jan 2022 00:22:22 -0500 Received: from alexa-out.qualcomm.com ([129.46.98.28]:55516 "EHLO alexa-out.qualcomm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1358565AbiATFWN (ORCPT ); Thu, 20 Jan 2022 00:22:13 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; i=@quicinc.com; q=dns/txt; s=qcdkim; t=1642656133; x=1674192133; h=subject:to:cc:references:from:message-id:date: mime-version:in-reply-to:content-transfer-encoding; bh=RC7Akc7VNDbVI2s3a/uiQ4kqEbvFPY3SvdY8Zv6GNSo=; b=PjXYr994rLMzikFtfBu1i46q2GELmTn1pXC/dxCQFEWA9hOrZQko1O8u BXSOXSq6iTzudkzjbsjnRgLlKYVrNBZVsWPKSCK0fnZwX3WH+DhaGwI3o 7BHiL5c28ZMMzPiNTTipovNrjFnfnjBruG6TPwrqw8cYbGR+RNCK2brJE Q=; Received: from ironmsg-lv-alpha.qualcomm.com ([10.47.202.13]) by alexa-out.qualcomm.com with ESMTP; 19 Jan 2022 21:22:12 -0800 X-QCInternal: smtphost Received: from nasanex01c.na.qualcomm.com ([10.47.97.222]) by ironmsg-lv-alpha.qualcomm.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Jan 2022 21:22:12 -0800 Received: from nalasex01a.na.qualcomm.com (10.47.209.196) by nasanex01c.na.qualcomm.com (10.47.97.222) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.922.19; Wed, 19 Jan 2022 21:22:11 -0800 Received: from [10.216.16.96] (10.80.80.8) by nalasex01a.na.qualcomm.com (10.47.209.196) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.922.19; Wed, 19 Jan 2022 21:22:07 -0800 Subject: Re: [PATCH v10 6/6] usb: dwc3: qcom: Enable the interrupts during probe To: Pavan Kondeti , Steev Klimaszewski CC: Greg Kroah-Hartman , Felipe Balbi , Stephen Boyd , Doug Anderson , Matthias Kaehlcke , Mathias Nyman , , , , References: <1642398248-21753-1-git-send-email-quic_c_sanm@quicinc.com> <1642398248-21753-7-git-send-email-quic_c_sanm@quicinc.com> <93b68251-7e7e-ac92-fb47-346c410744b2@kali.org> <20220118095255.GB11385@hu-pkondeti-hyd.qualcomm.com> From: Sandeep Maheswaram Message-ID: <78c90e46-666b-bc9b-235d-ae4c69e19929@quicinc.com> Date: Thu, 20 Jan 2022 10:52:03 +0530 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 MIME-Version: 1.0 In-Reply-To: <20220118095255.GB11385@hu-pkondeti-hyd.qualcomm.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01b.na.qualcomm.com (10.46.141.250) To nalasex01a.na.qualcomm.com (10.47.209.196) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Pavan, On 1/18/2022 3:22 PM, Pavan Kondeti wrote: > On Tue, Jan 18, 2022 at 12:12:30AM -0600, Steev Klimaszewski wrote: >> On 1/16/22 11:44 PM, Sandeep Maheswaram wrote: >>> Enable the interrupts during probe and remove the disable interrupts >>> function. >>> >>> Signed-off-by: Sandeep Maheswaram >>> --- >>> drivers/usb/dwc3/dwc3-qcom.c | 28 ++++------------------------ >>> 1 file changed, 4 insertions(+), 24 deletions(-) >>> >>> diff --git a/drivers/usb/dwc3/dwc3-qcom.c b/drivers/usb/dwc3/dwc3-qcom.c >>> index 54dc3d3..7c5e636 100644 >>> --- a/drivers/usb/dwc3/dwc3-qcom.c >>> +++ b/drivers/usb/dwc3/dwc3-qcom.c >>> @@ -306,25 +306,7 @@ static void dwc3_qcom_enable_wakeup_irq(int irq) >>> enable_irq_wake(irq); >>> } >>> -static void dwc3_qcom_disable_wakeup_irq(int irq) >>> -{ >>> - if (!irq) >>> - return; >>> - >>> - disable_irq_wake(irq); >>> - disable_irq_nosync(irq); >>> -} >>> -static void dwc3_qcom_disable_interrupts(struct dwc3_qcom *qcom) >>> -{ >>> - dwc3_qcom_disable_wakeup_irq(qcom->hs_phy_irq); >>> - >>> - dwc3_qcom_disable_wakeup_irq(qcom->dp_hs_phy_irq); >>> - >>> - dwc3_qcom_disable_wakeup_irq(qcom->dm_hs_phy_irq); >>> - >>> - dwc3_qcom_disable_wakeup_irq(qcom->ss_phy_irq); >>> -} >>> static void dwc3_qcom_enable_interrupts(struct dwc3_qcom *qcom) >>> { >>> @@ -356,9 +338,6 @@ static int dwc3_qcom_suspend(struct dwc3_qcom *qcom) >>> if (ret) >>> dev_warn(qcom->dev, "failed to disable interconnect: %d\n", ret); >>> - if (device_may_wakeup(qcom->dev)) >>> - dwc3_qcom_enable_interrupts(qcom); >>> - >>> qcom->is_suspended = true; >>> return 0; >>> @@ -372,9 +351,6 @@ static int dwc3_qcom_resume(struct dwc3_qcom *qcom) >>> if (!qcom->is_suspended) >>> return 0; >>> - if (device_may_wakeup(qcom->dev)) >>> - dwc3_qcom_disable_interrupts(qcom); >>> - >>> for (i = 0; i < qcom->num_clocks; i++) { >>> ret = clk_prepare_enable(qcom->clks[i]); >>> if (ret < 0) { >>> @@ -832,6 +808,10 @@ static int dwc3_qcom_probe(struct platform_device *pdev) >>> genpd->flags |= GENPD_FLAG_ALWAYS_ON; >>> device_init_wakeup(&pdev->dev, 1); >>> + >>> + if (device_may_wakeup(qcom->dev)) >>> + dwc3_qcom_enable_interrupts(qcom); >>> + >>> qcom->is_suspended = false; >>> pm_runtime_set_active(dev); >>> pm_runtime_enable(dev); >> Hi Sandeep, >> >> I was testing this series on my Lenovo Yoga C630, and with this patch in >> particular applied, my system will no longer boot. Unfortunately I don't get >> any sort of good output at all, I just get hung tasks when trying to probe >> things it would seem. >> >> >> With the other 5 patches in the series applied, the system still boots and >> works correctly. >> >> > Sandeep, > > Enable DP/DM interrupts all the time might be creating a storm of interrupts. > calling enable_irq_wake() during probe is okay, but not the enable_irq(). > > Did you verify your change with a Highspeed/Fullspeed device connected? > > Thanks, > Pavan I didn't face any such issue with devices connected. I think this is because I used IRQ_TYPE_EDGE_BOTH in device tree and Steev has IRQ_TYPE_LEVEL_HIGH in his device tree. When i changed to IRQ_TYPE_LEVEL_HIGH I also observed a storm of interrupts in my device though it booted . Regards Sandeep