From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtpout-03.galae.net (smtpout-03.galae.net [185.246.85.4]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EFE1B43CE6A for ; Thu, 1 Oct 2026 08:03:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.246.85.4 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790841790; cv=none; b=Asc3HMxQm5JG/nIXHGVf/3RaKWs9Os4fW518Pr5ni9kWUA/J1tTla+Z/pk/lHG6+22wT59SeVWdXKO1QafET1Pd9VV/DaOkUZqGpiTJ/hSUy+P0BHPuw+TBAeqtXQ/GymKV9OaSnR+wt7wliNyr6VBec75T0JgU8pUUfa+VCb/A= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790841790; c=relaxed/simple; bh=KWtWUyO5e31E29X7kJUK67PTu3io/akqw94hdUPa2/A=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=ZfPbw82+SMl4VqC2Ucs1o8tErtdtm9cs79zp/Stx23p21dgbWbFdcElh7lG36klkI0mrJsw9yLs5/JOh3N2aaQA2KvHow9RR86k0BzOdGjrIi8ansddxbsOEbmSLR04s99cbA/XKLVsj1cjJughvi6oibinUtcIyiRGv8UzrVRA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=MG5n5IPR; arc=none smtp.client-ip=185.246.85.4 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="MG5n5IPR" Received: from smtpout-01.galae.net (smtpout-01.galae.net [212.83.139.233]) by smtpout-03.galae.net (Postfix) with ESMTPS id 3F5F04E410EE; Thu, 1 Oct 2026 08:03:05 +0000 (UTC) Received: from mail.galae.net (mail.galae.net [212.83.136.155]) by smtpout-01.galae.net (Postfix) with ESMTPS id 0CAAB60341; Thu, 1 Oct 2026 08:03:05 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id 0E319103292AE; Thu, 1 Oct 2026 10:02:47 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=dkim; t=1790841779; h=from:subject:date:message-id:to:cc:mime-version:content-type: content-transfer-encoding:in-reply-to:references; bh=bBnYNPx0m93XbkdYJmwrk/PdDLQ8lp47f6etNXtdmtI=; b=MG5n5IPRudGzRrmo8ILDJDWYoecFzTS0SG5Pj68X1y0b04+2YpsJIH//yybBHJhI+y+AtC 5pMeaxML0tMeFxax6tyAu+LzwoDoQ/c/Ah0PkiwYB28ckeY49nocfOg/a/WqtSABY3QZu0 5dticPDGy2Um1s2hSW0775Oluy3hNAKx+IZtru3r40kkA10tbG9o3CxLOC2vH/9reQwCaE foJ1gnJY4fZCSlBTVS3bJE4jECObDVBX9sCymzvRuZ8w7tT/lSd8l3M4NZ007dO41l1aHu L/lIqeuW8sQ6UWKOhQ374hDboAQFhi9uYFcx5erlR0oDpCFxyNKucgPpquU6yQ== Message-ID: <78ca2d861e27bb5712db12de83a199b52e5dbae5.camel@bootlin.com> Subject: Re: [PATCH v2 1/7] drm/imx/lcdc: stop using deprecated devm_drm_of_get_bridge() From: Paul Cercueil To: Luca Ceresoli , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Frank Li , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Icenowy Zheng , Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Dave Stevenson , =?ISO-8859-1?Q?Ma=EDra?= Canal , Raspberry Pi Kernel Maintenance , Geert Uytterhoeven Cc: Arnd Bergmann , Doug Anderson , Hui Pu , Ian Ray , Thomas Petazzoni , dri-devel@lists.freedesktop.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-renesas-soc@vger.kernel.org Date: Thu, 01 Oct 2026 10:02:45 +0200 In-Reply-To: <20260929-drm-fix-of_get_bridge-build-regression-v2-1-6da431d8f180@bootlin.com> References: <20260929-drm-fix-of_get_bridge-build-regression-v2-0-6da431d8f180@bootlin.com> <20260929-drm-fix-of_get_bridge-build-regression-v2-1-6da431d8f180@bootlin.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.56.2-0+deb13u1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Last-TLS-Session-Version: TLSv1.3 Hi Lucas, Le mardi 29 septembre 2026 =C3=A0 15:39 +0200, Luca Ceresoli a =C3=A9crit= =C2=A0: > devm_drm_of_get_bridge() is deprecated, switch to > of_drm_get_bridge_by_endpoint(). As of_drm_get_bridge_by_endpoint() retur= ns > a refcounted bridge, ensure it is put. >=20 > Fixes build failure when CONFIG_OF is disabled. >=20 > Fixes: aa8a8c7e4641 ("drm/bridge: panel: move all code to drm_panel.c") > Reported-by: Arnd Bergmann > Link: https://lore.kernel.org/r/20260928161605.2271412-1-arnd@kernel.org > Acked-by: Maxime Ripard > Signed-off-by: Luca Ceresoli Reviewed-by: Paul Cercueil Cheers, -Paul > --- > =C2=A0drivers/gpu/drm/imx/lcdc/imx-lcdc.c | 4 ++-- > =C2=A01 file changed, 2 insertions(+), 2 deletions(-) >=20 > diff --git a/drivers/gpu/drm/imx/lcdc/imx-lcdc.c > b/drivers/gpu/drm/imx/lcdc/imx-lcdc.c > index c67fe80b8115..805a659e3f85 100644 > --- a/drivers/gpu/drm/imx/lcdc/imx-lcdc.c > +++ b/drivers/gpu/drm/imx/lcdc/imx-lcdc.c > @@ -385,7 +385,6 @@ static int imx_lcdc_probe(struct platform_device *pde= v) > =C2=A0{ > =C2=A0 struct imx_lcdc *lcdc; > =C2=A0 struct drm_device *drm; > - struct drm_bridge *bridge; > =C2=A0 int irq; > =C2=A0 int ret; > =C2=A0 struct device *dev =3D &pdev->dev; > @@ -401,7 +400,8 @@ static int imx_lcdc_probe(struct platform_device *pde= v) > =C2=A0 if (IS_ERR(lcdc->base)) > =C2=A0 return dev_err_probe(dev, PTR_ERR(lcdc->base), "Cannot get IO > memory\n"); > =C2=A0 > - bridge =3D devm_drm_of_get_bridge(dev, dev->of_node, 0, 0); > + struct drm_bridge *bridge __free(drm_bridge_put) =3D > + of_drm_get_bridge_by_endpoint(dev->of_node, 0, 0); > =C2=A0 if (IS_ERR(bridge)) > =C2=A0 return dev_err_probe(dev, PTR_ERR(bridge), "Failed to find > bridge\n"); > =C2=A0