From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 02BCA3BFE59 for ; Tue, 17 Mar 2026 12:31:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773750721; cv=none; b=FGmQICBtOSMVxU0Fnil5hpdrPrjANnxxMupnzumtdaj4FDH44MbWvcgjs5675+uqnCnbARBISk6lSmV4ofBIby7oTnfqye4BzgBgXKvyUb8iAZCnjAAVmkF+Adx810JRmGUL35FjC4/Cn+V2YeLCR56FRIKckoP4AZZQaIILUBU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773750721; c=relaxed/simple; bh=1jQ0Io1F3tQLKlbPYrvOiyY2JRwu/1WgFSk5RLQLW9c=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=JFyjgaAO2zOZYbQU+SASWK7HRCPAOQs5absZ4bp1/eQAREY2ukK33URgnpbrzR9aq3iJkpnQRbK0PhriW0hdyF+GsD2VaiPXHX0MZWPHBYIR4LSVApDG3O4udWX39FkImHtSffQ+UfFjebEAt4UF2GOsmNkoeilPWtD0qHGJfIE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=Te8jkm00; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=Adrdg2Xt; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="Te8jkm00"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="Adrdg2Xt" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1773750719; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=2iZiUbcHQjwJ43FxZPCYpG6wLuTswJ/Obh68aZ9hETE=; b=Te8jkm00TnPyEpXJVNEg0KxUxzHQIbEsonlq4p807udN0dclgVBXpacCW3bsBrY8l61BPG OBTgUrG411ngaBHigzGMMI/dZQXUw7PJk3jymg8B2rhdFr0zJg/H0ROdWLy7RuIS8jLjNo 80Y9s6QN4Ia4qlGxmXP8oCroQFZayoU= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-361-v2q0jYSxOAugP9uKKruFNQ-1; Tue, 17 Mar 2026 08:31:57 -0400 X-MC-Unique: v2q0jYSxOAugP9uKKruFNQ-1 X-Mimecast-MFC-AGG-ID: v2q0jYSxOAugP9uKKruFNQ_1773750717 Received: by mail-wr1-f72.google.com with SMTP id ffacd0b85a97d-439a9182148so3879699f8f.2 for ; Tue, 17 Mar 2026 05:31:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1773750716; x=1774355516; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=2iZiUbcHQjwJ43FxZPCYpG6wLuTswJ/Obh68aZ9hETE=; b=Adrdg2Xt/M212XjH+j/vIQnluu0qezxPVvwt24uFZxVbz/ELT3KdZDsBqKK6EgJqGT 6e+ws63SinWIRzbp1tB424g0Pdn+ToHsE08wsPoEFg99q7e/LuZADMzOaO+CRmfrtrZx BB0tzbCyACOQ2unq7VmF+66rUF53mGCVGnVEscexeJhLnBWCVh9mXq6OCK1Fk8Pp9V5B STAYnF8gUafCW8m5F5XuGAuBkzaj/cv5ywlW6orOXd9cNIQlcRfReXrCIuFeuaChg7yx /ZT7djXczXVcj0P5XqDFWGnoKjHGUuguzfJG7uGzwITjMv6I7io04VFUmSkJPMJqcyoo 2Rsw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773750716; x=1774355516; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=2iZiUbcHQjwJ43FxZPCYpG6wLuTswJ/Obh68aZ9hETE=; b=JVS/qLcMmzYXYGZhWTi53dNV0RJqnbLp/KUf9ET351jHbZMDT9XgS0WANJwRb9lh8r u7n3iPJdMcjTFrv0/bi+T93O3Cd7XJeLEo0c4LnU4Ua9ylBdFpSJGFQgcco5Qko43Rhe 0/6Kq99gOQCLxlVbhVoRJlODP6xXPdlbk6aqoTRQZ5C+sO1+e72RPqDsuDV3O7tNixEA n99DLrKjnWC52POAw3zpQhxijeYAQL1EHTDQEJb54eOxZ40qPXlZzWz9BMOVGwFmE+Zo wdwi7PlATuzXce/BX1SoqWLBqayTHAiOs/RQ5Tgz+RXO8wRwmJELLlabuyEhpnAk/dWZ AQZQ== X-Forwarded-Encrypted: i=1; AJvYcCULHDM7sdY27QJFxaRkiazMwXAldi6N/HwsF3Q0eodGrFsyhrskcwOsXoWpoN9yM6hLouo4C/gpJbhMVp8=@vger.kernel.org X-Gm-Message-State: AOJu0Ywhvja6ffEBLI2fvqmyOhXdOifbBmDF6Oe1jewbhJqzNNH5nTfe JxA1zKmwSzjMUixc1QdIfIscxYL1c4it4vWJaUQUh/GZyUEQW3WGKM6wuN3GD47n6TS8o8V9WT4 5Z5i2eN9hhe4almVfuIwEeMF3oaTDQPi2UVSM71jrUAqq4Py6EIIGuQBLKjU5YKJ1tQ== X-Gm-Gg: ATEYQzy3UqqjEIU0Zh92g4PcE8ZKLt7RsVXOzChdvGK1AjNcytJjsed51uENwXC7Vg1 bFsBYRU9BX7fqTXXDIgx9H4pB1P6lx3L1cEc1VF+8oJuHPc5Nie6jFfLTQJ44DsiukZUyAf90pf K+kjDVUFAjBntoPlPiKg8wQ+kEEfPaCItxkRhTBkwGjnRDsvXOREHwM2HxuePZ7OmDtY/i9AvV6 lRlahmRZcxqfdYVk8kUZUn7X0jSA6z5QKtJXqG6IV27aJ2+tDJIj1xnob454slxql7PJ9O36+QR wvVRpbf8lD49qpo2DxEFU0H2hGiAofCBiXsHVYe78S41/KWz52qwIy+nvjxiHdHUlPm1TsGrF18 3iMDy6XR6+atgr/p8QuseuJ4IDXFvdGREYQKfA8ZgePe1BRIlK69xhUs= X-Received: by 2002:a05:6000:2882:b0:439:b636:1fa4 with SMTP id ffacd0b85a97d-43a04dcbd70mr30274988f8f.48.1773750716419; Tue, 17 Mar 2026 05:31:56 -0700 (PDT) X-Received: by 2002:a05:6000:2882:b0:439:b636:1fa4 with SMTP id ffacd0b85a97d-43a04dcbd70mr30274922f8f.48.1773750715932; Tue, 17 Mar 2026 05:31:55 -0700 (PDT) Received: from [192.168.88.32] ([216.128.11.95]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-439fe20bd9csm50468510f8f.21.2026.03.17.05.31.54 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 17 Mar 2026 05:31:55 -0700 (PDT) Message-ID: <78cc0556-7986-49dc-b7df-0a0d789a3fc0@redhat.com> Date: Tue, 17 Mar 2026 13:31:54 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net-next v3 0/3] Initial support for PIC64-HPSC/HX Ethernet endpoint To: =?UTF-8?Q?Th=C3=A9o_Lebrun?= , Charles Perry , netdev@vger.kernel.org Cc: Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Nicolas Ferre , Claudiu Beznea , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260313140610.3681752-1-charles.perry@microchip.com> Content-Language: en-US From: Paolo Abeni In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On 3/16/26 6:28 PM, Théo Lebrun wrote: > On Fri Mar 13, 2026 at 3:06 PM CET, Charles Perry wrote: >> Hello, >> >> This series add basic support for Microchip "PIC64-HPSC" and "PIC64HX" >> Ethernet endpoint. Both SoCs contain 4 GEM IP with support for >> MII/RGMII/SGMII/USXGMII at rates of 10M to 10G. Only RGMII and SGMII at a >> rate of 1G is tested for now. Each GEM IP has 8 priority queues and the >> revision register reads 0x220c010e. > > Do you have plans to test higher rate? We might get our hands on GEMs > that support >1G and would like to know if CCing you would make sense. > >> One particularity of this instantiation of GEM is that the MDIO controller >> within the GEM IP is disconnected from any physical pin and the SoC rely on >> another standalone MDIO controller. > > Ah, that means you instantiate the MDIO bus for no good reason. > Code looks like: > > static int macb_mii_init(struct macb *bp) > { > struct device_node *mdio_np, *np = bp->pdev->dev.of_node; > int err = -ENXIO; > > /* With fixed-link, we don't need to register the MDIO bus, > * except if we have a child named "mdio" in the device tree. > * In that case, some devices may be attached to the MACB's MDIO bus. > */ > mdio_np = of_get_child_by_name(np, "mdio"); > if (!mdio_np && of_phy_is_fixed_link(np)) > return macb_mii_probe(bp->dev); > > // ... probe MDIO bus ... > } > > So to *not* get the bus we need to be in fixed link config. Do you care > about that? I think that the proper fix would be to lazy probe the MDIO > bus until a PHY (ours or some other MAC's) asks for it. I think that even this one could be a follow-up patch. Thanks, Paolo