From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C955CC43387 for ; Wed, 2 Jan 2019 18:28:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A9A9121871 for ; Wed, 2 Jan 2019 18:28:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727954AbfABS17 (ORCPT ); Wed, 2 Jan 2019 13:27:59 -0500 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:51218 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725993AbfABS16 (ORCPT ); Wed, 2 Jan 2019 13:27:58 -0500 Received: from pps.filterd (m0098393.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.22/8.16.0.22) with SMTP id x02IRnop135342 for ; Wed, 2 Jan 2019 13:27:57 -0500 Received: from e06smtp04.uk.ibm.com (e06smtp04.uk.ibm.com [195.75.94.100]) by mx0a-001b2d01.pphosted.com with ESMTP id 2ps2928rnr-1 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NOT) for ; Wed, 02 Jan 2019 13:27:52 -0500 Received: from localhost by e06smtp04.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Wed, 2 Jan 2019 18:26:23 -0000 Received: from b06cxnps4074.portsmouth.uk.ibm.com (9.149.109.196) by e06smtp04.uk.ibm.com (192.168.101.134) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; (version=TLSv1/SSLv3 cipher=AES256-GCM-SHA384 bits=256/256) Wed, 2 Jan 2019 18:26:20 -0000 Received: from d06av22.portsmouth.uk.ibm.com (d06av22.portsmouth.uk.ibm.com [9.149.105.58]) by b06cxnps4074.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id x02IQJCp2163040 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Wed, 2 Jan 2019 18:26:19 GMT Received: from d06av22.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 139574C040; Wed, 2 Jan 2019 18:26:19 +0000 (GMT) Received: from d06av22.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 947604C044; Wed, 2 Jan 2019 18:26:18 +0000 (GMT) Received: from [9.152.224.140] (unknown [9.152.224.140]) by d06av22.portsmouth.uk.ibm.com (Postfix) with ESMTP; Wed, 2 Jan 2019 18:26:18 +0000 (GMT) Reply-To: pmorel@linux.ibm.com Subject: Re: [PATCH v5 10/15] KVM: s390: add functions to (un)register GISC with GISA From: Pierre Morel To: Michael Mueller , KVM Mailing List Cc: Linux-S390 Mailing List , linux-kernel@vger.kernel.org, kvm390-list@tuxmaker.boeblingen.de.ibm.com, Martin Schwidefsky , Heiko Carstens , Christian Borntraeger , Janosch Frank , David Hildenbrand , Cornelia Huck , Halil Pasic References: <20181219191756.57973-1-mimu@linux.ibm.com> <20181219191756.57973-11-mimu@linux.ibm.com> Date: Wed, 2 Jan 2019 19:26:18 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-TM-AS-GCONF: 00 x-cbid: 19010218-0016-0000-0000-0000023EA6A4 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 19010218-0017-0000-0000-00003297ACB5 Message-Id: <78ce8dfa-1346-f133-de90-7ac5ed7fe008@linux.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:,, definitions=2019-01-02_07:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1901020163 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 02/01/2019 18:29, Pierre Morel wrote: > On 19/12/2018 20:17, Michael Mueller wrote: >> Add the IAM (Interruption Alert Mask) to the architecture specific >> kvm struct. This mask in the GISA is used to define for which ISC >> a GIB alert can be issued. >> >> The functions kvm_s390_gisc_register() and kvm_s390_gisc_unregister() >> are used to (un)register a GISC (guest ISC) with a virtual machine and >> its GISA. >> >> Upon successful completion, kvm_s390_gisc_register() returns the >> ISC to be used for GIB alert interruptions. A negative return code >> indicates an error during registration. >> >> Theses functions will be used by other adapter types like AP and PCI to >> request pass-through interruption support. >> >> Signed-off-by: Michael Mueller >> --- >>   arch/s390/include/asm/kvm_host.h |  9 ++++++ >>   arch/s390/kvm/interrupt.c        | 66 >> ++++++++++++++++++++++++++++++++++++++++ >>   2 files changed, 75 insertions(+) >> >> diff --git a/arch/s390/include/asm/kvm_host.h >> b/arch/s390/include/asm/kvm_host.h >> index 0deba3ae8bc7..2c1259da3636 100644 >> --- a/arch/s390/include/asm/kvm_host.h >> +++ b/arch/s390/include/asm/kvm_host.h >> @@ -782,6 +782,9 @@ struct kvm_s390_gisa { >>               u8  reserved03[11]; >>               u32 airq_count; >>           } g1; >> +        struct { >> +            u64 word[4]; >> +        } u64; >>       }; >>   }; >> @@ -849,6 +852,9 @@ struct kvm_arch{ >>       DECLARE_BITMAP(cpu_feat, KVM_S390_VM_CPU_FEAT_NR_BITS); >>       struct kvm_s390_gisa *gisa; >>       int gib_in_use; >> +    u8 iam; >> +    u32 iam_ref_count[MAX_ISC + 1]; >> +    spinlock_t iam_ref_lock; >>   }; >>   #define KVM_HVA_ERR_BAD        (-1UL) >> @@ -882,6 +888,9 @@ void kvm_arch_crypto_set_masks(struct kvm *kvm, >> unsigned long *apm, >>   extern int sie64a(struct kvm_s390_sie_block *, u64 *); >>   extern char sie_exit; >> +extern int kvm_s390_gisc_register(struct kvm *kvm, u32 gisc); >> +extern int kvm_s390_gisc_unregister(struct kvm *kvm, u32 gisc); >> + >>   static inline void kvm_arch_hardware_disable(void) {} >>   static inline void kvm_arch_check_processor_compat(void *rtn) {} >>   static inline void kvm_arch_sync_events(struct kvm *kvm) {} >> diff --git a/arch/s390/kvm/interrupt.c b/arch/s390/kvm/interrupt.c >> index 5a54360cecfe..1cc3ad2e6c7e 100644 >> --- a/arch/s390/kvm/interrupt.c >> +++ b/arch/s390/kvm/interrupt.c >> @@ -229,6 +229,25 @@ static inline u8 int_word_to_isc(u32 int_word) >>    */ >>   #define IPM_BIT_OFFSET (offsetof(struct kvm_s390_gisa, ipm) * >> BITS_PER_BYTE) >> +static inline int set_iam(struct kvm_s390_gisa *gisa, u8 iam) >> +{ >> +    u64 word0, _word0; >> + >> +    do { >> +        word0 = READ_ONCE(gisa->u64.word[0]); >> +        /* If the GISA is in the alert list, do nothing. */ >> +        if ((u64)gisa != word0 >> 32) >> +            return -EBUSY; > > In kvm_s390_gisa_clear() you do: > > +        nullify_gisa(kvm->arch.gisa); > +        set_iam(kvm->arch.gisa, kvm->arch.iam); > > IIUC this call to set_iam() will always fail. Hum, sorry, I oversaw a patch which corrected this problem. Sorry for the noise. (I should have seen it since I copied the right lines!) Regards, Pierre -- Pierre Morel Linux/KVM/QEMU in Böblingen - Germany