From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ot1-f41.google.com (mail-ot1-f41.google.com [209.85.210.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 959FA33DED1 for ; Mon, 22 Jun 2026 16:59:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.41 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782147562; cv=none; b=bG9nMkSPNo98uFfbIlk/u2uqi6FSQouB0DrZi9z/twBnlRQcnumsOVK48ZVeqMySUWVHc9GVV62O0VDAx8adbVBxzIYC4e+YLQNqJyWP/PEo3DIacOeIZQ0J6dDqISFqmwtRKhifG7DqtTzBH8tq0l1gw0/eGmjVY3zFRLHsEME= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782147562; c=relaxed/simple; bh=VwLgvQ79ZYX2f+aOk6E45c43BgvC+vyBko2Cz5vJ+KQ=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=TDfsOH5YI8WM0pOFrWAIV4tU/T32CxBchC/ypong5nbO79pZBMKRrJ7q+/01BbAyKIyZjCQSE5G/hCkFWKDO6zTBWDSdftZ4EgrmTu4VZreGzdClrFR19Bo7G1HlZGmuDHby5DA4E2GHpgFXYDKSfIiceRe2M7q3+EHbHOj2UBo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre.com header.i=@baylibre.com header.b=A7SEhHJ3; arc=none smtp.client-ip=209.85.210.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre.com header.i=@baylibre.com header.b="A7SEhHJ3" Received: by mail-ot1-f41.google.com with SMTP id 46e09a7af769-7e92c443cbcso2452815a34.0 for ; Mon, 22 Jun 2026 09:59:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre.com; s=google; t=1782147559; x=1782752359; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=LgjPu8EjLkNonMouFLLepbJvfLSQfkmj1LSsNNlmiCw=; b=A7SEhHJ3bTDgTFtOLfjzVo+enj32EmRN7j9vN8mfVTLTFBbFTQoP1NNWZLIxDMIdFf 8rGbvLK5qEA84k08RntU8Nqb6SYvzP3oV69vbQOi5nTBSypzEFWOXzlsap2nPRPuOivW VFZguAQJrr8HtWuWJf2+xmEb9zVOU/XPQ8YOKGVkIDMLIMPeFVD1Jo66alTdg6r7IUhT m8nPZyEC/6/fSYX7nhtf57t9Skt5FJjwsaV7v6zlBZhMGHdOk0x5aN2jbO8JFO3pql1A nn8rQvedogk9ksTzGl4R8QNKZexSHbw1GE1H4/pJK42pi3ZSu+S+4+KEQ59+c4RFPoAv Va1A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782147559; x=1782752359; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=LgjPu8EjLkNonMouFLLepbJvfLSQfkmj1LSsNNlmiCw=; b=KUn1unys5ELMRZkQ3PwWdd0HLgw7lTmcY3WGQn0ZW4ywDoG/CPjR94i4ET87sY0BDr 8rvrvTMCXrHnP2is/arVI0Ym0BBxw3FSotnAUJbB6pha41ctnjBdLOH262xA4IWeftpE z/qZLnrniUBVEI/Cwys/hjiG6+pOlqQ+nurRy9okZRS6DI+SidZNOUFYz9+ZV2S+RRyw nYMnNQoihOWtvZBFDHgDkrFS11/CovcCpPiCpuCgwrcBTTsTTmzf2xnyoOCzAMSwUx0T duGoKWVMNblN+85oy0wQY2oyZjOr766Ic4EgPK6wV/yAoWhUMoYC2l5GLwxvloqwIwhD fbig== X-Forwarded-Encrypted: i=1; AFNElJ9kGVuqVo22Cxp70cCX3vToIGvKtAJluE7TIS8Zp7SbgJWMxD1EoEk9y6iZHl0zqhn58iqYnY9J4jO2wTY=@vger.kernel.org X-Gm-Message-State: AOJu0YzUDXxxqI2yI/TnxB5c4qyRRQKWe0Zj2lwQ6zPk558XIPNytT50 GJl2vYXCn4nGbNxiA8RINZRUhQwWAfjZDewxFf9XCgq9gOeSQvm83d/2vPAmf7vkpB52kGEiUkf hJu+KuuM= X-Gm-Gg: AfdE7clytXVVxb90mzTEEEKnn1w058TAnqLrxTp8y9x4ieTa/SwmdJFngk4xnDh97ib /sixaWR/677zVxoSNsec32Q1iJ13FeZIAh+/e4XncZHe62ieLNRgMm255eDFPbxr3sFhyro4RDG 1QOQ3qLeIopczBe+dTzhC++PRiy+Qsq80+RI9IcGKxyYWSYRqckAdEYueOwW511nN2Go+/2yqfB W70szXSdPAyEYlk2wtBUzZeljsoeQ/bGEL5Racq1eShc2udlc4SsxqYkNuTCXBelpwMYy1nOvLc IuhSP4cusyhRQggR1lZr7SZXMvcw/u0VLACkv4rJjd7mat0LUja5DJfIDv2Es/uD1HNdYnksNtb I9DBRDB4QR/F3BbYZ9Vdl20su1Ze5241Q7clkErwH0Twqocz8bd387S+teSUsNLOta7NgIRVmCG dOVN8ZKjixnE13Xrfs5myZlTqgAGjf/1/oI+7dOMGFVeWe8tyxdhYZKVzSFhPYaCU= X-Received: by 2002:a05:6830:3892:b0:7e6:ece3:80ed with SMTP id 46e09a7af769-7e92d9c6f71mr13440607a34.21.1782147559630; Mon, 22 Jun 2026 09:59:19 -0700 (PDT) Received: from ?IPV6:2600:8803:e7e4:500:b69c:5a77:b8fb:a5cf? ([2600:8803:e7e4:500:b69c:5a77:b8fb:a5cf]) by smtp.gmail.com with ESMTPSA id 46e09a7af769-7e944007d74sm6772717a34.5.2026.06.22.09.59.18 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 22 Jun 2026 09:59:19 -0700 (PDT) Message-ID: <78d859ed-61a6-413e-9ecb-6af177f2f9ae@baylibre.com> Date: Mon, 22 Jun 2026 11:59:18 -0500 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/4] dt-bindings: iio: adc: add ti,ads122c14 To: Jonathan Cameron Cc: =?UTF-8?Q?Nuno_S=C3=A1?= , Andy Shevchenko , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Kurt Borja , Nguyen Minh Tien , linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260615-iio-adc-ti-ads122c14-v1-0-e6bdadf7cb2b@baylibre.com> <20260615-iio-adc-ti-ads122c14-v1-1-e6bdadf7cb2b@baylibre.com> <20260621194102.08d7fdd6@jic23-huawei> <20260622105546.69c6b4bb@jic23-huawei> Content-Language: en-US From: David Lechner In-Reply-To: <20260622105546.69c6b4bb@jic23-huawei> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 6/22/26 4:55 AM, Jonathan Cameron wrote: > On Sun, 21 Jun 2026 16:14:57 -0500 > David Lechner wrote: > >> On 6/21/26 1:41 PM, Jonathan Cameron wrote: >>> On Mon, 15 Jun 2026 16:59:59 -0500 >>> "David Lechner (TI)" wrote: >>> ... >>>> + description: The current output of the excitation channels in microamps. >>>> + minimum: 1 >>>> + maximum: 1000 >>>> + >>>> + current-chopping: >>>> + $ref: /schemas/types.yaml#/definitions/flag >>>> + description: >>>> + If provided, the two excitation channels are to be used with current >>>> + chopping enabled. >>> >>> Can I have a reference for that? My initial read suggests it's the input channels >> >> No. :-) >> >> I must have got two ideas mixed together in my head to come up with >> this. Clearly this should be `input-channel-rotation` or something like >> that (we discussed in another thread already). Also curious if you thing >> any of these properties are common enough to promote to adc.yaml or if we >> should just make them e.g. `ti,input-channel-rotation` (you might not have >> had time to read the threads on that yet). > > It's turned up in a couple of drivers and the concept is fairly standard I think > so I'm fine with promoting this to a top level property if the definition can > be generic enough. > > For a non TI example, the LTC2893 has this as well for it's thermistor settings. > It might be worth comparing the approach given here with what we have there. > In that case there are specific node types for different types of things that > are wired up with constraints on things like excitation currents. > It kind of constrains things to the sane known use cases. However that is > partly because that device does (I think) more type specific handling than > we have here. LTC2983 has current source rotation, so it has a adi,current-rotate property which would be the same as the excitation-current-rotation property that we have proposed here (named current-chopping in the patch, but better name was suggested in later discussion). So not quite the same as the input-rotation property that we would need for this chip. Although ti,ads1262 that Kurt is working on will have both. > >> >>> that are chopped. For GC_EN >>> "When enabled, the device automatically swaps >>> the analog inputs and takes the average of two consecutive conversions to >>> cancel the internal offset voltage" >>> >>>