From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932758AbcHKIgZ (ORCPT ); Thu, 11 Aug 2016 04:36:25 -0400 Received: from mail-wm0-f53.google.com ([74.125.82.53]:36972 "EHLO mail-wm0-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750888AbcHKIgW (ORCPT ); Thu, 11 Aug 2016 04:36:22 -0400 Subject: Re: [PATCH] watchdog: core: Fix devres_alloc() allocation size To: Guenter Roeck , Wim Van Sebroeck References: <1470807271-8723-1-git-send-email-linux@roeck-us.net> Cc: linux-watchdog@vger.kernel.org, linux-kernel@vger.kernel.org From: Neil Armstrong Organization: Baylibre Message-ID: <78e269eb-93c0-dc2c-7a65-75380242ce66@baylibre.com> Date: Thu, 11 Aug 2016 10:36:22 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <1470807271-8723-1-git-send-email-linux@roeck-us.net> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 08/10/2016 07:34 AM, Guenter Roeck wrote: > Coverity reports: > > Passing argument 152UL /* sizeof (*wdd) */ to function __devres_alloc_node > and then casting the return value to struct watchdog_device ** is > suspicious. > > Allocation size needs to be sizeof(*rcwdd), not sizeof(*wdd). > > Fixes: 83fbae5a148c ("watchdog: Add a device managed API for ...") > Cc: Neil Armstrong > Signed-off-by: Guenter Roeck > --- > drivers/watchdog/watchdog_core.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/watchdog/watchdog_core.c b/drivers/watchdog/watchdog_core.c > index 6abb83cd7681..74265b2f806c 100644 > --- a/drivers/watchdog/watchdog_core.c > +++ b/drivers/watchdog/watchdog_core.c > @@ -349,7 +349,7 @@ int devm_watchdog_register_device(struct device *dev, > struct watchdog_device **rcwdd; > int ret; > > - rcwdd = devres_alloc(devm_watchdog_unregister_device, sizeof(*wdd), > + rcwdd = devres_alloc(devm_watchdog_unregister_device, sizeof(*rcwdd), > GFP_KERNEL); > if (!rcwdd) > return -ENOMEM; > My bad... Acked-by: Neil Armstrong