From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5F87EC07E9C for ; Fri, 9 Jul 2021 17:03:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 46AD8613BF for ; Fri, 9 Jul 2021 17:03:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230080AbhGIRG0 (ORCPT ); Fri, 9 Jul 2021 13:06:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38912 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229553AbhGIRGZ (ORCPT ); Fri, 9 Jul 2021 13:06:25 -0400 Received: from mail-ot1-x330.google.com (mail-ot1-x330.google.com [IPv6:2607:f8b0:4864:20::330]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2CF77C0613DD for ; Fri, 9 Jul 2021 10:03:42 -0700 (PDT) Received: by mail-ot1-x330.google.com with SMTP id 59-20020a9d0ac10000b0290462f0ab0800so10093569otq.11 for ; Fri, 09 Jul 2021 10:03:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=YK7jJxbOZAuE7pVlknkPFwr7Jcd4jJxXltp6+8MxV5k=; b=AWizmOE3raapwrlS3wvVw/oI5OJoo1PxO36Y3BtGnJpK0VTaTlKByhE8QBIeE1uzTd TCV+uM4qI4IMgTnQd6JxCDuay+LnHVRYT1ECf7XFvSe/T7D7JDE3VhOFGpXhOZETjt1t lI5Rmn5sJuBQL74che+B4S30uzdYdJQKZ1XKs= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=YK7jJxbOZAuE7pVlknkPFwr7Jcd4jJxXltp6+8MxV5k=; b=Ew58CiOe5tqE1qaQ54TaclAQ9tPZT5NlNgzBuNZXxJq8zt4OccoQaxmnTa5zkgQ5lH g6R/gZAHsl42mRZTlc0CYewdIZOPE+syI18E8i6EAOZ48wbMoH72XMjdkvv23jxFDSD3 A0ET3Jsus1H+BHKvV5qT+5Zo7uUBnFb+3q7l1OYisHeK7FiOjn/VwucOqw3SRbZEqMLy l/rgekjnXE8OYHmyfye/h/vnXi/exooRUCQmhzTFOiPVscCREqF57X4qYb2oYBO+7r8Z t/wrEyX3MtvRWGwvHZsBnGnhrnb1ZVK6Xf8F7/bTgMUAVPNYbx5EDepLbe9gTR+tYx5P ihkQ== X-Gm-Message-State: AOAM533FKcnDKc30LnrUeU99JHk5idmqX3RjVPKAqnbsRWfRGr3rQA5s a2EqEnJQ5KbVw3fe8FortQ3pXQ== X-Google-Smtp-Source: ABdhPJyREhIlHxFR0Am2IjUQXMRO8/xplN/tp0+t0WZlG/C5Srd1cEbGm3xrjpD02qS2DkGiAOx9Aw== X-Received: by 2002:a9d:2781:: with SMTP id c1mr28732408otb.34.1625850221514; Fri, 09 Jul 2021 10:03:41 -0700 (PDT) Received: from [192.168.1.112] (c-24-9-64-241.hsd1.co.comcast.net. [24.9.64.241]) by smtp.gmail.com with ESMTPSA id j5sm431609ooo.22.2021.07.09.10.03.40 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 09 Jul 2021 10:03:41 -0700 (PDT) Subject: Re: [PATCH] selftests: memory-hotplug: avoid spamming logs with dump_page(), ratio limit hot-remove error test To: Paolo Pisati , Shuah Khan Cc: linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, Shuah Khan References: <20210630145740.54614-1-paolo.pisati@canonical.com> From: Shuah Khan Message-ID: <78e2f6eb-6147-6fb5-b093-9534f5b36032@linuxfoundation.org> Date: Fri, 9 Jul 2021 11:03:40 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 7/9/21 7:00 AM, Paolo Pisati wrote: > On Wed, Jun 30, 2021 at 04:57:40PM +0200, Paolo Pisati wrote: >> While the offline memory test obey ratio limit, the same test with error >> injection does not and tries to offline all the hotpluggable memory, spamming >> system logs with hundreds of thousands of dump_page() entries, slowing system >> down (to the point the test itself timeout and gets terminated) and excessive fs >> occupation: >> >> ... > > Anyone with spare cycles could review this? It got one ack already. > Thanks for finding and fixing this. Looks good to me. I will pull this in as soon as the merge window ends and 5.14-rc1 comes out. thanks, -- Shuah