From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [185.203.201.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D5B06268C40 for ; Tue, 25 Feb 2025 13:12:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.203.201.7 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740489133; cv=none; b=n07+Y0FdZ98fy/dS3dFsamRBP9kKH8S5dscGw+QC6TqEhq7YBZxRo6vPxmM2AO6bb7ZcpPuImsfWXRxt5g6FNREOW8NAvuhG8lePe31y5dBJeGjjlOYNtG3qTOj6V7JdWIQpEW9g1BCfj7uCjTyiFiLAh5g7MKobWvkBO8hwQMw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740489133; c=relaxed/simple; bh=+OuOvkEeuzB7LAlg9x4s/xUKhlq/4QtpAbBFb8doADA=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=oHzc/zal+PRwskImQFRa/XvoUiYh41HFVkmi8WotGHFVqz8LUSZQCy5XT+syLb+MpGM59ZfBa9hYkXCWhHhmIEshmGS5YWPpm5AUcp8h68jgU8HxOePUBbdY7MA2auUXmtCFJLeieX4S3jPCCEx+z8jZNZbeas6pJBslxQuW93o= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de; spf=pass smtp.mailfrom=pengutronix.de; arc=none smtp.client-ip=185.203.201.7 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=pengutronix.de Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tmujE-0005WL-BO; Tue, 25 Feb 2025 14:12:04 +0100 Received: from lupine.office.stw.pengutronix.de ([2a0a:edc0:0:900:1d::4e] helo=lupine) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1tmujD-002mM0-2S; Tue, 25 Feb 2025 14:12:03 +0100 Received: from pza by lupine with local (Exim 4.96) (envelope-from ) id 1tmujD-0008y2-29; Tue, 25 Feb 2025 14:12:03 +0100 Message-ID: <78e60d723c27b7fa0f03bc6a74f6ad37d6508734.camel@pengutronix.de> Subject: Re: [PATCH v3 2/8] dt-bindings: dsp: fsl,dsp: Add resets property From: Philipp Zabel To: Daniel Baluta , robh@kernel.org, krzk+dt@kernel.org, shawnguo@kernel.org, mathieu.poirier@linaro.org Cc: conor+dt@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-remoteproc@vger.kernel.org, andersson@kernel.org, Frank.Li@nxp.com, peng.fan@nxp.com, laurentiu.mihalcea@nxp.com, iuliana.prodan@nxp.com Date: Tue, 25 Feb 2025 14:12:03 +0100 In-Reply-To: <20250225102005.408773-3-daniel.baluta@nxp.com> References: <20250225102005.408773-1-daniel.baluta@nxp.com> <20250225102005.408773-3-daniel.baluta@nxp.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.46.4-2 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: p.zabel@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org On Di, 2025-02-25 at 12:19 +0200, Daniel Baluta wrote: > Assert and deassert functionality of the DSP found on i.MX8MP is > realized by combining control bits from two modules: Audio Block > Control and Debug Access Port. >=20 > Audio block control bits are used to for Run/Stall the DSP core > while the DAP bits are used for software reset the core. >=20 > The original plan was to use fsl,dsp-ctrl property and to refer the > audiomix bits via syscon interface. This proposal received NACK from > community we shouldn't abuse the syscon interface [1]. >=20 > So remove fsl,dsp-ctrl property for i.MX8MP and use reset control > interface instead. >=20 > [1] https://patchwork.kernel.org/project/imx/patch/20250212085222.107102-= 6-daniel.baluta@nxp.com/ >=20 > Signed-off-by: Daniel Baluta > Reviewed-by: Frank Li > --- > .../devicetree/bindings/dsp/fsl,dsp.yaml | 16 +++++++++++++++- > 1 file changed, 15 insertions(+), 1 deletion(-) >=20 > diff --git a/Documentation/devicetree/bindings/dsp/fsl,dsp.yaml b/Documen= tation/devicetree/bindings/dsp/fsl,dsp.yaml > index ab93ffd3d2e5..b3550c9d12e7 100644 > --- a/Documentation/devicetree/bindings/dsp/fsl,dsp.yaml > +++ b/Documentation/devicetree/bindings/dsp/fsl,dsp.yaml > @@ -82,6 +82,9 @@ properties: > description: > Phandle to syscon block which provide access for processor enablem= ent > =20 > + resets: > + maxItems: 1 The DAP core reset is mentioned in the commit message. Why is it missing here? After reading the discussion in [1], I'd expect both the stall and the (core) reset signal to be documented, something like: resets: maxItems: 2 reset-names: items: - const: core - const: stall > + > required: > - compatible > - reg > @@ -164,6 +167,16 @@ allOf: > - const: txdb1 > - const: rxdb0 > - const: rxdb1 > + - if: > + properties: > + compatible: > + contains: > + enum: > + - fsl,imx8mp-dsp > + - fsl,imx8mp-hifi4 > + then: > + required: > + - resets > =20 > additionalProperties: false > =20 > @@ -186,6 +199,7 @@ examples: > }; > - | > #include > + #include > dsp_reserved: dsp@92400000 { > reg =3D <0x92400000 0x1000000>; > no-map; > @@ -220,5 +234,5 @@ examples: > <&mu2 3 0>; > memory-region =3D <&dsp_vdev0buffer>, <&dsp_vdev0vring0>, > <&dsp_vdev0vring1>, <&dsp_reserved>; > - fsl,dsp-ctrl =3D <&audio_blk_ctrl>; Is there nothing else in this range that will have to be controlled by the DSP driver in the future, such as the IMPWIRE register or the XOCDMODE[OCDHALTONRESET] bit? regards Philipp