From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 56FB5CE7A88 for ; Sun, 24 Sep 2023 07:50:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229982AbjIXHud (ORCPT ); Sun, 24 Sep 2023 03:50:33 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43388 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229699AbjIXHub (ORCPT ); Sun, 24 Sep 2023 03:50:31 -0400 Received: from relay9-d.mail.gandi.net (relay9-d.mail.gandi.net [IPv6:2001:4b98:dc4:8::229]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4E87D106; Sun, 24 Sep 2023 00:50:23 -0700 (PDT) Received: by mail.gandi.net (Postfix) with ESMTPSA id 66D9CFF804; Sun, 24 Sep 2023 07:49:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arinc9.com; s=gm1; t=1695541821; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=W5IpBspYKC9GLqm5jxyIjisuYRFWL1ICp1Y7jz+OR7M=; b=QLIpJcqUJNNSv8OEUEOc9TZAu+SgbjfTrGUaSNT5+TJdC14MhI1H+RflsE4yp+HOiqh3nG tbR1kfLeKdtyeP9hF7C6m1GBZuZ9uaOU0Iqx1Wd2RvBsfbFNGvGV9UwKyevSsrf+C7jxMe qk2iScqmkai8sFmXzUZyxme5XZK+62t/hnWvvxoCwcdnAQbwlmpOWaNmvalUMEpAvDSDWW gAU4T3UJW5uSqiu9q1sGOJxP1fsAUdf9fPfvM02YRWyz6QJSBlw92J/7/19/1I5PBDk32R URM4P5hXC8NnQ55uWZwheD44ynYrGhZUmtWfi3H/Xn0LHGNFwf0YNlO5srJmqg== Message-ID: <78e70cc9-a6ca-439b-bfca-3119299249de@arinc9.com> Date: Sun, 24 Sep 2023 10:49:49 +0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net-next v2 00/10] define and enforce phylink bindings To: Andrew Lunn Cc: "Russell King (Oracle)" , Rob Herring , Krzysztof Kozlowski , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Conor Dooley , George McCollister , Florian Fainelli , Vladimir Oltean , Kurt Kanzenbach , Matthias Brugger , AngeloGioacchino Del Regno , Woojung Huh , UNGLinuxDriver@microchip.com, Linus Walleij , =?UTF-8?Q?Alvin_=C5=A0ipraga?= , =?UTF-8?B?Q2zDqW1lbnQgTMOpZ2Vy?= , Marcin Wojtas , Lars Povlsen , Steen Hegelund , Daniel Machon , Radhey Shyam Pandey , Daniel Golle , Landen Chao , DENG Qingfang , Sean Wang , Geert Uytterhoeven , Magnus Damm , Maxime Chevallier , Nicolas Ferre , Claudiu Beznea , Marek Vasut , Claudiu Manoil , Alexandre Belloni , John Crispin , Madalin Bucur , Ioana Ciornei , Lorenzo Bianconi , Felix Fietkau , Horatiu Vultur , Oleksij Rempel , Alexandre Torgue , Giuseppe Cavallaro , Jose Abreu , Grygorii Strashko , Sekhar Nori , Shyam Pandey , mithat.guner@xeront.com, erkin.bozoglu@xeront.com, netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-renesas-soc@vger.kernel.org References: <20230916110902.234273-1-arinc.unal@arinc9.com> <6c1bb7df-34cd-4db9-95b6-959c87b68588@arinc9.com> <4856b212-5bc5-4783-a184-b34a4a915878@lunn.ch> <5650a2a3-a36f-441e-b4c2-aa7c751b5af5@arinc9.com> <410dfe3c-6f99-4054-88f8-0acbd134cfce@lunn.ch> <228f24db-0a26-4d38-8f73-a9691262cc5f@arinc9.com> <2be01f7e-8bd0-42c5-bc82-b1da29b83e24@lunn.ch> Content-Language: en-US From: =?UTF-8?B?QXLEsW7DpyDDnE5BTA==?= In-Reply-To: <2be01f7e-8bd0-42c5-bc82-b1da29b83e24@lunn.ch> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-GND-Sasl: arinc.unal@arinc9.com Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 24/09/2023 06:15, Andrew Lunn wrote: >>> There is a MAC driver currently under review which does not have a PHY >>> at all. The MAC is directly connected to a switch, all within one >>> IC. The link is always running at 5Gbps, the link is always up. It is >>> physically impossible to connect a PHY, so get_link_settings just >>> returns hard coded values. >> >> The fixed-link property would be used to describe the link of the MAC here. > > Fixed-link make sense for a general purpose MAC which could be > connected to a PHY, or could also be used without a PHY. fixed-link > simplifies the code in that the MAC driver does not see a difference, > it all looks like a PHY. > > However for a MAC which cannot be connected to a PHY, there is no need > to emulate a PHY. The MAC driver will be simpler. So i would not > recommend a fixed-link in this situation. There's a link, it must be described. The MAC driver can configure the link without reading the fixed-link property as there's no room for guessing. The phy-handle, pcs-handle, and sfp properties point out there's a PHY. The fixed-link property can be used standalone to describe MAC to MAC links. For this specific ethernet controller, the phy-handle, pcs-handle, and sfp properties can be disallowed on its schema to point out the ethernet controller cannot be connected to a PHY. Arınç