mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Helge Deller <deller@gmx.de>
To: Wei Chen <harperchen1110@gmail.com>, adaplas@gmail.com
Cc: linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] fbdev: nvidia: Fix potential divide by zero
Date: Thu, 16 Mar 2023 14:34:42 +0100	[thread overview]
Message-ID: <78ea59ba-72ab-db50-4d66-b1ad84ed8548@gmx.de> (raw)
In-Reply-To: <20230315071831.3833948-1-harperchen1110@gmail.com>

On 3/15/23 08:18, Wei Chen wrote:
> variable var->pixclock can be set by user. In case it
> equals to zero, divide by zero would occur in nvidiafb_set_par.
>
> Similar crashes have happened in other fbdev drivers. There
> is no check and modification on var->pixclock along the call
> chain to nvidia_check_var and nvidiafb_set_par. We believe it
> could also be triggered in driver nvidia from user site.
>
> Signed-off-by: Wei Chen <harperchen1110@gmail.com>

applied all four patches.

Thanks!
Helge

> ---
>   drivers/video/fbdev/nvidia/nvidia.c | 2 ++
>   1 file changed, 2 insertions(+)
>
> diff --git a/drivers/video/fbdev/nvidia/nvidia.c b/drivers/video/fbdev/nvidia/nvidia.c
> index e60a276b4855..ea4ba3dfb96b 100644
> --- a/drivers/video/fbdev/nvidia/nvidia.c
> +++ b/drivers/video/fbdev/nvidia/nvidia.c
> @@ -764,6 +764,8 @@ static int nvidiafb_check_var(struct fb_var_screeninfo *var,
>   	int pitch, err = 0;
>
>   	NVTRACE_ENTER();
> +	if (!var->pixclock)
> +		return -EINVAL;
>
>   	var->transp.offset = 0;
>   	var->transp.length = 0;


      reply	other threads:[~2023-03-16 13:34 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-15  7:18 Wei Chen
2023-03-16 13:34 ` Helge Deller [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=78ea59ba-72ab-db50-4d66-b1ad84ed8548@gmx.de \
    --to=deller@gmx.de \
    --cc=adaplas@gmail.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=harperchen1110@gmail.com \
    --cc=linux-fbdev@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®