mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Christoph Stoidner <C.Stoidner@phytec.de>
To: Andrew Lunn <andrew@lunn.ch>
Cc: Stefan Wahren <wahrenst@gmx.net>, Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Shawn Guo <shawnguo@kernel.org>,
	Sascha Hauer <s.hauer@pengutronix.de>,
	Pengutronix Kernel Team <kernel@pengutronix.de>,
	Fabio Estevam <festevam@gmail.com>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"imx@lists.linux.dev" <imx@lists.linux.dev>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"upstream@lists.phytec.de" <upstream@lists.phytec.de>
Subject: Re: [PATCH v3] arm64: dts: freescale: imx93-phycore-som: Delay the phy reset by a gpio
Date: Mon, 2 Jun 2025 11:46:14 +0000	[thread overview]
Message-ID: <78ec24d09d129d52d3442f6319cf1ef5b6ce7f3d.camel@phytec.de> (raw)
In-Reply-To: <8e448625-b4ad-4bf1-8930-6fecdedb1d8d@lunn.ch>

Hi Andrew,

On Mo, 2025-06-02 at 04:09 +0200, Andrew Lunn wrote:
> On Fri, May 30, 2025 at 01:40:38PM +0000, Christoph Stoidner wrote:
> > 
> > 
> > On Mi, 2025-05-28 at 21:29 +0200, Andrew Lunn wrote:
> > > > Yes, that's what I measured. For analysis, I added some
> > > > debug outputs
> > > > to
> > > > the phy reset and the 1st phy register access. And as I can
> > > > see,
> > > > the
> > > > phy register access happens when userland sets up the network:
> > > 
> > > Please repeat the measurements with NFS root.
> > > 
> > > You will find that the kernel brings the interface up right have
> > > register_netdev() is called, and starts transmitting. It can
> > > happen
> > > before register_netdev() even returns.
> > 
> > Thanks for that hint. As you said, with nfs root the register
> > access
> > happens much earlier. I measured:
> > 
> >        [   1.713185] DEB-PHY: mdio reset exeucted
> >        ...
> >        ...
> >        ...
> >        [   2.672892] DEB-PHY: register access
> > 
> > However, the delta time of 0.959707s (9597ms) still meets the T2
> > ("prior to MDC preamble for register access") that is defined in
> > the
> > PHY's datasheet with 2ms.
> 
> I agree it is long enough, but i'm also surprised how slow the kernel
> was. Are you using a fixed IP address, or dhcp?

I use a fixed IP address.

But isn't the bringup of ethernet+phy interface one of the last things
that happens during the kernel boot-up?

When I boot my system from sd-card, I can see that mounting the rootfs
on the sdcard occurs at about 2500ms after kernel start:

      [    0.000000] Booting Linux on physical CPU 0x0000000000 ...
                ...
                ...
                ...
      [    2.538013] EXT4-fs (mmcblk1p2): mounted filesystem a500e519-
d77b-471c-8215-e4f51236aaaa r/w with ordered data mode. Quota mode:
none.
      [    2.550189] VFS: Mounted root (ext4 filesystem) on device
179:98.
      [    2.556871] devtmpfs: mounted
      [    2.562733] Freeing unused kernel memory: 4032K

And thats very near to what I saw with NFS root (to remember: 2672ms
from kernel start). So I feel that patch itself and its corresponding 
measured timings are valid.

However, what timing would you expect?

Thanks, 
Christoph

> 
>  Andrew

  reply	other threads:[~2025-06-02 11:46 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-05-24 11:23 Christoph Stoidner
2025-05-24 17:44 ` Andrew Lunn
2025-05-24 21:37   ` AW: " Christoph Stoidner
2025-05-26  6:44   ` Stefan Wahren
2025-05-26  9:09     ` Christoph Stoidner
2025-05-26  9:24       ` Stefan Wahren
2025-05-26 10:04         ` Christoph Stoidner
2025-05-26 12:14           ` Stefan Wahren
2025-05-28 18:30             ` Christoph Stoidner
2025-05-28 19:29               ` Andrew Lunn
2025-05-30 13:40                 ` Christoph Stoidner
2025-06-02  2:09                   ` Andrew Lunn
2025-06-02 11:46                     ` Christoph Stoidner [this message]
2025-06-02 12:26                       ` Andrew Lunn
2025-07-08  8:35                         ` [Upstream] " Primoz Fiser
2025-07-18 17:33                           ` Christoph Stoidner
2025-07-18 17:47                             ` Andrew Lunn
2025-08-07 12:53                             ` Christoph Stoidner
2025-08-20  2:36 ` Shawn Guo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=78ec24d09d129d52d3442f6319cf1ef5b6ce7f3d.camel@phytec.de \
    --to=c.stoidner@phytec.de \
    --cc=andrew@lunn.ch \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=festevam@gmail.com \
    --cc=imx@lists.linux.dev \
    --cc=kernel@pengutronix.de \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robh@kernel.org \
    --cc=s.hauer@pengutronix.de \
    --cc=shawnguo@kernel.org \
    --cc=upstream@lists.phytec.de \
    --cc=wahrenst@gmx.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®