From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1033439AbdD0B77 (ORCPT ); Wed, 26 Apr 2017 21:59:59 -0400 Received: from mail-pf0-f171.google.com ([209.85.192.171]:35500 "EHLO mail-pf0-f171.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754161AbdD0B7v (ORCPT ); Wed, 26 Apr 2017 21:59:51 -0400 Subject: Re: [PATCH] irqchip/mbigen: Fix the clear register offset To: "majun (Euler7)" , Marc Zyngier , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, tglx@linutronix.de, dingtianhong@huawei.com, guohanjun@huawei.com References: <1493086563-36396-1-git-send-email-majun258@huawei.com> <68214147-bc4d-c542-ce40-78f69a63e53d@linaro.org> <07081162-ca52-fa46-00e6-e72e1b4fd092@arm.com> <590148F2.1030502@huawei.com> From: Hanjun Guo Message-ID: <78f103ec-4049-1926-ae44-425b9e859ca7@linaro.org> Date: Thu, 27 Apr 2017 09:59:45 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <590148F2.1030502@huawei.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2017/4/27 9:27, majun (Euler7) wrote: > Hi Marc: > > 在 2017/4/26 16:01, Marc Zyngier 写道: >> On 26/04/17 04:10, Hanjun Guo wrote: >>> Hi Majun, >>> >>> On 2017/4/25 10:16, Majun wrote: >>>> From: MaJun >>>> >>>> Don't minus reserved interrupts (64) when get the clear register offset,because >>>> the clear register space includes the space of these 64 interrupts. >>> >>> Could you mention the background that there is a timeout mechanism >>> to clear the register in the mbigen to make the code work even we clear >>> the wrong (and noneffective) register? that will help for review I >>> think. >> >> A timeout? So if you don't clear the interrupt in a timely manner, it >> will still bypass the masking? That feels very wrong. How is this >> timeout configured? Can it be entirely disabled? > > You are right. The timeout should be turn off usually, it's just a debug or > testing function in our chip. Because of configuration mistake in BIOS, this function > is turned on now and covered the bug in clear offset calculate. > Now, it's time to fix this. Thanks for the clarify, that means it can be entirely disabled in the firmware. >> >>> >>>> >>>> Signed-off-by: MaJun >>>> --- >>>> drivers/irqchip/irq-mbigen.c | 1 - >>>> 1 file changed, 1 deletion(-) >>>> >>>> diff --git a/drivers/irqchip/irq-mbigen.c b/drivers/irqchip/irq-mbigen.c >>>> index 061cdb8..75818a5 100644 >>>> --- a/drivers/irqchip/irq-mbigen.c >>>> +++ b/drivers/irqchip/irq-mbigen.c >>>> @@ -108,7 +108,6 @@ static inline void get_mbigen_clear_reg(irq_hw_number_t hwirq, >>>> { >>>> unsigned int ofst; >>>> >>>> - hwirq -= RESERVED_IRQ_PER_MBIGEN_CHIP; >>>> ofst = hwirq / 32 * 4; >>>> >>>> *mask = 1 << (hwirq % 32); >>> >>> How about following to save more lines of code: >>> >>> --- a/drivers/irqchip/irq-mbigen.c >>> +++ b/drivers/irqchip/irq-mbigen.c >>> @@ -106,10 +106,7 @@ static inline void >>> get_mbigen_type_reg(irq_hw_number_t hwirq, >>> static inline void get_mbigen_clear_reg(irq_hw_number_t hwirq, >>> u32 *mask, u32 *addr) >>> { >>> - unsigned int ofst; >>> - >>> - hwirq -= RESERVED_IRQ_PER_MBIGEN_CHIP; >>> - ofst = hwirq / 32 * 4; >>> + unsigned int ofst = hwirq / 32 * 4; >>> >>> *mask = 1 << (hwirq % 32); >>> *addr = ofst + REG_MBIGEN_CLEAR_OFFSET; >> >> Well, this is not a code deletion contest... ;-) That's just my personal addiction :) Thanks Hanjun