From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D04E3C433E0 for ; Mon, 22 Feb 2021 03:43:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9D88464ECD for ; Mon, 22 Feb 2021 03:43:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230104AbhBVDmv (ORCPT ); Sun, 21 Feb 2021 22:42:51 -0500 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:59662 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230064AbhBVDmt (ORCPT ); Sun, 21 Feb 2021 22:42:49 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1613965282; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=eByhtyuketU2PjgP2Av/7Fbai5HOSWISKqIauwTJLI8=; b=UTcrUczSSBfMndS/KvuGCh9CmCBrGujhqMP4UnS6dAOshprZQbt0o5C4IKfWrcg/GjTawS 5hpiUhHRg5u1H/7vl1Vim8hxsFxrpOK8m4X9vlOEzdB0Y8qc2nbzKnBG1BzHJEU3yu0jmL sW3SprqDKSxd3fzcDGhbohVyGoUIiVU= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-215-5H45XKSgN2eP3ihA-EWNkA-1; Sun, 21 Feb 2021 22:41:20 -0500 X-MC-Unique: 5H45XKSgN2eP3ihA-EWNkA-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id B4B77835E20; Mon, 22 Feb 2021 03:41:18 +0000 (UTC) Received: from wangxiaodeMacBook-Air.local (ovpn-13-112.pek2.redhat.com [10.72.13.112]) by smtp.corp.redhat.com (Postfix) with ESMTP id 5A5165B6BE; Mon, 22 Feb 2021 03:41:13 +0000 (UTC) Subject: Re: [PATCH] virtio: don't prompt CONFIG_VIRTIO_PCI_MODERN To: Arnd Bergmann Cc: "Michael S. Tsirkin" , virtualization@lists.linux-foundation.org, "linux-kernel@vger.kernel.org" , Arnd Bergmann , Anders Roxell , Guenter Roeck References: <20210219084509.48269-1-jasowang@redhat.com> From: Jason Wang Message-ID: <78f4f064-7e70-0765-95ef-a929f280be68@redhat.com> Date: Mon, 22 Feb 2021 11:41:11 +0800 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.16; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-GB X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2021/2/19 6:12 下午, Arnd Bergmann wrote: > On Fri, Feb 19, 2021 at 9:45 AM Jason Wang wrote: >> We used to prompt CONFIG_VIRTIO_PCI_MODERN to user which may bring a >> lot of confusion. E.g it may break various default configs which want >> virtio devices. >> >> So this patch fixes this by hide the prompot and document the >> dependency. >> >> Cc: Arnd Bergmann >> Cc: Anders Roxell >> Cc: Guenter Roeck >> Reported-by: Naresh Kamboju >> Fixes: 86b87c9d858b6 ("virtio-pci: introduce modern device module") >> Signed-off-by: Jason Wang > Acked-by: Arnd Bergmann > > Note that this effectively makes VIRTIO_PCI_MODERN and VIRTIO_PCI > synonyms, so git goes back to not being able to have VIRTIO_PCI_MODERN > by itself, but it seems that this is ok because the legacy part was already > split out. There will be a vDPA driver that will select VIRTIO_PCI_MODERN_DEV. It used to belong to one large sereis, but it was not merged since it needs some rebase. Thanks > > Arnd >