From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0431CC4338F for ; Mon, 23 Aug 2021 02:29:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id CEB0561360 for ; Mon, 23 Aug 2021 02:29:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234847AbhHWCaU (ORCPT ); Sun, 22 Aug 2021 22:30:20 -0400 Received: from szxga03-in.huawei.com ([45.249.212.189]:14312 "EHLO szxga03-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234692AbhHWCaT (ORCPT ); Sun, 22 Aug 2021 22:30:19 -0400 Received: from dggemv711-chm.china.huawei.com (unknown [172.30.72.56]) by szxga03-in.huawei.com (SkyGuard) with ESMTP id 4GtGQp2j1wz8977; Mon, 23 Aug 2021 10:29:22 +0800 (CST) Received: from dggpemm500001.china.huawei.com (7.185.36.107) by dggemv711-chm.china.huawei.com (10.1.198.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.2; Mon, 23 Aug 2021 10:29:33 +0800 Received: from [10.174.177.243] (10.174.177.243) by dggpemm500001.china.huawei.com (7.185.36.107) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.2; Mon, 23 Aug 2021 10:29:32 +0800 Subject: Re: [PATCH v3 0/3] arm64: support page mapping percpu first chunk allocator From: Kefeng Wang To: , , , , , , CC: , , References: <20210809093750.131091-1-wangkefeng.wang@huawei.com> <9b75f4e5-a675-1227-0476-43fc21509086@huawei.com> Message-ID: <7904a638-3ee2-381f-6dfb-3d011df42c40@huawei.com> Date: Mon, 23 Aug 2021 10:29:32 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.7.0 MIME-Version: 1.0 In-Reply-To: <9b75f4e5-a675-1227-0476-43fc21509086@huawei.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US X-Originating-IP: [10.174.177.243] X-ClientProxiedBy: dggems702-chm.china.huawei.com (10.3.19.179) To dggpemm500001.china.huawei.com (7.185.36.107) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2021/8/12 14:07, Kefeng Wang wrote: > Hi Catalin and Will， > > The drivers/base/arch_numa.c is only shared by riscv and arm64, > > and the change from patch2 won't broke riscv. > > Could all patches be merged by arm64 tree? or any new comments? Kindly ping... > > Many thanks. > > On 2021/8/9 17:37, Kefeng Wang wrote: >> Percpu embedded first chunk allocator is the firstly option, but it >> could fails on ARM64, eg, >>    "percpu: max_distance=0x5fcfdc640000 too large for vmalloc space >> 0x781fefff0000" >>    "percpu: max_distance=0x600000540000 too large for vmalloc space >> 0x7dffb7ff0000" >>    "percpu: max_distance=0x5fff9adb0000 too large for vmalloc space >> 0x5dffb7ff0000" >> >> then we could meet "WARNING: CPU: 15 PID: 461 at vmalloc.c:3087 >> pcpu_get_vm_areas+0x488/0x838", >> even the system could not boot successfully. >> >> Let's implement page mapping percpu first chunk allocator as a fallback >> to the embedding allocator to increase the robustness of the system. >> >> Also fix a crash when both NEED_PER_CPU_PAGE_FIRST_CHUNK and >> KASAN_VMALLOC enabled. >> >> Tested on ARM64 qemu with cmdline "percpu_alloc=page" based on >> v5.14-rc5. >> >> v3: >> - search for a range that fits instead of always picking the end from >>    vmalloc area suggested by Catalin. >> - use NUMA_NO_NODE to avoid "virt_to_phys used for non-linear address:" >>    issue in arm64 kasan_populate_early_vm_area_shadow(). >> - add Acked-by: Marco Elver to patch v3 >> >> V2: >> - fix build error when CONFIG_KASAN disabled, found by lkp@intel.com >> - drop wrong __weak comment from kasan_populate_early_vm_area_shadow(), >>    found by Marco Elver >> >> Kefeng Wang (3): >>    vmalloc: Choose a better start address in vm_area_register_early() >>    arm64: Support page mapping percpu first chunk allocator >>    kasan: arm64: Fix pcpu_page_first_chunk crash with KASAN_VMALLOC >> >>   arch/arm64/Kconfig         |  4 ++ >>   arch/arm64/mm/kasan_init.c | 16 ++++++++ >>   drivers/base/arch_numa.c   | 82 +++++++++++++++++++++++++++++++++----- >>   include/linux/kasan.h      |  6 +++ >>   mm/kasan/init.c            |  5 +++ >>   mm/vmalloc.c               | 17 +++++--- >>   6 files changed, 115 insertions(+), 15 deletions(-) >>