mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: David Woodhouse <dwmw2@infradead.org>
To: Paul Durrant <paul@xen.org>,
	kvm@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Paul Durrant <pdurrant@amazon.com>,
	Sean Christopherson <seanjc@google.com>,
	Paolo Bonzini <pbonzini@redhat.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
	Dave Hansen <dave.hansen@linux.intel.com>,
	"H. Peter Anvin" <hpa@zytor.com>,
	x86@kernel.org
Subject: Re: [PATCH v3 08/13] KVM: xen: prevent vcpu_id from changing whilst shared_info is valid
Date: Mon, 18 Sep 2023 16:59:38 +0100	[thread overview]
Message-ID: <790646bf2b3331aceebf46543a47400cdbfb02bb.camel@infradead.org> (raw)
In-Reply-To: <20230918144111.641369-9-paul@xen.org>

[-- Attachment #1: Type: text/plain, Size: 637 bytes --]

On Mon, 2023-09-18 at 14:41 +0000, Paul Durrant wrote:
> From: Paul Durrant <pdurrant@amazon.com>
> 
> To further prepare for automatically using the vcpu_info structures
> embedded in the shared_info page, we need to ensure that the Xen vcpu_id
> cannot change under our feet. We can do this by simply returning -EBUSY
> to any attempt to modify the attribute while the shinfo_cache is active.
> 
> Signed-off-by: Paul Durrant <pdurrant@amazon.com>

Makes sense. Wants explicitly mentioning in the documentation for
KVM_XEN_VCPU_ATTR_TYPE_VCPU_ID. If/when you did that,

Reviewed-by: David Woodhouse <dwmw@amazon.co.uk>


[-- Attachment #2: smime.p7s --]
[-- Type: application/pkcs7-signature, Size: 5965 bytes --]

  reply	other threads:[~2023-09-18 16:35 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-18 14:40 [PATCH v3 00/13] KVM: xen: update shared_info and vcpu_info handling Paul Durrant
2023-09-18 14:40 ` [PATCH v3 01/13] KVM: pfncache: add a map helper function Paul Durrant
2023-09-18 14:41 ` [PATCH v3 02/13] KVM: pfncache: add a mark-dirty helper Paul Durrant
2023-09-18 14:41 ` [PATCH v3 03/13] KVM: pfncache: add a helper to get the gpa Paul Durrant
2023-09-18 14:41 ` [PATCH v3 04/13] KVM: pfncache: base offset check on khva rather than gpa Paul Durrant
2023-09-18 14:41 ` [PATCH v3 05/13] KVM: pfncache: allow a cache to be activated with a fixed (userspace) HVA Paul Durrant
2023-09-18 14:41 ` [PATCH v3 06/13] KVM: xen: allow shared_info to be mapped by fixed HVA Paul Durrant
2023-09-18 14:41 ` [PATCH v3 07/13] KVM: xen: prepare for using 'default' vcpu_info Paul Durrant
2023-09-18 14:41 ` [PATCH v3 08/13] KVM: xen: prevent vcpu_id from changing whilst shared_info is valid Paul Durrant
2023-09-18 15:59   ` David Woodhouse [this message]
2023-09-18 14:41 ` [PATCH v3 09/13] KVM: xen: automatically use the vcpu_info embedded in shared_info Paul Durrant
2023-09-18 16:07   ` David Woodhouse
2023-09-18 16:15     ` Paul Durrant
2023-09-18 16:20       ` David Woodhouse
2023-09-18 14:41 ` [PATCH v3 10/13] KVM: selftests / xen: set KVM_XEN_VCPU_ATTR_TYPE_VCPU_ID Paul Durrant
2023-09-18 14:41 ` [PATCH v3 11/13] KVM: selftests / xen: map shared_info using HVA rather than GFN Paul Durrant
2023-09-18 16:16   ` David Woodhouse
2023-09-18 14:41 ` [PATCH v3 12/13] KVM: selftests / xen: don't explicitly set the vcpu_info address Paul Durrant
2023-09-18 16:10   ` David Woodhouse
2023-09-18 14:41 ` [PATCH v3 13/13] KVM: xen: advertize the KVM_XEN_HVM_CONFIG_SHARED_INFO_HVA capability Paul Durrant
2023-09-18 16:18 ` [PATCH v3 00/13] KVM: xen: update shared_info and vcpu_info handling Sean Christopherson
2023-09-18 16:34   ` David Woodhouse
2023-09-18 17:12     ` Sean Christopherson
2023-09-19  8:48       ` Paul Durrant
2023-09-19 15:37         ` Sean Christopherson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=790646bf2b3331aceebf46543a47400cdbfb02bb.camel@infradead.org \
    --to=dwmw2@infradead.org \
    --cc=bp@alien8.de \
    --cc=dave.hansen@linux.intel.com \
    --cc=hpa@zytor.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=paul@xen.org \
    --cc=pbonzini@redhat.com \
    --cc=pdurrant@amazon.com \
    --cc=seanjc@google.com \
    --cc=tglx@linutronix.de \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®