From: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
To: Mukesh Ojha <quic_mojha@quicinc.com>,
agross@kernel.org, andersson@kernel.org,
konrad.dybcio@linaro.org
Cc: linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/4] firmware: qcom_scm: Clear download bit during reboot
Date: Wed, 8 Mar 2023 15:06:14 +0000 [thread overview]
Message-ID: <7908960d-da82-37d3-03af-8cab0c062221@linaro.org> (raw)
In-Reply-To: <1677664555-30191-2-git-send-email-quic_mojha@quicinc.com>
On 01/03/2023 09:55, Mukesh Ojha wrote:
> During normal restart of a system download bit should
> be cleared irrespective of whether download mode is
> set or not.
Looks like this is a fix, Fixes tag would help here.
--srini
>
> Signed-off-by: Mukesh Ojha <quic_mojha@quicinc.com>
> ---
> Changes in v2:
> - No change
>
> drivers/firmware/qcom_scm.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/firmware/qcom_scm.c b/drivers/firmware/qcom_scm.c
> index cdbfe54..51eb853 100644
> --- a/drivers/firmware/qcom_scm.c
> +++ b/drivers/firmware/qcom_scm.c
> @@ -1418,8 +1418,7 @@ static int qcom_scm_probe(struct platform_device *pdev)
> static void qcom_scm_shutdown(struct platform_device *pdev)
> {
> /* Clean shutdown, disable download mode to allow normal restart */
> - if (download_mode)
> - qcom_scm_set_download_mode(false);
> + qcom_scm_set_download_mode(false);
> }
>
> static const struct of_device_id qcom_scm_dt_match[] = {
next prev parent reply other threads:[~2023-03-08 15:07 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-01 9:55 [PATCH v2 0/4] Refactor to support multiple download mode Mukesh Ojha
2023-03-01 9:55 ` [PATCH v2 1/4] firmware: qcom_scm: Clear download bit during reboot Mukesh Ojha
2023-03-08 15:06 ` Srinivas Kandagatla [this message]
2023-03-01 9:55 ` [PATCH v2 2/4] firmware: scm: Modify only the DLOAD bit in TCSR register for download mode Mukesh Ojha
2023-03-01 10:39 ` Dmitry Baryshkov
2023-03-03 7:54 ` Mukesh Ojha
2023-03-08 15:06 ` Srinivas Kandagatla
2023-03-16 15:04 ` Mukesh Ojha
2023-03-01 9:55 ` [PATCH v2 3/4] firmware: qcom_scm: Refactor code to support multiple " Mukesh Ojha
2023-03-01 10:59 ` Dmitry Baryshkov
2023-03-03 7:46 ` Mukesh Ojha
2023-03-16 16:27 ` Dmitry Baryshkov
2023-03-17 15:15 ` Mukesh Ojha
2023-03-01 9:55 ` [PATCH v2 4/4] firmware: qcom_scm: Add multiple download mode support Mukesh Ojha
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7908960d-da82-37d3-03af-8cab0c062221@linaro.org \
--to=srinivas.kandagatla@linaro.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=quic_mojha@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®