Re: [PATCH v2] dt-bindings: nvmem: nxp,lpc1850-otp: convert to DT schema

[Vladimir Zapolskiy <vz@mleia.com>]

Hi Akhila.

On 1/26/26 16:53, Akhila YS wrote:
> Convert NXP LPC18xx OTP memory controller binding to YAML format.
> 
> Signed-off-by: Akhila YS <akhilayalmati@gmail.com>
> ---
> Changes in v2:
> - Add "Vladimir Zapolskiy" as maintainer.
> - Remove unnecessary description for the yaml.
> - Remove "#size-cells" and "#address-cells" from the properties and required.
> - Link to v1: https://lore.kernel.org/r/20260123-lpc1850-otp-v1-1-8bd957dd9c98@gmail.com
> ---
>   .../devicetree/bindings/nvmem/lpc1850-otp.txt      | 20 -----------
>   .../devicetree/bindings/nvmem/nxp,lpc1850-otp.yaml | 41 ++++++++++++++++++++++
>   2 files changed, 41 insertions(+), 20 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/nvmem/lpc1850-otp.txt b/Documentation/devicetree/bindings/nvmem/lpc1850-otp.txt
> deleted file mode 100644
> index 853b6a754644..000000000000
> --- a/Documentation/devicetree/bindings/nvmem/lpc1850-otp.txt
> +++ /dev/null
> @@ -1,20 +0,0 @@
> -* NXP LPC18xx OTP memory
> -
> -Internal OTP (One Time Programmable) memory for NXP LPC18xx/43xx devices.
> -
> -Required properties:
> -  - compatible: Should be "nxp,lpc1850-otp"
> -  - reg: Must contain an entry with the physical base address and length
> -    for each entry in reg-names.
> -  - address-cells: must be set to 1.
> -  - size-cells: must be set to 1.
> -
> -See nvmem.txt for more information.
> -
> -Example:
> -  otp: otp@40045000 {
> -    compatible = "nxp,lpc1850-otp";
> -    reg = <0x40045000 0x1000>;
> -    #address-cells = <1>;
> -    #size-cells = <1>;
> -  };
> diff --git a/Documentation/devicetree/bindings/nvmem/nxp,lpc1850-otp.yaml b/Documentation/devicetree/bindings/nvmem/nxp,lpc1850-otp.yaml
> new file mode 100644
> index 000000000000..a0cdf083267d
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/nvmem/nxp,lpc1850-otp.yaml
> @@ -0,0 +1,41 @@
> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/nvmem/nxp,lpc1850-otp.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: NXP LPC18xx / LPC43xx One-Time Programmable (OTP) memory
> +
> +maintainers:
> +  - Vladimir Zapolskiy <vz@mleia.com>
> +
> +description:
> +  The internal OTP memory in NXP LPC18xx and LPC43xx microcontrollers
> +  provides a dedicated non-volatile storage area designed for permanent,
> +  one-time configuration and data storage.
> +
> +allOf:
> +  - $ref: nvmem.yaml#
> +
> +properties:
> +  compatible:
> +    const: nxp,lpc1850-otp
> +
> +  reg:
> +    maxItems: 1
> +
> +required:
> +  - compatible
> +  - reg
> +
> +unevaluatedProperties: false
> +
> +examples:
> +  - |
> +    otp@40045000 {
> +        compatible = "nxp,lpc1850-otp";
> +        reg = <0x40045000 0x1000>;
> +        #address-cells = <1>;
> +        #size-cells = <1>;

Nitpick, #address-cells and #size-cells properties could/should be removed
from the example.

> +    };
> +...
> 

Anyway, the change looks good, thank you for the contribution.

Reviewed-by: Vladimir Zapolskiy <vz@mleia.com>

-- 
Best wishes,
Vladimir