From: Dan Carpenter <dan.carpenter@linaro.org>
To: Tree Davies <tdavies@darkphysics.net>
Cc: gregkh@linuxfoundation.org, philipp.g.hortmann@gmail.com,
anjan@momi.ca, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 00/24] Staging: rtl8192e: Maintenance renames and cleanup
Date: Wed, 12 Jun 2024 10:02:09 +0300 [thread overview]
Message-ID: <7918dbd5-45e3-4b61-8bb7-eb8a27a8d152@moroto.mountain> (raw)
In-Reply-To: <20240612032230.9738-1-tdavies@darkphysics.net>
On Tue, Jun 11, 2024 at 08:22:06PM -0700, Tree Davies wrote:
> This patch series v2 attacks CamelCase variable renames, removes
> un-used variables and adjusts alignment issues found in
> rtllib_rx.c and rtllib_tx.c.
>
> NOTE: Patch #9 doesn't completely resolve CamelCase violation as the
> correct abreviation of megahertz is MHz as called out by Dan Carpenter.
Thanks!
Reviewed-by: Dan Carpenter <dan.carpenter@linaro.org>
regards,
dan carpenter
next prev parent reply other threads:[~2024-06-12 7:02 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-12 3:22 Tree Davies
2024-06-12 3:22 ` [PATCH v2 01/24] Staging: rtl8192e: Rename variable bHwSec Tree Davies
2024-06-12 3:22 ` [PATCH v2 02/24] Staging: rtl8192e: Rename variable bIsMulticast Tree Davies
2024-06-12 3:22 ` [PATCH v2 03/24] Staging: rtl8192e: Rename variable HTCurrentOperaRate Tree Davies
2024-06-12 3:22 ` [PATCH v2 04/24] Staging: rtl8192e: Rename variable HTOpMode Tree Davies
2024-06-12 3:22 ` [PATCH v2 05/24] Staging: rtl8192e: Rename variable bRTSEnable Tree Davies
2024-06-12 3:22 ` [PATCH v2 06/24] Staging: rtl8192e: Rename variable bRTSBW Tree Davies
2024-06-12 3:22 ` [PATCH v2 07/24] Staging: rtl8192e: Rename variable bCTSEnable Tree Davies
2024-06-12 3:22 ` [PATCH v2 08/24] Staging: rtl8192e: Rename variable bRTSUseShortGI Tree Davies
2024-06-12 3:22 ` [PATCH v2 09/24] Staging: rtl8192e: Rename variable bforced_tx20Mhz Tree Davies
2024-06-12 3:22 ` [PATCH v2 10/24] Staging: rtl8192e: Rename variable bPacketBW Tree Davies
2024-06-12 3:22 ` [PATCH v2 11/24] Staging: rtl8192e: Rename variable bBroadcast Tree Davies
2024-06-12 3:22 ` [PATCH v2 12/24] Staging: rtl8192e: Rename variable CntAfterLink Tree Davies
2024-06-12 3:22 ` [PATCH v2 13/24] Staging: rtl8192e: Rename variable bUseShortGI Tree Davies
2024-06-12 3:22 ` [PATCH v2 14/24] Staging: rtl8192e: Rename function TsStartAddBaProcess() Tree Davies
2024-06-12 3:22 ` [PATCH v2 15/24] Staging: rtl8192e: Fix alignment to match open parenthesis Tree Davies
2024-06-12 3:22 ` [PATCH v2 16/24] Staging: rtl8192e: Rename function rtllib_query_BandwidthMode Tree Davies
2024-06-12 3:22 ` [PATCH v2 17/24] Staging: rtl8192e: Rename function rtllib_query_ShortPreambleMode Tree Davies
2024-06-12 3:22 ` [PATCH v2 18/24] Staging: rtl8192e: Rename function rtllib_query_HTCapShortGI Tree Davies
2024-06-12 3:22 ` [PATCH v2 19/24] Staging: rtl8192e: Rename variable bUseShortPreamble Tree Davies
2024-06-12 3:22 ` [PATCH v2 20/24] Staging: rtl8192e: Rename variable bRTSSTBC Tree Davies
2024-06-12 3:22 ` [PATCH v2 21/24] Staging: rtl8192e: Remove parameter bIsAmsdu from rtllib_classify() Tree Davies
2024-06-12 3:22 ` [PATCH v2 22/24] Staging: rtl8192e: Remove variable IsAmsdu from rtllib_xmit_inter() Tree Davies
2024-06-12 3:22 ` [PATCH v2 23/24] Staging: rtl8192e: Fix alignment to match open parenthesis in rtllib_tx.c Tree Davies
2024-06-12 3:22 ` [PATCH v2 24/24] Staging: rtl8192e: Fix alignment to match open parenthesis in rtllib_rx.c Tree Davies
2024-06-12 7:02 ` Dan Carpenter [this message]
2024-06-13 4:13 ` [PATCH v2 00/24] Staging: rtl8192e: Maintenance renames and cleanup Philipp Hortmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7918dbd5-45e3-4b61-8bb7-eb8a27a8d152@moroto.mountain \
--to=dan.carpenter@linaro.org \
--cc=anjan@momi.ca \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=philipp.g.hortmann@gmail.com \
--cc=tdavies@darkphysics.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®