Re: [PATCH v3 1/2] media: i2c: vd55g1: preserve the stream-start error

[Benjamin Mugnier <benjamin.mugnier@foss.st.com>]

Hi,

Thank you for your patch.

Le 13/10/2026 à 05:10, Jizhou Tong a écrit :
> The stream-start error path replaces failures from register accesses and
> sensor configuration with -EINVAL. This hides the cause of failures such
> as an I2C error or a timeout.
> 
> Return the saved error after dropping the runtime PM reference. All
> paths reaching this label already set ret to the error that triggered
> cleanup.
> 
> Signed-off-by: Jizhou Tong <fqwqf@fqwqf.xyz>

Reviewed-By: Benjamin Mugnier <benjamin.mugnier@foss.st.com>

> ---
> Changes in v3: no code changes from v2.
> 
> Fault-injection harness:
> https://gist.github.com/fQwQf/60bd12627e06b10a2fc159e545f85dae/7b21a7d3a1b676a0e4cdaba06168ede09a2949e3
> 
>  drivers/media/i2c/vd55g1.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/media/i2c/vd55g1.c b/drivers/media/i2c/vd55g1.c
> index 6f458f611f63451c97c708e187a313cf7b2aab4c..78e4aebfdd3b24b867ea4d077dc1b676c4a595da 100644
> --- a/drivers/media/i2c/vd55g1.c
> +++ b/drivers/media/i2c/vd55g1.c
> @@ -1178,7 +1178,7 @@ static int vd55g1_enable_streams(struct v4l2_subdev *sd,
>  
>  err_rpm_put:
>  	pm_runtime_put(sensor->dev);
> -	return -EINVAL;
> +	return ret;
>  }
>  
>  static int vd55g1_disable_streams(struct v4l2_subdev *sd,

-- 
Regards,
Benjamin