From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C0B53C56202 for ; Tue, 17 Nov 2020 04:30:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 85B282463D for ; Tue, 17 Nov 2020 04:30:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727211AbgKQE3s (ORCPT ); Mon, 16 Nov 2020 23:29:48 -0500 Received: from smtprelay0081.hostedemail.com ([216.40.44.81]:40988 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726315AbgKQE3r (ORCPT ); Mon, 16 Nov 2020 23:29:47 -0500 Received: from filter.hostedemail.com (clb03-v110.bra.tucows.net [216.40.38.60]) by smtprelay04.hostedemail.com (Postfix) with ESMTP id 431E8180A7FD8; Tue, 17 Nov 2020 04:29:47 +0000 (UTC) X-Session-Marker: 6A6F6540706572636865732E636F6D X-HE-Tag: love12_3c02c282732e X-Filterd-Recvd-Size: 1902 Received: from XPS-9350.home (unknown [47.151.133.149]) (Authenticated sender: joe@perches.com) by omf13.hostedemail.com (Postfix) with ESMTPA; Tue, 17 Nov 2020 04:29:46 +0000 (UTC) Message-ID: <791b3213aaabd5ecccc9d3f6dd0e8ee420611dbd.camel@perches.com> Subject: Re: [PATCH v3] checkpatch: add fix option for MAINTAINERS_STYLE From: Joe Perches To: Aditya Srivastava , Andrew Morton Cc: linux-kernel-mentees@lists.linuxfoundation.org, linux-kernel@vger.kernel.org, lukas.bulwahn@gmail.com Date: Mon, 16 Nov 2020 20:29:45 -0800 In-Reply-To: <1b9c5353c6318cc7a4e013886012739e6627d82d.camel@perches.com> References: <20201117040501.21914-1-yashsri421@gmail.com> <1b9c5353c6318cc7a4e013886012739e6627d82d.camel@perches.com> Content-Type: text/plain; charset="ISO-8859-1" User-Agent: Evolution 3.38.1-1 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 2020-11-16 at 20:26 -0800, Joe Perches wrote: > On Tue, 2020-11-17 at 09:35 +0530, Aditya Srivastava wrote: > > Checkpatch expects entries in MAINTAINERS file in a specific order and > > warns if the changes made do not follow the specified order. > > > > E.g., running checkpatch on commit b33bc2b878e0 ("nexthop: Add entry to > > MAINTAINERS") reports this warning: > > > > WARNING: Misordered MAINTAINERS entry - list file patterns in > > alphabetic order > > +F: include/uapi/linux/nexthop.h > > +F: include/net/netns/nexthop.h > > > > Provide a simple fix by swapping the unordered lines, if both the lines > > are additions (start with '+') > > On second thought, nak. > > This fails when there are 3 consecutive misordered lines. > > SECTION > F: c > F: b > F: a > btw: scripts/parse-maintainers.pl already does this reordering properly so this particular --fix addition isn't all that useful.