From: Vasily Averin <vvs@openvz.org>
To: Michal Hocko <mhocko@suse.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Shakeel Butt <shakeelb@google.com>,
Roman Gushchin <roman.gushchin@linux.dev>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm/memcg: minor cleanup in non-memcg_kmem version of mem_cgroup_from_obj()
Date: Mon, 25 Apr 2022 11:40:21 +0300 [thread overview]
Message-ID: <791eca4c-8ffe-7ddf-cc48-7c3a29b858d2@openvz.org> (raw)
In-Reply-To: <YmZPqAOLO7XkBsW8@dhcp22.suse.cz>
On 4/25/22 10:37, Michal Hocko wrote:
> On Sat 23-04-22 05:23:03, Vasily Averin wrote:
>> Replace leading spaces by tab:
>> WARNING: please, no spaces at the start of a line
>> #X: FILE: include/linux/memcontrol.h:1480:
>> + return NULL;$
>>
>> Fixes: commit 8380ce479010 ("mm: fork: fix kernel_stack memcg stats for various stack implementations")
>
> Please drop the Fixes tag. The tag is supposed to point to a functional
> breakage and this is purely a style fix.
>
>> Signed-off-by: Vasily Averin <vvs@openvz.org>
>
> Acked-by: Michal Hocko <mhocko@suse.com>
Andrew Morton suggested do not create separate patch for this change,
So I'm going to combine it with my next patch, which adds a few lines below.
Even if it will not be approved -- it isn't a big problem, someone will fix it later.
prev parent reply other threads:[~2022-04-25 8:40 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-23 2:23 Vasily Averin
2022-04-23 13:17 ` Shakeel Butt
2022-04-25 7:37 ` Michal Hocko
2022-04-25 8:40 ` Vasily Averin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=791eca4c-8ffe-7ddf-cc48-7c3a29b858d2@openvz.org \
--to=vvs@openvz.org \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mhocko@suse.com \
--cc=roman.gushchin@linux.dev \
--cc=shakeelb@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®