From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 29AAEEB64DD for ; Sun, 6 Aug 2023 02:20:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229609AbjHFCGA (ORCPT ); Sat, 5 Aug 2023 22:06:00 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49966 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229445AbjHFCF6 (ORCPT ); Sat, 5 Aug 2023 22:05:58 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 22F5D1FF3 for ; Sat, 5 Aug 2023 19:05:58 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id A637E60F64 for ; Sun, 6 Aug 2023 02:05:57 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 977F0C433C7; Sun, 6 Aug 2023 02:05:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1691287557; bh=Z4QnozTfyOTeA6ryCGMdqKhzAe2vCk+mRvcfqr/TDAc=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=dKJyxiFD3aOn3IzP847Q8tCFPdH+u9Cx9OqBpcqrUizUtkVlkZ5leIYSUl8IwbANo x5AvixfliXQjyqOQxw/n1CkuigL6VOQvlfNVLMhICwCQxJgpRLY7UkG3+NENE9fGfO tgZLnQR5iZyf4bxsBwvGBQrKqIz0z5Vx2oLWTwEFr59AWBeqvIHhwD1X3ZsPpkQ7ff 9i49QGrRyFQ+mZ1ZZ8l64xiQuNpozK3qoK9+cnzdFVYG51Aw76ft+9F41MxFMef9Rh +T1j1/veJ6btMX81rdc361Sh/gr8jq42Y5dLMdNn71HXqxMxNXZU83BTetZn8patvz zfIzbhMfy3Oow== Message-ID: <791fbf71-093e-3ef5-b02b-6d6bba72b57f@kernel.org> Date: Sun, 6 Aug 2023 10:05:53 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH 1/1] f2fs: move fiemap to use iomap framework Content-Language: en-US To: Wu Bo , Jaegeuk Kim Cc: linux-f2fs-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org, wubo.oduw@gmail.com, Daeho Jeong References: <20230731012626.6843-1-bo.wu@vivo.com> From: Chao Yu In-Reply-To: <20230731012626.6843-1-bo.wu@vivo.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2023/7/31 9:26, Wu Bo wrote: > This patch has been tested with xfstests by running 'kvm-xfstests -c > f2fs -g auto' with and without this patch; no regressions were seen. > > Some tests fail both before and after, and the test results are: > f2fs/default: 683 tests, 9 failures, 226 skipped, 30297 seconds > Failures: generic/050 generic/064 generic/250 generic/252 generic/459 > generic/506 generic/563 generic/634 generic/635 Can you please take a look at gerneic/473 ? generic/473 1s ... - output mismatch (see /media/fstests/results//generic/473.out.bad) --- tests/generic/473.out 2022-11-10 08:42:19.231395230 +0000 +++ /media/fstests/results//generic/473.out.bad 2023-08-04 02:02:01.000000000 +0000 @@ -6,7 +6,7 @@ 1: [256..287]: hole Hole + Data 0: [0..127]: hole -1: [128..255]: data +1: [128..135]: data Hole + Data + Hole 0: [0..127]: hole ... (Run 'diff -u /media/fstests/tests/generic/473.out /media/fstests/results//generic/473.out.bad' to see the entire diff) Other concern is, it needs to test this implementation on compressed file, since the logic is a little bit complicated. +Cc Daeho Jeong Thanks,