mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Ricardo Rivera-Matos <rriveram@opensource.cirrus.com>
To: Mark Brown <broonie@kernel.org>
Cc: David Rhodes <david.rhodes@cirrus.com>,
	Richard Fitzgerald <rf@opensource.cirrus.com>,
	Liam Girdwood <lgirdwood@gmail.com>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
	linux-sound@vger.kernel.org, patches@opensource.cirrus.com,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] ASoC: cs35l45: Adds support for SYNC bus
Date: Thu, 13 Aug 2026 09:12:34 -0500	[thread overview]
Message-ID: <7925cb49-8b69-4006-9a0b-ef8538db319f@opensource.cirrus.com> (raw)
In-Reply-To: <ccd9a584-0f3e-4585-a563-e2c720e20b92@sirena.org.uk>



On 8/12/26 1:03 PM, Mark Brown wrote:
> On Tue, Aug 11, 2026 at 05:06:03PM +0000, Ricardo Rivera-Matos wrote:
>> Adds support for the multidevice synchronization (SYNC) bus.
>> The SYNC bus is an opaque one wire bus that is shared between
>> Cirrus devices. Initial support only includes software (SW)
>> data packets.
> 
>> +	ret = of_property_read_u32(child, "sync-lsw-txid", &val);
>> +	if (!ret)
>> +		regmap_update_bits(cs35l45->regmap, CS35L45_SYNC_SW_TX_ID,
>> +				   CS35L45_SYNC_LSW_TXID_MASK, val << CS35L45_SYNC_LSW_TXID_SHIFT);
>> +
>> +	ret = of_property_read_u32(child, "sync-sw-txid", &val);
>> +	if (!ret)
>> +		regmap_update_bits(cs35l45->regmap, CS35L45_SYNC_SW_TX_ID,
>> +				   CS35L45_SYNC_SW_TXID_MASK, val);
> 
> These are namespace cirrus, in the binding.

ACK. The binding is correct, the driver and my test dtb are stale. This 
will get fixed in v2.


      reply	other threads:[~2026-08-13 14:13 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-11 17:06 [PATCH 0/2] Introduces MDSYNC support for CS35L45 Ricardo Rivera-Matos
2026-08-11 17:06 ` [PATCH 1/2] ASoC: dt-bindings: cs35l45: Adds SYNC properties Ricardo Rivera-Matos
2026-08-11 17:06 ` [PATCH 2/2] ASoC: cs35l45: Adds support for SYNC bus Ricardo Rivera-Matos
2026-08-11 17:24   ` Mark Brown
2026-08-11 21:12     ` Ricardo Rivera-Matos
2026-08-12 18:03   ` Mark Brown
2026-08-13 14:12     ` Ricardo Rivera-Matos [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7925cb49-8b69-4006-9a0b-ef8538db319f@opensource.cirrus.com \
    --to=rriveram@opensource.cirrus.com \
    --cc=broonie@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=david.rhodes@cirrus.com \
    --cc=devicetree@vger.kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=lgirdwood@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sound@vger.kernel.org \
    --cc=patches@opensource.cirrus.com \
    --cc=perex@perex.cz \
    --cc=rf@opensource.cirrus.com \
    --cc=robh@kernel.org \
    --cc=tiwai@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®