mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jori Koolstra <jkoolstra@xs4all.nl>
To: Jan Kara <jack@suse.cz>
Cc: Christian Brauner <brauner@kernel.org>,
	"skhan@linuxfoundation.org" <skhan@linuxfoundation.org>,
	Khalid Aziz <khalid@kernel.org>,
	Tetsuo Handa <penguin-kernel@i-love.sakura.ne.jp>,
	Taotao Chen <chentaotao@didiglobal.com>,
	Jeff Layton <jlayton@kernel.org>, NeilBrown <neil@brown.name>,
	linux-kernel@vger.kernel.org,
	syzbot+4e49728ec1cbaf3b91d2@syzkaller.appspotmail.com
Subject: Re: [PATCH] Add error handling to minix filesystem similar to ext4
Date: Thu, 30 Oct 2025 13:22:53 +0100 (CET)	[thread overview]
Message-ID: <792975039.3142581.1761826973320@kpc.webmail.kpnmail.nl> (raw)
In-Reply-To: <su4qka5wugz3asm3sakmptgeeogx6duj6kc7doom5r4fhdwdcv@ogp4lz5gxn7x>

Hi Jan,

> 
> The patch looks ok to me but since minix filesystem driver is in the kernel
> mostly to allow mounting ancient unix filesystems I don't quite understand
> the motivation for adding the new mount options. Why not just fixup
> minix_rmdir() to better handle corrupted filesystems?
> 
> 								Honza

I am doing the Linux kernel mentorship program, and was looking to contribute
to fs. Since I saw a lot bugs on syzbot related to minix (and jfs too) not
handling corruptions well (yielding warnings in drop_nlink e.g.) I figured
it was a low stakes project, not completely trivial, yet within my scope, to
attempt to implement what ext4 does for these kind of problems (and jfs
implements the same opts too).

I would have asked about the exact status of minix, but was told not to
bother maintainers without a patch. I would be open with trying to improve
minix further, but of course if there are better options to get it out of
the kernel altogether that may be better. Sad for me, since that means still
zero patches, but that is not your problem :)

Anyway, I hope this clarifies why I submitted this patch.

  parent reply	other threads:[~2025-10-30 12:24 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-10-28 20:58 Jori Koolstra
2025-10-30 10:59 ` Jan Kara
2025-10-30 11:18   ` Tetsuo Handa
2025-10-30 11:35     ` Jan Kara
2025-10-30 12:22   ` Jori Koolstra [this message]
2025-10-30 12:59     ` Jeff Layton
2025-10-30 13:31       ` Jori Koolstra
2025-10-30 13:43         ` Jeff Layton
2025-10-30 14:09           ` Jori Koolstra
2025-10-30 15:12             ` Jeff Layton
2025-10-30 15:44               ` Shuah Khan
2025-10-30 17:12                 ` Jan Kara
2025-10-30 17:40                 ` Jeff Layton
2025-10-30 17:18               ` Jan Kara
2025-10-30 23:42                 ` Jori Koolstra
2025-10-30 17:22           ` Jan Kara
2025-10-30 18:00             ` Jeff Layton
2025-10-30 15:38         ` Shuah Khan
2025-10-30 17:01     ` Jan Kara
2025-10-30 23:16       ` Jori Koolstra
2025-10-31 15:38         ` Jan Kara
2025-11-01 20:27 ` kernel test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=792975039.3142581.1761826973320@kpc.webmail.kpnmail.nl \
    --to=jkoolstra@xs4all.nl \
    --cc=brauner@kernel.org \
    --cc=chentaotao@didiglobal.com \
    --cc=jack@suse.cz \
    --cc=jlayton@kernel.org \
    --cc=khalid@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=neil@brown.name \
    --cc=penguin-kernel@i-love.sakura.ne.jp \
    --cc=skhan@linuxfoundation.org \
    --cc=syzbot+4e49728ec1cbaf3b91d2@syzkaller.appspotmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®